Implement chrome://safe-browsing/ page as part of the chrome://about/. Design Doc about chrome://safe-browsing: go/safebrowsingpage
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/422a878152e9cbada622e6e7f6cfc98d60af96b0 commit 422a878152e9cbada622e6e7f6cfc98d60af96b0 Author: hkamila <hkamila@google.com> Date: Wed Jul 12 02:51:08 2017 -Added the experimental features section as part of the chrome://safe-browsing. For the experiments not running at 100%. -Exported the list of SafeBrowsing features (base::Feature) to have them in the future in a central location. -Fixed the message dialogue for the WebUI. -Added some extra css. Note: Tags for the experiments are not added in this issue. Review-Url: https://codereview.chromium.org/2964693003 Cr-Commit-Position: refs/heads/master@{#485380} Committed: https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5 BUG= 740955 , 734667 Review-Url: https://codereview.chromium.org/2964693003 Cr-Commit-Position: refs/heads/master@{#485821} [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/renderer/safe_browsing/DEPS [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/chrome/test/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/resources/safe_browsing_resources.grdp [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/BUILD.gn [add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/features.cc [add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/features.h [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/DEPS [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/threat_dom_details.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/renderer/threat_dom_details.h [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.css [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.html [add] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing/web_ui/safe_browsing_ui.h [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/BUILD.gn [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/DEPS [modify] https://crrev.com/422a878152e9cbada622e6e7f6cfc98d60af96b0/components/safe_browsing_db/v4_feature_list.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f8a63c81a3165d005b76bac326483d513ece45c commit 3f8a63c81a3165d005b76bac326483d513ece45c Author: hkamila <hkamila@google.com> Date: Mon Jul 17 17:29:33 2017 Added preferences as part of chrome://safe-browsing Added the Safe Browsing Preferences as part of the chrome://safe-browsing page. Added the respective webui messages/functions. Bug: 734667 Change-Id: I481a9c930ed1859c2a93ff32670e009fb148ae02 Reviewed-on: https://chromium-review.googlesource.com/566383 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#487134} [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/common/safe_browsing_prefs.cc [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/common/safe_browsing_prefs.h [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/features.cc [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/DEPS [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/resources/safe_browsing.css [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/3f8a63c81a3165d005b76bac326483d513ece45c/components/safe_browsing/web_ui/safe_browsing_ui.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8810fed602a4fe3c1f58804dabebca557e43ba7 commit e8810fed602a4fe3c1f58804dabebca557e43ba7 Author: hkamila <hkamila@google.com> Date: Fri Jul 21 17:36:25 2017 SafeBrowsing: Added the webui protobuf Implemented the webui protobuf that will collect information about the database status as size, update, stores, and more. Bug: 734667 Change-Id: If920b7c3d90b7e6dfd24c0256b3042900737d7a5 Reviewed-on: https://chromium-review.googlesource.com/578384 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488694} [modify] https://crrev.com/e8810fed602a4fe3c1f58804dabebca557e43ba7/components/safe_browsing/web_ui/BUILD.gn [add] https://crrev.com/e8810fed602a4fe3c1f58804dabebca557e43ba7/components/safe_browsing/web_ui/webui.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe55ab12cd7bd55078816d0419f5b7630aa43f2 commit 6fe55ab12cd7bd55078816d0419f5b7630aa43f2 Author: hkamila <hkamila@google.com> Date: Fri Jul 28 03:08:59 2017 Adding Safe Browsing database information in the WebUI proto Added the following information: - database size - last update network code - last update time - stores size - stores update status - database updated successfully Bug: 734667 Change-Id: I578013c1780ce7c478aa1e816e4ff4e4958e1563 Reviewed-on: https://chromium-review.googlesource.com/585412 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#490234} [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing/web_ui/webui.proto [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/BUILD.gn [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/DEPS [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_database.cc [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_database.h [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_store.cc [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_store.h [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_update_protocol_manager.cc [modify] https://crrev.com/6fe55ab12cd7bd55078816d0419f5b7630aa43f2/components/safe_browsing_db/v4_update_protocol_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c983b345db0ad87870a1f20dc7d69935e7cb0b3e commit c983b345db0ad87870a1f20dc7d69935e7cb0b3e Author: hkamila <hkamila@google.com> Date: Tue Aug 01 17:41:23 2017 Adding WebUI functions passing and processing the WebUI proto Added the functions in the WebUI side which are going to process the proto information for the Safe Browsing database and show it in the page. Bug: 734667 Change-Id: I10d8c89318a02563b2ce803110339191fe88aac6 Reviewed-on: https://chromium-review.googlesource.com/585230 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#491045} [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/DEPS [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/resources/safe_browsing.css [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing/web_ui/safe_browsing_ui.h [modify] https://crrev.com/c983b345db0ad87870a1f20dc7d69935e7cb0b3e/components/safe_browsing_db/v4_update_protocol_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e81dafa9a584ce48a54706b7d0acb3a959cf491f commit e81dafa9a584ce48a54706b7d0acb3a959cf491f Author: hkamila <hkamila@google.com> Date: Thu Aug 03 01:28:22 2017 Added last update time and number of database checks per store Added to the protobuf, and to the WebUi and V4store: - Last update time per store. - Number of checks to the database per store. Bug: 734667 Change-Id: I24075cb9b926ff0d3c72ef9e97ea37035a46e144 Reviewed-on: https://chromium-review.googlesource.com/596692 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491596} [modify] https://crrev.com/e81dafa9a584ce48a54706b7d0acb3a959cf491f/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/e81dafa9a584ce48a54706b7d0acb3a959cf491f/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/e81dafa9a584ce48a54706b7d0acb3a959cf491f/components/safe_browsing/web_ui/webui.proto [modify] https://crrev.com/e81dafa9a584ce48a54706b7d0acb3a959cf491f/components/safe_browsing_db/v4_store.cc [modify] https://crrev.com/e81dafa9a584ce48a54706b7d0acb3a959cf491f/components/safe_browsing_db/v4_store.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f93dc1fa808e6104e21cdf18fec4e58728739ec3 commit f93dc1fa808e6104e21cdf18fec4e58728739ec3 Author: hkamila <hkamila@google.com> Date: Tue Aug 08 01:23:11 2017 Added the FullHashCache information in the Safe Browsing page Added the protobuf message about FullHashCache Added the initializing functions for the message Bug: 734667 Change-Id: I3a0000d53925009102cb8122a0bdda75534c58c4 Reviewed-on: https://chromium-review.googlesource.com/597387 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#492490} [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing/web_ui/webui.proto [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing_db/BUILD.gn [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing_db/v4_get_hash_protocol_manager.cc [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing_db/v4_get_hash_protocol_manager.h [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/f93dc1fa808e6104e21cdf18fec4e58728739ec3/components/safe_browsing_db/v4_update_protocol_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb commit 30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb Author: hkamila <hkamila@google.com> Date: Sat Aug 12 03:02:23 2017 Moved safe_browsing protos to safe_browsing/proto To make importing one proto to the other easier, moved the safe browsing protos "cds.proto" and "webui.proto" to components/safe_browsing/proto/ tbr: sky@chromium.org Bug: 734667 Change-Id: I537b39537375f9b4d7ca00cc32aa68990673b946 Reviewed-on: https://chromium-review.googlesource.com/611608 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Luke Z <lpz@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#493945} [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/download/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/download/download_commands.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/download/download_danger_prompt.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/download/download_danger_prompt_browsertest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/browser_feature_extractor.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/client_side_detection_host.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/client_side_detection_service.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/client_side_model_loader.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/client_side_model_loader_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/download_feedback.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/download_feedback_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/download_protection_service.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/download_protection_service_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/notification_image_reporter.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/signature_evaluator_mac.mm [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/browser/safe_browsing/threat_details_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/archive_analyzer_results.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/binary_feature_extractor.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/binary_feature_extractor_mac.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/binary_feature_extractor_mac_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/binary_feature_extractor_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/binary_feature_extractor_win.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/download_protection_util.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/zip_analyzer.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/common/safe_browsing/zip_analyzer.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/renderer/safe_browsing/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/renderer/safe_browsing/phishing_classifier.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/tools/safe_browsing/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/tools/safe_browsing/sb_sigutil.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/utility/safe_browsing/mac/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/chrome/utility/safe_browsing/mac/dmg_analyzer.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/BUILD.gn [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/browser/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/browser/threat_details.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/password_protection/password_protection_service.h [rename] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/proto/csd.proto [rename] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/proto/webui.proto [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing/web_ui/safe_browsing_ui.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/BUILD.gn [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/DEPS [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_database.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_database.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_get_hash_protocol_manager.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_store.cc [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_store.h [modify] https://crrev.com/30cda2bb8191b8946a499c7ef83d2ef1cfbf7bdb/components/safe_browsing_db/v4_update_protocol_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac commit ce59cd0c97049ab4222c5e47fa07fb560dbe94ac Author: hkamila <hkamila@google.com> Date: Sat Sep 02 00:07:00 2017 Added ThreatDetails to chrome://safe-browsing (AutoRefresh) Added ThreatDetails fields in the chrome://safe-browsing page. When a new ping is sent in ThreatDetails class, the data will automatically be shown on the WebUI tabs that are opened. If no WebUI tabs are opened, no data will be recorded. Bug: 734667 Change-Id: I9bd3ec7bbd50e0b515abd9aaa2866b6f2abf29e2 Reviewed-on: https://chromium-review.googlesource.com/621273 Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#499353} [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/browser/BUILD.gn [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/browser/threat_details.cc [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/web_ui/BUILD.gn [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/web_ui/DEPS [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/web_ui/resources/safe_browsing.html [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/web_ui/resources/safe_browsing.js [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/web_ui/safe_browsing_ui.cc [modify] https://crrev.com/ce59cd0c97049ab4222c5e47fa07fb560dbe94ac/components/safe_browsing/web_ui/safe_browsing_ui.h
The assigned owner "hkamila@google.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Fixed by hkamila@
Comment 1 by hkamila@google.com
, Jun 19 2017