Issue metadata
Sign in to add a comment
|
146.6%-312.2% regression in blink_perf.dom at 479812:479995 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976337914846491520
,
Jun 19 2017
=== Auto-CCing suspected CL author yosin@chromium.org === Hi yosin@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : yosin Commit : be338602c635fd6472f07ee1665dfccb7a83833a Date : Fri Jun 16 01:47:43 2017 Subject: Introduce InSameLine() with Node and VisiblePosition Bisect Details Configuration: mac_pro_perf_bisect Benchmark : blink_perf.dom Metric : move-up-with-hidden-elements/move-up-with-hidden-elements Change : 292.65% | 0.308333333333 -> 1.21066666667 Revision Result N chromium@479886 0.308333 +- 0.0245628 6 good chromium@479892 0.301833 +- 0.00931844 6 good chromium@479893 1.2265 +- 0.0245255 6 bad <-- chromium@479894 1.2325 +- 0.0278837 6 bad chromium@479895 1.23167 +- 0.0448702 6 bad chromium@479898 1.1635 +- 0.0827617 6 bad chromium@479909 1.15167 +- 0.0330353 6 bad chromium@479931 1.224 +- 0.0573411 6 bad chromium@479976 1.21067 +- 0.0355434 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976337914846491520 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4995380074250240 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 20 2017
,
Jun 20 2017
In review: http://crrev.com/2952563002
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116 commit 5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116 Author: yosin <yosin@chromium.org> Date: Wed Jun 21 01:12:38 2017 Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout object This is follow-up patch of the patch[1] which introduces |InSameLine()| to return wrong value for nodes without layout object. Original code: while (node && !node->GetLayoutObject() || InSameLine(...) The patch[1]: while (InSameLine(node, ...) InSameLine(Node* node) if (!node->GetLayoutObject()) return false; // This is wrong. This patch fixes this error. [1] http://crrev.com/2938923003: Introduce InSameLine() with Node and VisiblePosition BUG= 734648 TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone Review-Url: https://codereview.chromium.org/2952563002 Cr-Commit-Position: refs/heads/master@{#481057} [modify] https://crrev.com/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116/third_party/WebKit/Source/core/editing/VisibleUnits.h [modify] https://crrev.com/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp [modify] https://crrev.com/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
,
Jun 21 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by chiniforooshan@chromium.org
, Jun 19 2017