New issue
Advanced search Search tips

Issue 734648 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

146.6%-312.2% regression in blink_perf.dom at 479812:479995

Project Member Reported by chiniforooshan@chromium.org, Jun 19 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=734648

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9p_FsgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9p_FsgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9sPUjQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9si94goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgjsiypgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9rWqrwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtpe1vwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtpe1vwgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9rWqrwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9rbnoQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9oOW4AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9rXTsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9ruZtgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9sP36gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtrfaywgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9pzM8QsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9pm4hgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtv3j9AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9tjbuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtujb0AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9pWVuAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtsbR3AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9q_-uwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9ortuAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtune0QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtpfhzggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9rTbnwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9r6_9QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9rCR-AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9sGprQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtvvTrwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtvvq-ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9oal_QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtrbJ4wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtsmzrQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9tCA8wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9vCZqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9qS9-QgM


Bot(s) for this bug's original alert(s):

android-nexus6
android-nexus7v2
android-one
android-webview-nexus5X
android-webview-nexus6
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 19 2017

Cc: yosin@chromium.org
Owner: yosin@chromium.org

=== Auto-CCing suspected CL author yosin@chromium.org ===

Hi yosin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : yosin
  Commit : be338602c635fd6472f07ee1665dfccb7a83833a
  Date   : Fri Jun 16 01:47:43 2017
  Subject: Introduce InSameLine() with Node and VisiblePosition

Bisect Details
  Configuration: mac_pro_perf_bisect
  Benchmark    : blink_perf.dom
  Metric       : move-up-with-hidden-elements/move-up-with-hidden-elements
  Change       : 292.65% | 0.308333333333 -> 1.21066666667

Revision             Result                      N
chromium@479886      0.308333 +- 0.0245628       6      good
chromium@479892      0.301833 +- 0.00931844      6      good
chromium@479893      1.2265 +- 0.0245255         6      bad       <--
chromium@479894      1.2325 +- 0.0278837         6      bad
chromium@479895      1.23167 +- 0.0448702        6      bad
chromium@479898      1.1635 +- 0.0827617         6      bad
chromium@479909      1.15167 +- 0.0330353        6      bad
chromium@479931      1.224 +- 0.0573411          6      bad
chromium@479976      1.21067 +- 0.0355434        6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976337914846491520

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4995380074250240


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by yosin@chromium.org, Jun 20 2017

Status: Started (was: Untriaged)

Comment 5 by yosin@chromium.org, Jun 20 2017

In review: http://crrev.com/2952563002
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116

commit 5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116
Author: yosin <yosin@chromium.org>
Date: Wed Jun 21 01:12:38 2017

Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout object

This is follow-up patch of the patch[1] which introduces |InSameLine()| to
return wrong value for nodes without layout object.

Original code:
while (node && !node->GetLayoutObject() || InSameLine(...)

The patch[1]:

while (InSameLine(node, ...)

InSameLine(Node* node)
  if (!node->GetLayoutObject())
    return false;  // This is wrong. This patch fixes this error.

[1] http://crrev.com/2938923003: Introduce InSameLine() with Node and
VisiblePosition

BUG= 734648 
TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone

Review-Url: https://codereview.chromium.org/2952563002
Cr-Commit-Position: refs/heads/master@{#481057}

[modify] https://crrev.com/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Comment 7 by yosin@chromium.org, Jun 21 2017

Status: Fixed (was: Started)

Sign in to add a comment