New issue
Advanced search Search tips

Issue 734632 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 714018
issue 734626



Sign in to add a comment

CacheStorage: Migrate from base::Bind() to base::BindOnce() or base::BindRepeating()

Project Member Reported by jsb...@chromium.org, Jun 19 2017

Issue description

See issue 714018 for full context.

This also unblocks moving QuotaClient to the "once" variants.

 

Comment 1 by jsb...@chromium.org, Jun 19 2017

Blocking: 734626 714018
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f43e59e39557ee55c2d74d600a10c0d61ae17e36

commit f43e59e39557ee55c2d74d600a10c0d61ae17e36
Author: jsbell <jsbell@chromium.org>
Date: Wed Jun 21 21:12:41 2017

CacheStorage: Migrate to BindOnce/OnceCallback/OnceClosure

Switch to base::BindOnce/OnceCallback/OnceClosure to simplify code
(movable types) and make the API more explicit.

base::AdaptCallbackForRepeating is used in a handful of places to
adapt quota manager and disk cache APIs that have not been converted,
and a few lingering base::Bind() calls remain where there are API
dependencies (e.g. quota client, base::CancelableClosure).

base::AdaptCallbackForRepeating is also used to handle batch
operations where "first caller wins" semantics are required,
simplifying the existing code.

BUG= 734632 
R=cmumford@chromium.org,tzik@chromium.org

Review-Url: https://codereview.chromium.org/2947753002
Cr-Commit-Position: refs/heads/master@{#481305}

[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_blob_to_disk_cache.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_blob_to_disk_cache.h
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_operation.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_operation.h
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_operation_unittest.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_scheduler.h
[modify] https://crrev.com/f43e59e39557ee55c2d74d600a10c0d61ae17e36/content/browser/cache_storage/cache_storage_scheduler_unittest.cc

Comment 3 by jsb...@chromium.org, Jun 26 2017

Status: Fixed (was: Available)

Sign in to add a comment