New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 734632

Blocking:
issue 714018



Sign in to add a comment

Make QuotaClient API use OnceCallback

Project Member Reported by jsb...@chromium.org, Jun 19 2017

Issue description

Currently, QuotaClient defines callbacks (GetUsageCallback, GetOriginsCallback, DeletionCallback) as base::Callback<>

Since these will only ever be called once, they can be OnceCallback, and thus allow use of BindOnce in callers.

...

This is tricky because of uses such as content/browser/cache_storage where the callbacks are passed along through other operations. Much like "const-correctness", "once-correctness" requires updating the entire transitive closure of the... um... Closures... to be correct.

Therefore, it's probably better to update each system (Indexed DB, Cache Storage, Service Worker, File System, WebSQL, ...) to be internally "once-correct" first.
 

Comment 1 by jsb...@chromium.org, Jun 19 2017

Blocking: 714018

Comment 2 by jsb...@chromium.org, Jun 19 2017

Blockedon: 734632

Comment 3 by jsb...@chromium.org, Feb 27 2018

Owner: jsb...@chromium.org
Status: Fixed (was: Available)
Changed in 8c0ebdef31450502b1b631ea596838cc48e7d2fa 
Reviewed in https://chromium-review.googlesource.com/922868

Sign in to add a comment