Issue metadata
Sign in to add a comment
|
30.2%-578% regression in media.tough_video_cases_tbmv2 at 479667:479838 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976339626860954320
,
Jun 19 2017
=== Auto-CCing suspected CL author shivanisha@chromium.org === Hi shivanisha@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : shivanisha Commit : 54d4504bd6a17d6bb7a8628446b9e0ef5c3a74cf Date : Thu Jun 15 16:52:44 2017 Subject: [cache lock fix] parallel validation: reset the values correctly on restarting Bisect Details Configuration: mac_air_perf_bisect Benchmark : media.tough_video_cases_tbmv2 Metric : memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg/video.html?src_garden2_10s.mp4 Change : 285.95% | 929.142857143 -> 3586.0 Revision Result N chromium@479666 929.143 +- 15.418 14 good chromium@479708 930.286 +- 25.6571 21 good chromium@479729 928.0 +- 0.0 14 good chromium@479734 928.0 +- 0.0 6 good chromium@479737 928.0 +- 0.0 6 good chromium@479738 928.0 +- 0.0 6 good chromium@479739 5360.67 +- 4838.22 6 bad <-- chromium@479749 3586.0 +- 9945.33 14 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.garden2.10s.mp4 media.tough_video_cases_tbmv2 Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976339626860954320 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5855657460236288 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 26 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975705740774744272
,
Jun 26 2017
It seems unlikely for this CL to be related to a memory regression, since all it is doing is fixing a crash by resetting member fields correctly when restarting a transaction. Kicking another bisect.(https://chromeperf.appspot.com/buildbucket_job_status/8975705740774744272)
,
Jun 27 2017
=== BISECT JOB RESULTS === Bisect was unable to run to completion Error: INFRA_FAILURE The bisect was able to narrow the range, you can try running with: good_revision: f660386651c6b5767034e00eb31d3ef725995add bad_revision : ffff364f06b3fa261dcf249ded47675c2d0d48a3 If failures persist contact the team (see below) and report the error. Bisect Details Configuration: mac_air_perf_bisect Benchmark : media.tough_video_cases_tbmv2 Metric : memory:chrome:browser_process:reported_by_chrome:net:effective_size_avg/memory:chrome:browser_process:reported_by_chrome:net:effective_size_avg Revision Result N chromium@479666 929.043 +- 3.11105 8 good chromium@479708 928.696 +- 1.9676 6 good chromium@479729 928.696 +- 0.0 6 good chromium@479749 1134.69 +- 393.99 9 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases_tbmv2 Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975705740774744272 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5823630274985984 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 27 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975656713869706880
,
Jun 27 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : shivanisha Commit : 54d4504bd6a17d6bb7a8628446b9e0ef5c3a74cf Date : Thu Jun 15 16:52:44 2017 Subject: [cache lock fix] parallel validation: reset the values correctly on restarting Bisect Details Configuration: mac_air_perf_bisect Benchmark : media.tough_video_cases_tbmv2 Metric : memory:chrome:browser_process:reported_by_chrome:net:effective_size_avg/memory:chrome:browser_process:reported_by_chrome:net:effective_size_avg Change : 21.71% | 929.468599034 -> 1131.2826087 Revision Result N chromium@479666 929.469 +- 3.86628 9 good chromium@479708 929.59 +- 2.49439 14 good chromium@479729 928.85 +- 2.1504 9 good chromium@479734 928.928 +- 2.54016 6 good chromium@479737 929.275 +- 1.17096 6 good chromium@479738 929.507 +- 3.60354 6 good chromium@479739 1206.33 +- 204.086 5 bad <-- chromium@479749 1131.28 +- 391.291 8 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases_tbmv2 Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975656713869706880 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5823630274985984 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 28 2017
I am OOO for 2 days and will take a look at this once I return on July 5.
,
Jan 19 2018
Looking at the graph at https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtrfaiwgM there seem to be spikes in the value but it is also returning to normal values consistently after the change mentioned in the bisect. That makes me think it could be noise. Any thoughts?
,
Jan 19 2018
Agreed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dalecur...@chromium.org
, Jun 19 2017