New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734587 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 734588



Sign in to add a comment

Modify createImageBitmap resize layout tests to enlarge the source

Project Member Reported by zakerinasab@chromium.org, Jun 19 2017

Issue description

Working on fixing crbug.com/627855, it turned out that the other createImageBitmap resize layout tests are downsizing from 32x32 to 4x4, which makes the results the same for different resize qualities. These tests should change to expansion tests (2x2 --> 4x4) such that the correct application of resize quality can be checked too.
 
Blockedon: 734588
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7

commit 5696a13dd71bbec8c7e86507e4353b4e9af0f8f7
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Jul 18 17:07:42 2017

Refactor ImageBitmap color correction code

This change addresses a couple of issues:
- Simplifies the color correction code path in ImageBitmap
by using the same general code path for all the constructors
(except ImageData which needs a separate code path).
- Adds resize option to the constructor from ImageData.
- Updates ImageBitmap resize layout tests to enlarge the
source (instead of shrinking) such that the correct application
of filter quality can be checked.

Bug: 627855, 665919 , 734587 , 734588 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I73d021a8e07c5a2387111c8daec0122cddb85ebb
Reviewed-on: https://chromium-review.googlesource.com/542959
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487505}
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-drawImage-video.html
[add] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/red-green-blue-white-2x2.ogv
[add] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/red-green-semi-transparent-2x2.png
[add] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils-resize-video.js
[add] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils-resize.js
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/texImage-imageBitmap-from-blob-resize.html
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/texImage-imageBitmap-from-canvas-resize.html
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/texImage-imageBitmap-from-image-resize.html
[add] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/texImage-imageBitmap-from-imageData-resize.html
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/LayoutTests/fast/canvas/webgl/texImage-imageBitmap-from-video-resize.html
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.h
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp
[modify] https://crrev.com/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment