window.PaymentRequest must be undefined if the feature is unavailable. |
||||||||
Issue descriptionChrome Version: 61.0.3133.0 OS: iOS What steps will reproduce the problem? (1) Go to https://woocommerce.paymentrequest.show (2) Add an item to the cart. (3) Clicking the checkout button. Since window.PaymentRequest should not be present, user should be taken to the regular check out page. window.PaymentRequest is present, so the page attempts to show the UI but nothing happens.
,
Jun 19 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2017
,
Jun 21 2017
This is not a RBS. Please provide rationale as to why this change is required to be merged to the release branch
,
Jun 21 2017
Because this is a regression introduced in M59 that completely breaks the checkout flow for users on certain sites that are dependent upon PaymentRequest. This is, I think, RBS.
,
Jun 21 2017
Verified in 61.0.3137.0 canary, iPhone 6 plus iOS 10.2.1, iPad mini 10.3.3 https://woocommerce.paymentrequest.show/checkout is shown and user is able to proceed. Looks good.
,
Jun 22 2017
,
Jun 22 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f21357748e788ce172b953e8892b6be291589d5 commit 4f21357748e788ce172b953e8892b6be291589d5 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Thu Jun 22 13:36:48 2017 [Payment Request] window.PaymentRequest must be undefined if PR is disabled BUG= 734586 , 602666 Review-Url: https://codereview.chromium.org/2949583002 Cr-Original-Commit-Position: refs/heads/master@{#480578} Review-Url: https://codereview.chromium.org/2950323002 . Cr-Commit-Position: refs/branch-heads/3112@{#441} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/4f21357748e788ce172b953e8892b6be291589d5/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/4f21357748e788ce172b953e8892b6be291589d5/ios/chrome/browser/web/chrome_web_client.mm [modify] https://crrev.com/4f21357748e788ce172b953e8892b6be291589d5/ios/chrome/browser/web/chrome_web_client_unittest.mm [modify] https://crrev.com/4f21357748e788ce172b953e8892b6be291589d5/ios/chrome/browser/web/resources/chrome_bundle.js [modify] https://crrev.com/4f21357748e788ce172b953e8892b6be291589d5/ios/chrome/browser/web/resources/payment_request.js
,
Jun 27 2017
,
Jun 28 2017
Verified on chrome beta version 60.0.3112.50 on iPhone 6 with iOS 10.3.2, iPad Air 10.2.1, following the steps mentioned in comment #0. Directed to https://woocommerce.paymentrequest.show/checkout on tapping checkout at step 2. Looks good. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mahmadi@chromium.org
, Jun 19 2017