New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734577 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 732703
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.8%-6.8% regression in loading.desktop at 478560:478692

Project Member Reported by chiniforooshan@chromium.org, Jun 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 20 2017

Cc: robertph...@google.com
Owner: robertph...@google.com

=== Auto-CCing suspected CL author robertphillips@google.com ===

Hi robertphillips@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Robert Phillips
  Commit : db4062038cc0e1b78795b840fa82a4be5705e0e2
  Date   : Mon Jun 12 15:59:47 2017
  Subject: Re-enable deferred proxies in Chrome

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : loading.desktop
  Metric       : cpuTimeToFirstMeaningfulPaint_avg/pcv1-warm/ru.wikipedia
  Change       : 4.94% | 110.189111111 -> 115.982

Revision                             Result                  N
chromium@478596                      110.189 +- 8.0346       9       good
chromium@478644                      112.737 +- 6.82613      14      good
chromium@478668                      113.127 +- 6.80236      14      good
chromium@478680                      114.454 +- 6.81875      21      good
chromium@478687                      113.518 +- 8.01922      14      good
chromium@478690                      113.107 +- 5.26048      14      good
chromium@478691                      113.538 +- 13.2067      21      good
chromium@478691,skia@03a787968a      112.849 +- 26.849       14      good
chromium@478691,skia@c9c06d4586      110.419 +- 5.22737      6       good
chromium@478691,skia@db4062038c      114.089 +- 7.30683      14      bad       <--
chromium@478692                      115.982 +- 6.06865      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=ru.wikipedia loading.desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976348575085844128

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5227093559869440


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)
I believe this is mis-assigned. Looking at the charts, many of them show the regression prior to 478616. My CL didn't roll into Chrome until 478692.
Right! I started a bisect for one of those metrics that regressed before 478616. Thanks for noticing this.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 22 2017

Mergedinto: 732703
Status: Duplicate (was: Available)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Morten Stenshorne
  Commit : 4aad5b967dc3c9405565f8a7274d2ff9c37e6405
  Date   : Mon Jun 12 14:42:54 2017
  Subject: Better handling of min/max widths that depend on the containing block.

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : loading.desktop
  Metric       : cpuTimeToFirstMeaningfulPaint_avg/pcv1-warm/ru.wikipedia
  Change       : 7.73% | 79.8818333333 -> 86.0551666667

Revision             Result                  N
chromium@478571      79.8818 +- 2.99986      6      good
chromium@478594      81.3738 +- 8.01685      9      good
chromium@478605      80.2447 +- 1.62388      6      good
chromium@478611      79.919 +- 2.67582       6      good
chromium@478614      80.9417 +- 1.56948      6      good
chromium@478615      80.5813 +- 2.89677      6      good
chromium@478616      86.0552 +- 3.11761      6      bad       <--

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=ru.wikipedia loading.desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976076051057251696

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6422837956444160


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment