Issue metadata
Sign in to add a comment
|
Add accessibility test coverage in Payments screens. |
||||||||||||||||||||||||
Issue description
Chrome Version (from "Settings > About Google Chrome"): ba3abd4a3
For all the Payments screens, we'd need accessibility test coverage, like these:
16:13 ~/Developer/bling/src % git grep \)testAccessibility
ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:1153:- (void)testAccessibilityOnBookmarksLandingPage {
ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:1165:- (void)testAccessibilityOnBookmarksEditPage {
ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:1186:- (void)testAccessibilityOnBookmarksMovePage {
ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:1208:- (void)testAccessibilityOnBookmarksMoveToNewFolderPage {
ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:1233:- (void)testAccessibilityOnBookmarksDeleteUndo {
ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm:1252:- (void)testAccessibilityOnBookmarksSelect {
ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm:156:- (void)testAccessibilityOnFindInPage {
ios/chrome/browser/ui/history/history_ui_egtest.mm:473:- (void)testAccessibilityOnHistory {
ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm:115:- (void)testAccessibilityOnMostVisited {
ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm:121:- (void)testAccessibilityOnOpenTabs {
ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm:128:- (void)testAccessibilityOnBookmarks {
ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm:135:- (void)testAccessibilityOnIncognitoTab {
ios/chrome/browser/ui/reading_list/reading_list_egtest.mm:394:- (void)testAccessibility {
ios/chrome/browser/ui/settings/autofill_settings_egtest.mm:224:- (void)testAccessibilityOnAutofillProfileViewPage {
ios/chrome/browser/ui/settings/autofill_settings_egtest.mm:233:- (void)testAccessibilityOnAutofillProfileEditPage {
ios/chrome/browser/ui/settings/block_popups_egtest.mm:175:- (void)testAccessibilityOfBlockPopupSettings {
ios/chrome/browser/ui/settings/passwords_settings_egtest.mm:330:- (void)testAccessibilityOnPasswords {
ios/chrome/browser/ui/settings/settings_egtest.mm:761:- (void)testAccessibilityOnSettingsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:769:- (void)testAccessibilityOnContentSettingsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:778:- (void)testAccessibilityOnContentSettingsBlockPopupsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:789:- (void)testAccessibilityOnContentSettingsTranslatePage {
ios/chrome/browser/ui/settings/settings_egtest.mm:799:- (void)testAccessibilityOnPrivacySettingsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:808:- (void)testAccessibilityOnPrivacyHandoffSettingsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:819:- (void)testAccessibilityOnPrivacyClearBrowsingHistoryPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:829:- (void)testAccessibilityOnBandwidthManagementSettingsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:838:- (void)testAccessibilityOnBandwidthPreloadWebpagesSettingsPage {
ios/chrome/browser/ui/settings/settings_egtest.mm:848:- (void)testAccessibilityOnSavePasswords {
ios/chrome/browser/ui/settings/settings_egtest.mm:857:- (void)testAccessibilityOnSearchEngine {
ios/chrome/browser/ui/settings/settings_egtest.mm:866:- (void)testAccessibilityOnAutofillForms {
ios/chrome/browser/ui/settings/settings_egtest.mm:874:- (void)testAccessibilityOnGoogleApps {
ios/chrome/browser/ui/settings/settings_egtest.mm:885:- (void)testAccessibilityOnGoogleChrome {
ios/chrome/browser/ui/settings/settings_egtest.mm:893:- (void)testAccessibilityOnVoiceSearch {
ios/chrome/browser/ui/settings/settings_egtest.mm:901:- (void)testAccessibilityOnPasswords {
ios/chrome/browser/ui/settings/settings_egtest.mm:908:- (void)testAccessibilityOnPasswordEditing {
ios/chrome/browser/ui/settings/settings_egtest.mm:987:- (void)testAccessibilityOnSendUsageData {
ios/chrome/browser/ui/settings/translate_ui_egtest.mm:34:- (void)testAccessibilityOfTranslateSettings {
ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:76:- (void)testAccessibilityOnToolsMenu {
The tests are pretty straightforward as they just navigate to the given screen and call chrome_test_util::VerifyAccessibilityForCurrentScreen().
,
Jun 20 2017
I think I may need to migrate the accessbility_util over to the AXE utility supported by the EG team since there are some blind spots with the current util. Implementing this now using the current util would still be fine and I can refactor to point to/use the AXE utility once I get that ported over.
,
Jun 27 2017
,
Jul 7 2017
,
Jul 7 2017
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/944975a0b6009211490a960f54530452c73dfb96 commit 944975a0b6009211490a960f54530452c73dfb96 Author: Randall Raymond <rayraymond@google.com> Date: Thu Jul 13 15:49:48 2017 [Payment Request] Adds tests for accessibility on main pages of Payment Request The added HTML file and JS file have been downloaded from here: https://rsolomakhin.github.io/pr/multi/ And thus do not need to be thoroughly reviewed. The only changes made to these files are as follows 1) In the html file an "id" attribute is added to the "buy" button, the 2016 copyright is changed to 2017, and the stylesheet and favicon links are removed. 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName" is added to options on line 106, the JSLint directives are removed from the top of the file, and the long line on line 137 was changed into two lines. Bug: 734571 Change-Id: Ib27f0e9398d3ce8922018138ad98e0e93aa6e15b Reviewed-on: https://chromium-review.googlesource.com/567215 Commit-Queue: Randall Raymond <rayraymond@google.com> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486391} [modify] https://crrev.com/944975a0b6009211490a960f54530452c73dfb96/ios/chrome/browser/ui/payments/BUILD.gn [add] https://crrev.com/944975a0b6009211490a960f54530452c73dfb96/ios/chrome/browser/ui/payments/payments_accessibility_egtest.mm [modify] https://crrev.com/944975a0b6009211490a960f54530452c73dfb96/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/944975a0b6009211490a960f54530452c73dfb96/ios/testing/BUILD.gn [add] https://crrev.com/944975a0b6009211490a960f54530452c73dfb96/ios/testing/data/http_server_files/payment_request.html [add] https://crrev.com/944975a0b6009211490a960f54530452c73dfb96/ios/testing/data/http_server_files/payment_request.js
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b054e78ca639aabe4c189e728a0d0834215ad363 commit b054e78ca639aabe4c189e728a0d0834215ad363 Author: Mike Dougherty <michaeldo@chromium.org> Date: Thu Jul 13 17:12:57 2017 Revert "[Payment Request] Adds tests for accessibility on main pages of Payment Request" This reverts commit 944975a0b6009211490a960f54530452c73dfb96. Reason for revert: These newly added tests are not passing in all configurations. For example: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/29628 Original change's description: > [Payment Request] Adds tests for accessibility on main pages of Payment Request > > The added HTML file and JS file have been downloaded from here: > > https://rsolomakhin.github.io/pr/multi/ > > And thus do not need to be thoroughly reviewed. The only changes made to these > files are as follows > 1) In the html file an "id" attribute is added to the "buy" button, the 2016 > copyright is changed to 2017, and the stylesheet and favicon links are removed. > 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName" > is added to options on line 106, the JSLint directives are removed from the top of > the file, and the long line on line 137 was changed into two lines. > > Bug: 734571 > Change-Id: Ib27f0e9398d3ce8922018138ad98e0e93aa6e15b > Reviewed-on: https://chromium-review.googlesource.com/567215 > Commit-Queue: Randall Raymond <rayraymond@google.com> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Louis Romero <lpromero@chromium.org> > Reviewed-by: mahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486391} TBR=eugenebut@chromium.org,lpromero@chromium.org,rayraymond@google.com,mahmadi@chromium.org Change-Id: Id007c92d6e9f72de546bec6672ca23aed1247904 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734571 Reviewed-on: https://chromium-review.googlesource.com/570202 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486418} [modify] https://crrev.com/b054e78ca639aabe4c189e728a0d0834215ad363/ios/chrome/browser/ui/payments/BUILD.gn [delete] https://crrev.com/67505de2c965cc513ed1371ed2e32d261189f38c/ios/chrome/browser/ui/payments/payments_accessibility_egtest.mm [modify] https://crrev.com/b054e78ca639aabe4c189e728a0d0834215ad363/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/b054e78ca639aabe4c189e728a0d0834215ad363/ios/testing/BUILD.gn [delete] https://crrev.com/67505de2c965cc513ed1371ed2e32d261189f38c/ios/testing/data/http_server_files/payment_request.html [delete] https://crrev.com/67505de2c965cc513ed1371ed2e32d261189f38c/ios/testing/data/http_server_files/payment_request.js
,
Jul 19 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d97dd57d2defd24ab490aa366a5ee1c33d209fa9 commit d97dd57d2defd24ab490aa366a5ee1c33d209fa9 Author: rayraymond <rayraymond@google.com> Date: Wed Jul 19 13:18:29 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc commit c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc Author: Randall Raymond <rayraymond@google.com> Date: Wed Jul 19 14:52:17 2017 [Payment Request] Adds tests for accessibility on main pages of Paymnet Request - Second Relanding The previous reland of this CL did not include the command line arguments for one of the build bots. This reland adds the command line argument for that build bot. TBR=lpromero@chromium.org,michaeldo@google.com Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734571 Change-Id: If9fd7b6d2741178b307c3c51763cc89fdcb44073 Reviewed-on: https://chromium-review.googlesource.com/574690 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: mahmadi <mahmadi@chromium.org> Commit-Queue: Randall Raymond <rayraymond@google.com> Cr-Commit-Position: refs/heads/master@{#487861} [modify] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/build/bots/chromium.mac/ios-simulator-eg.json [modify] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/chrome/browser/ui/payments/BUILD.gn [add] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/chrome/browser/ui/payments/payments_accessibility_egtest.mm [modify] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/testing/BUILD.gn [add] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/testing/data/http_server_files/payment_request.html [add] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/ios/testing/data/http_server_files/payment_request.js [modify] https://crrev.com/c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc/testing/buildbot/gn_isolate_map.pyl
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b54ae33872700a909e2e20990a25f6ccad2f0174 commit b54ae33872700a909e2e20990a25f6ccad2f0174 Author: Sergio Collazos <sczs@chromium.org> Date: Wed Jul 19 20:54:16 2017 Revert "[Payment Request] Adds tests for accessibility on main pages of Paymnet Request - Second Relanding" This reverts commit c7c107f1aa1758e5f88f081a6a80e4b2a58f66dc. Reason for revert: payments_accessibility_egtest Tests are failing on various devices: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/12117/steps/steps/logs/stdio https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-device-x64/builds/5818/steps/ios_chrome_ui_egtests%20%28iPad%20Air%20iOS%2010.0.1%29%20on%20iOS-10.0.1/logs/stdio I tried to run the test locally and they are failing as well Original change's description: > [Payment Request] Adds tests for accessibility on main pages of Paymnet Request - Second Relanding > > > The previous reland of this CL did not include the command line arguments for one of the build bots. > This reland adds the command line argument for that build bot. > > TBR=lpromero@chromium.org,michaeldo@google.com > > Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 734571 > > Change-Id: If9fd7b6d2741178b307c3c51763cc89fdcb44073 > Reviewed-on: https://chromium-review.googlesource.com/574690 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: mahmadi <mahmadi@chromium.org> > Commit-Queue: Randall Raymond <rayraymond@google.com> > Cr-Commit-Position: refs/heads/master@{#487861} TBR=eugenebut@chromium.org,rayraymond@google.com,mahmadi@chromium.org Change-Id: Icaea64b4801e9240c4daa25933c65149b3e051d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734571 Reviewed-on: https://chromium-review.googlesource.com/578135 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#487969} [modify] https://crrev.com/b54ae33872700a909e2e20990a25f6ccad2f0174/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/b54ae33872700a909e2e20990a25f6ccad2f0174/ios/build/bots/chromium.mac/ios-simulator-eg.json [modify] https://crrev.com/b54ae33872700a909e2e20990a25f6ccad2f0174/ios/chrome/browser/ui/payments/BUILD.gn [delete] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/ios/chrome/browser/ui/payments/payments_accessibility_egtest.mm [modify] https://crrev.com/b54ae33872700a909e2e20990a25f6ccad2f0174/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/b54ae33872700a909e2e20990a25f6ccad2f0174/ios/testing/BUILD.gn [delete] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/ios/testing/data/http_server_files/payment_request.html [delete] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/ios/testing/data/http_server_files/payment_request.js [modify] https://crrev.com/b54ae33872700a909e2e20990a25f6ccad2f0174/testing/buildbot/gn_isolate_map.pyl
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeed64d2ad8e4d508d34fcd8699860e8449509a1 commit aeed64d2ad8e4d508d34fcd8699860e8449509a1 Author: Randall Raymond <rayraymond@google.com> Date: Thu Jul 20 18:11:26 2017 [Payment Request] Adds tests for accessibility & Moves PR EG tests into its own target Because the original CL for this got reverted multiple times due to issues with working with the build bots, the original CL has combined with a second CL (both described below) such that the second CL moves the accessibility tests to a separate component. From first CL: - Adds html and js files for testing accessibility in Payment Request - CL link: https://chromium-review.googlesource.com/c/578135 - Author: rayraymond From second CL: - Creates a new target, ios_chrome_payments_egtests, for Payment Request EG tests, in expectation of a dozen coming tests. - Makes the target depend on the Payment Request test data in components/test/data/payments - CL link: https://chromium-review.googlesource.com/c/575206 - Author: mahmadi TBR=eugenebut@,lpromero@,michaeldo@,sdefresne@,eisinger@ Bug: 734571 Change-Id: I2a1213018dca57e14301b7188ac092ab9ff2ae56 Reviewed-on: https://chromium-review.googlesource.com/579647 Commit-Queue: Randall Raymond <rayraymond@google.com> Reviewed-by: mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488313} [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/components/payments/core/BUILD.gn [add] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/components/test/data/payments/payment_request.html [add] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/components/test/data/payments/payment_request.js [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/ios/build/bots/chromium.mac/ios-simulator-eg.json [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/ios/chrome/browser/ui/payments/BUILD.gn [add] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/ios/chrome/browser/ui/payments/payments_accessibility_egtest.mm [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/aeed64d2ad8e4d508d34fcd8699860e8449509a1/testing/buildbot/manage.py
,
Dec 15 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lpromero@chromium.org
, Jun 19 2017