Issue metadata
Sign in to add a comment
|
ClientIDs not attached to feedback reports |
||||||||||||||||||||||
Issue descriptionSomething appears to have regressed in the way that ClientIDs are attached to feedback reports. In http://feedback/#/Report/65943911260, I just see the following now: CLIENT_ID=<UUID: 10> I'm not sure how to find crash reports as a result. (Do we have any tests for this?)
,
Jun 20 2017
I recently added a case to anonymize UUIDs in Issue 721115 . So that means the Client IDs format matches that of UUIDs. https://en.wikipedia.org/wiki/Universally_unique_identifier
,
Jun 20 2017
We intentionally include client IDs in feedback reports so we'll be able to find corresponding crash reports. Please exclude them from the filtering.
,
Jun 29 2017
re #3: Also, other UUIDs are probably not PII of any sort. We should not try to annonymize them for no good reason. If they are useless in the report, I would rather exclude them from there.
,
Jun 29 2017
Can we revert the UUID obfuscation ASAP?
,
Jun 29 2017
I already had a CL before I went on vacation for whitelisting those values. https://codereview.chromium.org/2953353002/ Will land it now.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/164b863497272d4b45dc3ee5e19920f4b870a846 commit 164b863497272d4b45dc3ee5e19920f4b870a846 Author: afakhry <afakhry@chromium.org> Date: Thu Jun 29 18:15:29 2017 Support anonymizer whitelisted UUIDs The recent addition to the anonymizer tool to scrub any UUID was meant to scrub only peripherals IDs. But we have other important entries that shouldn't be scrubbed. This CL adds a list of whitelisted IDs that won't be scrubbed. BUG= 734566 Review-Url: https://codereview.chromium.org/2953353002 Cr-Commit-Position: refs/heads/master@{#483425} [modify] https://crrev.com/164b863497272d4b45dc3ee5e19920f4b870a846/chrome/browser/feedback/system_logs/system_logs_fetcher.cc [modify] https://crrev.com/164b863497272d4b45dc3ee5e19920f4b870a846/chrome/browser/feedback/system_logs/system_logs_fetcher.h
,
Jun 29 2017
,
Jun 29 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 29 2017
,
Jun 30 2017
Before merging anything, please make sure that privacy signs this off. I am surprised that no privacy reviewer was on the CL.
,
Jun 30 2017
Makes sense, but note that this change is restoring the state we were in before https://codereview.chromium.org/2905723002 inadvertently made us drop these IDs.
,
Jun 30 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 30 2017
I agree with #11, please update the bug when reviews are completed
,
Jun 30 2017
+glevin for privacy. This CL is just restoring the old behavior.
,
Jun 30 2017
I'm fine with restoring the old behavior for the moment, but I'd still like to continue the ongoing email discussion and clarify my understanding around client_id and feedback reports.
,
Jun 30 2017
Re#16: Does that mean OK to merge or no merge until further investigation is done?
,
Jul 1 2017
I think is ok to merge as per #16
,
Jul 1 2017
,
Jul 4 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 4 2017
Re#17: Yes, ok to merge, thanks for checking.
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/caa9199455ac156af7104f7cba8ccc8c0c86493a commit caa9199455ac156af7104f7cba8ccc8c0c86493a Author: Ahmed Fakhry <afakhry@google.com> Date: Wed Jul 05 17:14:39 2017 [Merge to M60] Support anonymizer whitelisted UUIDs The recent addition to the anonymizer tool to scrub any UUID was meant to scrub only peripherals IDs. But we have other important entries that shouldn't be scrubbed. This CL adds a list of whitelisted IDs that won't be scrubbed. TBR=xiyuan@chromium.org BUG= 734566 Review-Url: https://codereview.chromium.org/2953353002 Cr-Original-Commit-Position: refs/heads/master@{#483425} Review-Url: https://codereview.chromium.org/2971763003 . Cr-Commit-Position: refs/branch-heads/3112@{#515} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/caa9199455ac156af7104f7cba8ccc8c0c86493a/chrome/browser/feedback/system_logs/scrubbed_system_logs_fetcher.cc
,
Jul 31 2017
,
Jul 31 2017
Verified the fix in Chrome OS 9592.71.0, 60.0.3112.80. http://feedback/#/Report/69610939746 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by r...@chromium.org
, Jun 20 2017