New issue
Advanced search Search tips

Issue 734554 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
layoutng


Sign in to add a comment

[LayoutNG] Leading OOF forcing the block container has side effects

Project Member Reported by kojii@chromium.org, Jun 19 2017

Issue description

When LayoutNG is enabled, we create an anonymous block for leading OOF since https://codereview.chromium.org/2847823002

This causes the following test to fail:
fast/css/text-indent-first-line-002.html
  <div class="container">
    <span style="float:right;">Float</span>
    Block
    <div class="control"></div>
  </div>

CSS Text says:
> For example, the first line of an anonymous block box is only affected
> if it is the first child of its parent element.
https://drafts.csswg.org/css-text-3/#text-indent-property

The existing code thinks "Block" is not a "first formatted line" because the float creates an anonymous block box.

I can think of two options:
a. Revert the CL.
b. Change the first line logic to match to the new tree structure.

IIUC the CL was only needed because our inline float code was not mature enough at that point, and we're now much better, but if there were more reasons to do the change, I can try option b.

Quick investigation tells me that there are two pieces of code that need to change for option b; one in style (for ::first-line) and another in layout (for text-indent).

Thoughts?
 

Comment 1 by kojii@chromium.org, Jun 19 2017

FYI, needs WIP CL to see the failure:
https://codereview.chromium.org/2943983002
I'm ok with trying to revert that patch, we've got much better support now for floats in inlines.

Comment 3 by kojii@chromium.org, Jun 20 2017

Cc: ikilpatrick@chromium.org
Owner: kojii@chromium.org
Thanks, I'll investigate if it'll break anything when ng_bot is back.

Comment 4 by kojii@chromium.org, Jun 22 2017

21 tests in virtual/layout_ng and 85 tests in ng bot fail. It looks like we came quite far since the change.

https://codereview.chromium.org/2954433003

Maybe it's easier to change ::first-line style code, though, the code looks a bit complicated and unfamilliar. hmm...
I think I'm okay with reverting this at the moment, if you can file a bug on me to investigate the failures, but most of them look like we aren't adding border_padding to something. I'm in the midst of trying to simplify a bunch of the float offset logical, and this will help.

Comment 6 by kojii@chromium.org, Jun 28 2017

Cc: dgro...@chromium.org
Owner: ----
Status: Available (was: Assigned)
+dgrogan, haven't analyzed what all failures are about yet.

Comment 7 by kojii@chromium.org, Oct 4 2017

Hit this again, so ran the revert CL again but we still fail 19 in virtual/layout_ng and 66 in layout_ng bots.

Comment 8 by kojii@chromium.org, Nov 6 2017

Cc: atotic@chromium.org
Hit this again to fix fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html, but now 163 tests fail.

I can't compute static position for inline abspos when the block doesn't have other content. Thinking some hacks...

Comment 9 by kojii@chromium.org, Nov 7 2017

Summary: [LayoutNG] Leading OOF forcing the block container has side effects (was: [LayoutNG] Leading OOF creating anonymous block has side effects to "first formatted line")
Changed the summary as the side effects is more than anonymous block for the first-formatted-line.

fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
has:
  <div><font style="position: absolute">text</font></div>

Since <font> is "original display inline type", it needs to have inline static position.

This change makes this <div> as a block container, and that we're not running NGInlineLayoutAlgorithm.

I'll see if I can fix this specific case only.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59f47d40ab502f8c54c3e5abfc70c1e5ef383181

commit 59f47d40ab502f8c54c3e5abfc70c1e5ef383181
Author: Koji Ishii <kojii@chromium.org>
Date: Tue Nov 07 19:57:18 2017

[LayoutNG] Make leading inline OOF objects not to create block context

This CL partially reverts the change done in:
  https://codereview.chromium.org/2847823002

CSS2 defines[1]:
  An inline formatting context is established by a block container
  box that contains no block-level boxes.

Blink originally followed this description, but in the CL mentioned
above, LayoutNG changed to create a block formatting context when
it has leading floats or out-of-flow positioned objects. This change
made a few cases hard to fix.

This patch reverts to the original behavior when it is an out-of-flow
positioned objects with original display inline type, because such
objects require inline static positions and that need to be laid out
in an inline formatting context.

[1] https://drafts.csswg.org/css2/visuren.html#inline-formatting

BUG:  734554 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I983946c22fbbbe0fa922560ff372e278b5697944
Reviewed-on: https://chromium-review.googlesource.com/603489
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514554}
[modify] https://crrev.com/59f47d40ab502f8c54c3e5abfc70c1e5ef383181/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/59f47d40ab502f8c54c3e5abfc70c1e5ef383181/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/59f47d40ab502f8c54c3e5abfc70c1e5ef383181/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/59f47d40ab502f8c54c3e5abfc70c1e5ef383181/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b456486d57259ec86a8f67180fccff4e7ee482

commit 59b456486d57259ec86a8f67180fccff4e7ee482
Author: Koji Ishii <kojii@chromium.org>
Date: Thu Dec 28 01:18:09 2017

[LayoutNG] Fix 'text-indent'

This patch fixes the 'text-indent' property in a few ways:
1. Worked around  crbug.com/734554  which creates anonymous block
   when an inline formatting context has leading floats or
   out-of-flow objects.
2. NGConstraintSpace::ParentPercentResolutionInlineSize() was
   broken and no longer set at some point. Along with the fix,
   made it non-optional.

Bug: 636993,  734554 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9a67318564e31474bf1083e99ae0ba00baf45b8f
Reviewed-on: https://chromium-review.googlesource.com/844410
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526263}
[modify] https://crrev.com/59b456486d57259ec86a8f67180fccff4e7ee482/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/59b456486d57259ec86a8f67180fccff4e7ee482/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.cc
[modify] https://crrev.com/59b456486d57259ec86a8f67180fccff4e7ee482/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc
[modify] https://crrev.com/59b456486d57259ec86a8f67180fccff4e7ee482/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
[modify] https://crrev.com/59b456486d57259ec86a8f67180fccff4e7ee482/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
[modify] https://crrev.com/59b456486d57259ec86a8f67180fccff4e7ee482/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

Cc: mstensho@chromium.org
Any update on this? Anyone working on it? I'd so much like to get rid of the special rules for NG in LayoutBlockFlow::AddChild(). The layout tree mutilation machinery sure is scary enough as it is.
I was working on it at one stage (6mo ago) - but placed it on the back burner. I was periodically testing removing the special rules to see what failed. My guess is that we aren't far off.

Comment 14 by kojii@chromium.org, Jun 21 2018

Last time I tried was 6 months ago, 88 failures. I rebased and re-running to see how much we fail now:
https://chromium-review.googlesource.com/c/chromium/src/+/844313
We still seem to need it for OOFs, but we also apply it to floats. Not sure if that's really necessary.
Oh, I have an experimental CL (probably not for landing) too! :)
https://chromium-review.googlesource.com/c/chromium/src/+/1110228
Let's compare the results when the bots are done. :)
My results are in. There's a bunch of tree dump failures, because we no longer match the old NG baselines. Apart from that, there are also some actual regressions. Looks like we have issues with writing modes, e.g. external/wpt/css/css-writing-modes/float-contiguous-vrl-002.xht [1]

[1] See https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/7031/layout-test-results/results.html

There are also 4 unexpected passes, all containing floats. :)

So, this run was about removing the special behavior for floats, but keeping it for OOFs. Looks like we're not quite ready even for floats yet.

Comment 17 by kojii@chromium.org, Jun 22 2018

I didn't expect timeouts in shapes, interesting.

virtual/layout_ng from mine has 8 failures:
https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/124251/layout-test-results/results.html

If floats/OOF experts can work on fixing them, I'm good to remove it, and thus increase the failure for a while, if it makes us easier to work on.

This maybe a separate topic but I'm feeling maybe we can't put writing-mode in the phase 1. Does that make the number more reasonable to go?
I'll see if I have time to figure out what's missing to make this work next week. So I guess it's all about how the inline layout algorithm deals with floats and OOFs.
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24c2cf352799aa8e8555d12ecb6e422193b07e3

commit f24c2cf352799aa8e8555d12ecb6e422193b07e3
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Jun 27 22:23:25 2018

[LayoutNG] Don't paint body background on body if propagated to viewport.

That would cause double background painting (possibly even at the wrong
offset) and also mess up paint order for z-index:-1 children.

This fixes two tests, but will also eventually benefit 030.html and
031.html in fast/block/positioning/, which are currently passing because we
force BODY to have block children in those tests, although BODY only has
one child, which is absolutely positioned (so it shouldn't really be set to
having block children). There's special-code for NG (which we should
remove) in LayoutBlockFlow::AddChild() that forces this.

Bug:  734554 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I54274431cf309fcfb8f916d3859b0c8a07c952f0
Reviewed-on: https://chromium-review.googlesource.com/1117191
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570916}
[modify] https://crrev.com/f24c2cf352799aa8e8555d12ecb6e422193b07e3/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/f24c2cf352799aa8e8555d12ecb6e422193b07e3/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f214e085d1aa6afe790e17c4ee1bfbaf25cf25a

commit 9f214e085d1aa6afe790e17c4ee1bfbaf25cf25a
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Jun 28 09:14:30 2018

[LayoutNG] Non-"inline" abspos needs to ignore floats and text-indent.

This fixes two tests, but will also eventually benefit
floats-wrap-inside-inline-00[1234].htm in fast/block/float/, which are
currently passing because the absolutely positioned box in the test forces
its container to have block children. There's special-code for NG (which we
should remove) in LayoutBlockFlow::AddChild() that forces this (and causes
other problems).

Added a new test, to make it clear what this fix is about.

Bug:  734554 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia2c0e0b2ab61999207114fdf935880fabc2e677c
Reviewed-on: https://chromium-review.googlesource.com/1116959
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571054}
[modify] https://crrev.com/9f214e085d1aa6afe790e17c4ee1bfbaf25cf25a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[add] https://crrev.com/9f214e085d1aa6afe790e17c4ee1bfbaf25cf25a/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/between-float-and-text.html
[modify] https://crrev.com/9f214e085d1aa6afe790e17c4ee1bfbaf25cf25a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc

Comment 21 by kojii@chromium.org, Jun 29 2018

Morten, I noted in the CL discussion but copying here for easier tracking.

NGInlineNode::CanContainFirstFormattedLine() has a hack for this, see the CL in comment #11. We may need to undo it when we fix this.
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd7ee2351d18288ae2b1c39e4467af5b699d288c

commit dd7ee2351d18288ae2b1c39e4467af5b699d288c
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Fri Jul 13 01:06:49 2018

[LayoutNG] Remove layout-tree fixup for leading abs-pos & floats.

This removes the layout-tree fixup which kept leading abs-pos & floats
in an inline context in a block context.

This makes an additional 8 tests pass which needed this fix.

The failures in the patch broadly fall into these buckets.
1) Paint invalidation changes. Now that the floats are within the line
   boxes, and the paint invaldation is different. This was likely hiding
   other issues, and we'll need to investigate these.
2) Three crashes which I believe might be fixed by Christian's pending
   min/max fix.
3) One selection and one editing failure.
4) Static position of abs-pos and text alignment failures. (this was
   hiding a larger bug).
5) A few other random failures.

The rebaselines are from new layout-tree dumps, and/or "simple" (i.e.
just name changes) within the paint invalidation dumps.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib5cc99219d31cb11ef18c8f10f7f4e9e0fea8db6
Bug:  734554 
Reviewed-on: https://chromium-review.googlesource.com/1132541
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574795}
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/direct-image-compositing-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/iframes/nested-iframe-scrolling-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/overflow/scroll-ancestor-update-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/squash-transform-repainting-child-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css1/box_properties/float_margin-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css1/formatting_model/floating_elements-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c414-flt-fit-00-d-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c414-flt-wrap-00-e-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c5525-fltinln-00-c-ag-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c5525-fltwidth-01-c-g-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t090501-c414-flt-00-d-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t090501-c414-flt-01-b-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t090501-c414-flt-02-d-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t090501-c414-flt-03-b-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/4402375-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/color-correction-on-backgrounds-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/first-letter-float-after-float-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/first-letter-float-curer-float-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/nested-floating-relative-position-percentages-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/word-space-extra-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dom/HTMLImageElement/image-alt-text-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/002-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/floating-to-positioned-2-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/dynamic/floating-to-positioned-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/invalid/012-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/invalid/016-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/alt-text-wrapping-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/image-in-map-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/missing-image-border-zoom-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/clipath/clip-path-with-background-and-box-behind-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/filters/clip-filter-overflow-clip-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/background/background-image-paint-invalidation-large-abspos-div-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/overflow-into-content-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/float-in-new-block-with-layout-delta-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/invalidation-after-opacity-change-subtree-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/fixed-position-transparency-with-overflow-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/reflection/scroll-fixed-lacur-with-reflection-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/reflection/scroll-fixed-layer-with-reflection-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/fixed-and-absclute-position-scrolled-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/fixed-and-absolute-position-scrolled-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/scroll-fixed-layer-with-no-visible-content-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/scroll-fixed-layer-with-transformed-parent-layer-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/scroll-in-fixed-layer-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/scroll-in-transformed-layer-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/scroll-with-transformed-parent-layer-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/fixed-table-cell-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/fixed-table-overflow-expected.txt
[add] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/fixed-table-overflow-zindex-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/as-image/svgview-references-use-counters-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/custom/getscreenctm-in-mixed-content-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/custom/svg-fonts-in-html-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/hixie/mixed/006-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla/bugs/bug5538-expected.png
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla/bugs/bug57828-expected.png
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/alt-text-wrapping-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/image-in-map-expected.txt
[delete] https://crrev.com/83063dcc0bb9ccbed3d710ca3c8a5f008f387205/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/missing-image-border-zoom-expected.txt
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/editing/text_offset_mapping_test.cc
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/layout/ng/ng_block_node_test.cc
[modify] https://crrev.com/dd7ee2351d18288ae2b1c39e4467af5b699d288c/third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm_test.cc

Status: Fixed (was: Available)
Yay, thank you!!!
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c0ba31b8cde50183ac1e3001a95d45b3fb8190a

commit 5c0ba31b8cde50183ac1e3001a95d45b3fb8190a
Author: Koji Ishii <kojii@chromium.org>
Date: Fri Jul 13 15:10:45 2018

[LayoutNG] Remove 'text-indent' support for layout-tree fixup for leading abs-pos & floats

As CL:1132541 removed layout-tree fixup for leading abs-pos &
floats, this patch removes additional support code for
'text-indent'.

Bug:  734554 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1fcb0efda87d1f1abba110b9bbdc36e6d1fd5da0
Reviewed-on: https://chromium-review.googlesource.com/1136268
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574921}
[modify] https://crrev.com/5c0ba31b8cde50183ac1e3001a95d45b3fb8190a/third_party/blink/renderer/core/layout/layout_block_flow_line.cc
[modify] https://crrev.com/5c0ba31b8cde50183ac1e3001a95d45b3fb8190a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bd8fefa9ff2719cd99bc26672b20a3ad7ff8666

commit 3bd8fefa9ff2719cd99bc26672b20a3ad7ff8666
Author: Peter Mayo <petermayo@chromium.org>
Date: Tue Jul 17 14:53:01 2018

Re-enable 2 layout_ng layout tests

https://chromium-review.googlesource.com/1132541 seems to also have
fixed these two:
layout_ng/fast/block/float/floats-offset-inline-block-strict-line-height.html
layout_ng/fast/block/float/floats-offset-image-strict-line-height.html

See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/layout_ng/fast/block/float/floats-offset-image-strict-line-height.html%20virtual/layout_ng/fast/block/float/floats-offset-inline-block-strict-line-height.html

Bisected locally on linux.

Bug: 635619,  734554 
Change-Id: If679447ec77b8bd41bf5ea6f7f10846751ce5cd8
Reviewed-on: https://chromium-review.googlesource.com/1140276
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575639}
[modify] https://crrev.com/3bd8fefa9ff2719cd99bc26672b20a3ad7ff8666/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment