Remove Selection.Clear() from FocusController
Reported by
hu...@opera.com,
Jun 19 2017
|
|||||||
Issue descriptionFocusController clears the selection to make snav-textarea.html pass. This Clear() should be removed. Instead, spatial navigation needs to handle this case: Always expected: When caret is at <textarea> abc d| </textarea> ... UP key should trigger a jump to: <textarea> a|bc d </textarea> Expected without spatnav: When caret is placed at the topmost line, UP key should move caret to |a. Expected with spatnav: When caret is placed at the topmost line, UP key should move focus to field above.
,
Sep 27 2017
,
Sep 29 2017
,
Sep 29 2017
,
Oct 2 2017
Won't fix because it is fine that UP moves caret to |a both when spatnav is enabled and when it is not.
,
Oct 2 2017
,
Oct 2 2017
Removal of Selection.Clear() is done here: https://chromium-review.googlesource.com/c/chromium/src/+/695103
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86b13b4626266c45ee364474bcf86208d4e2e4a2 commit 86b13b4626266c45ee364474bcf86208d4e2e4a2 Author: Hugo Holgersson <hugoh@vewd.com> Date: Tue Oct 03 11:58:34 2017 Don't clear selection when spatial navigation moves focus We kept a Selection.Clear() to not break the test "snav-textarea.html". <textarea>'s behavior is the same, no matter whether --enable-spatial-navigation is used or not, so instead of clearing the <textarea>'s selection we just need to adapt the test. This is a step towards our goal of simplifying the spatial navigation code. Bug: 734552 , 770147 Change-Id: If82c99658e44aee776afa87af823e005259415e0 Reviewed-on: https://chromium-review.googlesource.com/695103 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#506010} [modify] https://crrev.com/86b13b4626266c45ee364474bcf86208d4e2e4a2/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-textarea-expected.txt [modify] https://crrev.com/86b13b4626266c45ee364474bcf86208d4e2e4a2/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-textarea.html [modify] https://crrev.com/86b13b4626266c45ee364474bcf86208d4e2e4a2/third_party/WebKit/Source/core/page/FocusController.cpp
,
Nov 20 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yosin@chromium.org
, Jun 20 2017