New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734548 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Color slider overlaps with copy color option in devtools when docked to side

Project Member Reported by sc00335...@techmahindra.com, Jun 19 2017

Issue description

Chrome Version: 61.0.3135.0 dev
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1) Launch chrome and open devtools on any page [say NTP] 
(2) Drag devtools to extreme end and open color picker window and observe sliders

Expected: Color slider should not overlap with copy to clipboard option.
Actual: Color slider overlaps with copy to clipboard option.

This is a regression issue broken in M59.

Good Build: 59.0.3033.0 dev
Bad Build: 59.0.3034.0 dev
 
Expected_ color slider.png
241 KB View Download
Actual_color slider.png
189 KB View Download

Comment 1 by ajha@chromium.org, Jun 19 2017

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest canary(61.0.3135.0) on Mac OS 10.12.5 as well.
Labels: -Needs-Bisect hasbisect
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/8db99b6d494c3b357108a3ba82c9ad52689615e5..3aa23b6bd85fa5bb3b96e23fb08f1d400a75747e

Suspecting https://codereview.chromium.org/2712063002 from changelog

@dgozman: Please confirm the behaviour and help in re-assigning if it is not related to your change.
Cc: dgozman@chromium.org
Labels: -Pri-1 Pri-2
Owner: l...@chromium.org
Erik, mind taking a look?
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4879d9b4e22b2005ad222629991381801cc64cec

commit 4879d9b4e22b2005ad222629991381801cc64cec
Author: luoe <luoe@chromium.org>
Date: Thu Jun 29 19:28:29 2017

DevTools: color swatch sliders should be positioned from left

When the color swatch's sliders were positioned from the right, it was possible
for them to overlap with other elements when the popover shrinks.

BUG= 734548 

Review-Url: https://codereview.chromium.org/2960353002
Cr-Commit-Position: refs/heads/master@{#483445}

[modify] https://crrev.com/4879d9b4e22b2005ad222629991381801cc64cec/third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css

Comment 5 by l...@chromium.org, Jul 5 2017

Status: Fixed (was: Assigned)

Sign in to add a comment