Issue metadata
Sign in to add a comment
|
5.2% regression in webrtc_perf_tests at 18639:18639 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 19 2017
It looks like encode time in this test is increasing from commit #16839 (a chromium roll), and keeps increasing gradually for later commits which also look unrelated. Rasmus, can you have a look (you're listed as one of the owners for this test)?
,
Jun 19 2017
This should be caused by https://chromium.googlesource.com/webm/libvpx.git/+/b6e1bdfc76a1d5017116aa3148cdb626feb3eb26. Over to Marco to verify if it's expected that the encode time goes up or not.
,
Jun 20 2017
That change can make dropping due to overshoot (and encoding next frame at higher QP) more likely, but didn't expect an overall increase in encode time. And not sure why it would only happen on windows. Since the increase is small, i think we can close the issue, as this change is needed for vp8-screenshare. Eric what do you think?
,
Jun 20 2017
Yeah, it's strange that this happens only on Windows, and the increased encode time also correlates with an increased media bitrate (?!) and total delay. Maybe preventing an overshoot allows it to better meet its target on subsequent frames? In any case, the change quite small and overall a positive thing. Let's close it. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by nisse@chromium.org
, Jun 19 2017