New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734536 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.2% regression in webrtc_perf_tests at 18639:18639

Project Member Reported by nisse@chromium.org, Jun 19 2017

Issue description

See the link to graphs below.
 

Comment 1 by nisse@chromium.org, Jun 19 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=734536

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9tyiogoM


Bot(s) for this bug's original alert(s):

webrtc-win-large-tests

Comment 2 by nisse@chromium.org, Jun 19 2017

Owner: brandtr@chromium.org
It looks like encode time in this test is increasing from commit #16839 (a chromium roll), and keeps increasing gradually for later commits which also look unrelated. Rasmus, can you have a look (you're listed as one of the owners for this test)?
Cc: brandtr@chromium.org sprang@chromium.org
Owner: marpan@chromium.org
Status: Assigned (was: Untriaged)
This should be caused by https://chromium.googlesource.com/webm/libvpx.git/+/b6e1bdfc76a1d5017116aa3148cdb626feb3eb26.

Over to Marco to verify if it's expected that the encode time goes up or not.

Comment 4 by marpan@chromium.org, Jun 20 2017

That change can make dropping due to overshoot (and encoding next frame at higher QP) more likely, but didn't expect an overall increase in encode time. And not sure why it would only happen on windows. Since the increase is small, i think we can close the issue, as this change is needed for vp8-screenshare. Eric what do you think?

Comment 5 by sprang@chromium.org, Jun 20 2017

Status: WontFix (was: Assigned)
Yeah, it's strange that this happens only on Windows, and the increased encode time also correlates with an increased media bitrate (?!) and total delay. Maybe preventing an overshoot allows it to better meet its target on subsequent frames?
In any case, the change quite small and overall a positive thing. Let's close it.

Sign in to add a comment