New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734532 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Google input tool crashes when performed audit

Project Member Reported by divya.pa...@techmahindra.com, Jun 19 2017

Issue description

Chrome Version: 61.0.3135.0
OS: Ubuntu 14.04, win 7

What steps will reproduce the problem?
(1)Launch chrome>>Go to CWS>> Add extension Google input tools(https://chrome.google.com/webstore/detail/google-input-tools/mclkkofklkfljcocdinagocijmpgbhab?hl=en-GB)
(2)From the chrome menu, right click on the extension icon and click on inspect pop-up option and perform an audit

Expected 
Audit should be performed

Actual
Extension crashed

Crash Report ID 80d61eb008000000

This is a regression issue broken in M60. 
===============================

Manual Bisect info:
Good build: 60.0.3109.0(474118)
Bad Build: 60.0.3110.0(474499)

 
Actual_Ext.crash.ogv
4.3 MB View Download
Expected_Ext.crash.ogv
1.3 MB View Download

Comment 1 by ajha@chromium.org, Jun 19 2017

Labels: ReleaseBlock-Stable OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest canary(61.0.3135.0) on Mac OS 10.12.5 as well.
Labels: -Needs-Bisect hasbisect
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on #60.0.3109.0 as well. By following the above steps observing two different behaviors for this issue.

1. While checking on #60.0.3102.0 no crashes has observed but the dev tools closes abruptly with no crash page and no crash ID's generated under chrome://crashes while clicking on run audit in old UI. 
2. While checking the same on #60.0.3109.0 crash is observed while clicking on run audit in new UI and crash ID is generated under chrome://crashes.

Crash ID : 30bc2bee40000000

Stack Trace:
------------
Thread 0 (id: 429942) CRASHED [EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE @ 0x00007fff52b67fd4 ] MAGIC SIGNATURE THREAD
Stack Quality50%Show frame trust levels
0x00000001111e468f	(Google Chrome Framework -ShapeCache.h:62 )	blink::ShapeCache::AddSlowCase(blink::TextRun const&, blink::ShapeCacheEntry)

Considering the first scenario as bad providing bisect information below.

Note: Unable to perform per revision bisect for the below range, so performed chromium bisect and provided the information below.

Bisect Information:
=====================
Good build: 60.0.3100.0 
Bad Build : 60.0.3102.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/6ceca38dd2d95271e9fbce453e26b651e57631a0..8a886995ef55f7c165f50a27a309761c7432bc2c

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2884133002

dgozman@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. 

Thanks!

Components: Platform>DevTools
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 21 2017

Labels: Fracas FoundIn-M-61
Users experienced this crash on the following builds:

Linux Dev 61.0.3135.4 -  17.28 CPM, 1 reports, 1 clients (signature blink::ShapeCache::AddSlowCase)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Cc: rbasuvula@chromium.org
Just to update, Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version # 61.0.3141.0

dgozman@ Could you please look into this issue.

Thanks!
Just to update, 
Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version # 61.0.3147.0

dgozman@ - Gentle Ping...!!
Could you please have a look into this issue as it has been marked as a stable blocker.

Thanks...!!
Owner: pfeldman@chromium.org
Pavel, could you please take a look?
Just to update, Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version # 61.0.3150.0

pavel@ Could you please look into this issue as it has been marked as a stable blocker.

Thanks!
Gentle ping to pfeldman@.
@pfeldman: Friendly ping!Could you please update on this issue as it has been marked as a stable blocker.

Thanks!
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: phulce@chromium.org
Cc: msrchandra@chromium.org phulce@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 748957  has been merged into this issue.
Audits 2 does not currently support auditing of extension popup windows. An immediate workaround for those interested would be to visit the URL of the popup directly (i.e. navigate to chrome-extension://<extension_id>/popup.html in a primary browser window).

Proposed change: add a error message and disable the run button when attempting to audit a popup window, or launch the audit in a new tab instead when this state is detected.
Cc: krajshree@chromium.org
 Issue 758087  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e10550cbe6502a943e54cda3eaba27f3fcd6f57

commit 9e10550cbe6502a943e54cda3eaba27f3fcd6f57
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu Aug 24 21:32:40 2017

DevTools: Prevent audit of extension popup window

* Restricts audits to targets where DevTools is dockable (standard tabs)

BUG= 734532 

Change-Id: Ie49276de38303a344e4ff18576c4934ff6dff74e
Reviewed-on: https://chromium-review.googlesource.com/630101
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497194}
[modify] https://crrev.com/9e10550cbe6502a943e54cda3eaba27f3fcd6f57/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Status: Fixed (was: Assigned)
Cc: dgozman@chromium.org bjoyce@chromium.org
 Issue 768212  has been merged into this issue.

Sign in to add a comment