New issue
Advanced search Search tips

Issue 734525 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 715051



Sign in to add a comment

Add a UI for the media engagement index

Project Member Reported by beccahughes@chromium.org, Jun 19 2017

Issue description

Add a UI at chrome://media-engagement to view Media Engagement stats

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a09ddac210fcb92434410d7bcbe61f9580e121ea

commit a09ddac210fcb92434410d7bcbe61f9580e121ea
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jul 10 11:11:11 2017

Media Engagement: Expose the scores through Mojo.

Add mojo bindings to expose the Media Engagement scores for the
WebUI.

BUG= 734525 

Change-Id: I73800107dfa2bd58f4287397fc6a463248d20249
Reviewed-on: https://chromium-review.googlesource.com/549455
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485229}
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/BUILD.gn
[add] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/BUILD.gn
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/OWNERS
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_score.h
[add] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_score_details.mojom
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_service.cc
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_service.h
[modify] https://crrev.com/a09ddac210fcb92434410d7bcbe61f9580e121ea/chrome/browser/media/media_engagement_service_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f58b31b3fa4793380406f75db5d553fd02f64e69

commit f58b31b3fa4793380406f75db5d553fd02f64e69
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Jul 18 15:16:38 2017

Media Engagement: Add a WebUI interface for viewing scores.

Add an internal WebUI interface at chrome://media-engagement for
viewing scores stored in the Media Engagement service.

BUG= 734525 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9300479df06f48b98049026c9016084bd0abb902
Reviewed-on: https://chromium-review.googlesource.com/549297
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487476}
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/BUILD.gn
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/browser_resources.grd
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/BUILD.gn
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_score_details.mojom
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_service.cc
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_service.h
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/media/media_engagement_service_unittest.cc
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/resources/media/OWNERS
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/resources/media/media_engagement.html
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/resources/media/media_engagement.js
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/ui/webui/media/OWNERS
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/ui/webui/media/media_engagement_ui.cc
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/browser/ui/webui/media/media_engagement_ui.h
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/common/url_constants.cc
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/common/url_constants.h
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/chrome/test/data/webui/media/media_engagement_browsertest.js
[modify] https://crrev.com/f58b31b3fa4793380406f75db5d553fd02f64e69/tools/gritsettings/resource_ids

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d936b237dae6ff8a317e80de57ce1a6cdecc1db9

commit d936b237dae6ff8a317e80de57ce1a6cdecc1db9
Author: Francois Beaufort <beaufort.francois@gmail.com>
Date: Thu Jul 20 12:11:08 2017

Add chrome://media-engagement to chrome://chrome-urls

BUG= 734525 

Change-Id: I75e4d4aef819f859d089b38af577a56bcbca314a
Reviewed-on: https://chromium-review.googlesource.com/576034
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488206}
[modify] https://crrev.com/d936b237dae6ff8a317e80de57ce1a6cdecc1db9/chrome/common/url_constants.cc

Blocking: 715051

Sign in to add a comment