Regression: Weird Window appears on clicking on ‘Copy to clipboard’ option in chrome://media-internals/
Reported by
abom...@etouch.net,
Jun 19 2017
|
|||
Issue descriptionChrome Version:61.0.3135.0 a990af190304be5bf38b120799c594df5a293518-refs/heads/master@{#480321}-32/64 bit OS: Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://media-internals/ 2. Click on ‘Copy to Clipboard’ button and observe. Actual:Weird Window appears after step 2 (Weird means No Tittle, no ‘OK’ and ‘Cancel’ button). Expected: Dialog box should be seen. This is regression issue, broken in ‘M 61’ and below is manual bisect info: Good build:61.0.3129.0 Bad build:61.0.3131.0
,
Jun 19 2017
With respect to comment #1: Yes,Adding title for the <dialog> for the respective Tabs.
,
Jun 19 2017
Working on a patch.
,
Jun 19 2017
Able to reproduce the issue on Windows 7,Mac 10.12.5 & ubuntu 14.04 using chrome latest Canary-61.0.3135.0. Manual Bisect: ------------ Good build:61.0.3129.0-Revision-478840 Bad build:61.0.3131.0-Revision-479564 Per revision-bisect info: ------------------------- You are probably looking for a change made after 478952 (known good), but no later than 478953 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/08012dc3513eaf24a8d44e5cd63add938ddd41e6..cc34cc148b5256fc5eb0ab46a14726be2557664d Possible suspect: ---------------- https://chromium.googlesource.com/chromium/src/+/cc34cc148b5256fc5eb0ab46a14726be2557664d Unable to assign to the suspect as it is having gmail account,tommi@assigning to you as you were listed as one of the review ers for this CL. Could you please take a look & reassign to the right owner if it is not related to your change. Thanks.
,
Jun 19 2017
Making different popup title for each tab seems superfluous, I thinking to just put "Ctrl+C to copy to clipboard, unfocus to exit." (see attached). Does that work for you?
,
Jun 19 2017
CL at https://codereview.chromium.org/2950503002/, can't add you as reviewer since I can't see your email address.
,
Jul 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6fb6c2e7e8b6aa98ad097d44e0aed5eeb9ca220 commit a6fb6c2e7e8b6aa98ad097d44e0aed5eeb9ca220 Author: loorongjie <loorongjie@gmail.com> Date: Sat Jul 22 19:11:07 2017 [media-internals] Add note to clipboard dialog BUG= 734524 Review-Url: https://codereview.chromium.org/2950503002 Cr-Commit-Position: refs/heads/master@{#488866} [modify] https://crrev.com/a6fb6c2e7e8b6aa98ad097d44e0aed5eeb9ca220/content/browser/resources/media/media_internals.css [modify] https://crrev.com/a6fb6c2e7e8b6aa98ad097d44e0aed5eeb9ca220/content/browser/resources/media/media_internals.html
,
Oct 30 2017
I think this has been fixed now |
|||
►
Sign in to add a comment |
|||
Comment 1 by loorong...@gmail.com
, Jun 19 2017