New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734524 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird Window appears on clicking on ‘Copy to clipboard’ option in chrome://media-internals/

Reported by abom...@etouch.net, Jun 19 2017

Issue description

Chrome Version:61.0.3135.0 a990af190304be5bf38b120799c594df5a293518-refs/heads/master@{#480321}-32/64 bit
OS: Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://media-internals/
2. Click on ‘Copy to Clipboard’ button and observe.

Actual:Weird Window appears after step 2 (Weird means No Tittle, no ‘OK’ and ‘Cancel’ button).
Expected: Dialog box should be seen.

This is regression issue, broken in ‘M 61’ and below is manual bisect info:
Good build:61.0.3129.0
Bad build:61.0.3131.0
 
actual.png
37.8 KB View Download
expected.png
46.3 KB View Download
In the past, implementations of copy to clipboard for each tab are different. "players" and "audio" tab use <textarea> hidden with display: none (and the popup has no title), "video capture" tab uses window.prompt() (and the popup has a title like expected.png).

In my CL at https://chromium-review.googlesource.com/c/520742/ , I unified them to all use <textarea> wrapped in <dialog> as it is more accessible.

Maybe you want to add a title for the <dialog>?

Comment 2 by abom...@etouch.net, Jun 19 2017

With respect to comment #1:
Yes,Adding title for the <dialog> for the respective Tabs.
Working on a patch.
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: tommi@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7,Mac 10.12.5 & ubuntu 14.04 using chrome latest Canary-61.0.3135.0.
Manual Bisect:
------------
Good build:61.0.3129.0-Revision-478840
Bad build:61.0.3131.0-Revision-479564

Per revision-bisect info:
-------------------------
You are probably looking for a change made after 478952 (known good), but no later than 478953 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/08012dc3513eaf24a8d44e5cd63add938ddd41e6..cc34cc148b5256fc5eb0ab46a14726be2557664d

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/cc34cc148b5256fc5eb0ab46a14726be2557664d

Unable to assign to the suspect as it is having gmail account,tommi@assigning to you as you were listed as one of the review ers for this CL.

Could you please take a look & reassign to the right owner if it is not related to your change.
Thanks.
Making different popup title for each tab seems superfluous, I thinking to just put "Ctrl+C to copy to clipboard, unfocus to exit." (see attached). Does that work for you?
Capture.PNG
21.7 KB View Download
CL at https://codereview.chromium.org/2950503002/, can't add you as reviewer since I can't see your email address.

Comment 8 by tommi@chromium.org, Oct 30 2017

Status: Fixed (was: Assigned)
I think this has been fixed now

Sign in to add a comment