New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734511 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blink of Camera icon is seen at User name on clicking Uber Tray continuously

Project Member Reported by mmanchala@chromium.org, Jun 19 2017

Issue description

Chrome Version:  61.0.3130.0/9664.0.0 dev channel Daisy,Candy & Minnie
OS: Chrome

What steps will reproduce the problem? 
(1)Sign into User -> Go to 'chrome://md-settings/changePicture' page
(2)Click on 'Take photo'(Observe Camera is enabled i.e. Capture icon(Red Dot) at 'Settings' tab is seen)-> Now click on back arrow to navigate to chrome://md-settings page 
(3)Now continuously click on Uber Tray and observe blink of Camera icon(Red Dot) is seen at User name (Please refer Video and screenshot)

Expected: No Camera icon should be seen on clicking Uber Tray continuously 

Actual:Instead blink of Camera icon is seen at User name in Uber Tray

This is Regression Issue as same is working fine in 59.0.3071.91/9460.60.0 Stable-channel Candy

Note:
1)Issue is not applicable to Linux and windows
2)Issue is also seen in M-60
@tbuckley : Please confirm the Issue
 
Actual_'Camera'Icon.jpg
266 KB View Download
Actual_'Camera'Icon.mp4
16.1 MB Download
Attaching Expected video
Expected_No'Camera'Icon.mp4
13.4 MB View Download
Cc: -steve...@chromium.org tdander...@chromium.org tbuck...@chromium.org
Owner: est...@chromium.org
I'm unable to repro on 60.0.3112.34 dev.

@estade I saw a thread with you discussing a similar issue. Think this might be related to erg@'s changes?

Comment 3 by est...@chromium.org, Jun 20 2017

Cc: e...@chromium.org
possibly. For reference, the change in question: crrev.com/6a2d7f260d8725344218710b

Comment 4 by est...@chromium.org, Jun 20 2017

but if this had been caused by erg's change then it would probably show up in m59 which branched long after the change landed.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ef89f762ea3021311302243113bb0e8876028b4

commit 1ef89f762ea3021311302243113bb0e8876028b4
Author: Evan Stade <estade@chromium.org>
Date: Thu Jul 27 23:53:12 2017

Make CrOS system menu media capture icon invisible by default.

We don't update the icon's visibility synchronously now (with
MediaCapture having been mojoified) so we have to default to false
or it will be visible briefly when the menu first opens.

I also had to fix an unrelated test that started failing because of
a view ID conflict. That test happened to be fairly useless in its
current form, so I salvaged it by referencing TrayBluetooth instead
of the defunct TraySettings.

BUG= 734511 

Change-Id: Ic3e5c0d3eb814421201b9cf9eb76ec48d91acaf6
Reviewed-on: https://chromium-review.googlesource.com/587995
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490139}
[modify] https://crrev.com/1ef89f762ea3021311302243113bb0e8876028b4/ash/ash_view_ids.h
[modify] https://crrev.com/1ef89f762ea3021311302243113bb0e8876028b4/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/1ef89f762ea3021311302243113bb0e8876028b4/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/1ef89f762ea3021311302243113bb0e8876028b4/ash/system/tray/tray_constants.h
[modify] https://crrev.com/1ef89f762ea3021311302243113bb0e8876028b4/ash/system/tray_accessibility.cc
[modify] https://crrev.com/1ef89f762ea3021311302243113bb0e8876028b4/ash/system/user/user_card_view.cc

Comment 7 by est...@chromium.org, Jul 31 2017

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e622af8f57f57c44e732431bda2cde464d7f8cd

commit 5e622af8f57f57c44e732431bda2cde464d7f8cd
Author: Evan Stade <estade@chromium.org>
Date: Mon Jul 31 18:03:47 2017

Make CrOS system menu media capture icon invisible by default.

We don't update the icon's visibility synchronously now (with
MediaCapture having been mojoified) so we have to default to false
or it will be visible briefly when the menu first opens.

I also had to fix an unrelated test that started failing because of
a view ID conflict. That test happened to be fairly useless in its
current form, so I salvaged it by referencing TrayBluetooth instead
of the defunct TraySettings.

BUG= 734511 
TBR=estade@chromium.org

(cherry picked from commit 1ef89f762ea3021311302243113bb0e8876028b4)

Change-Id: Ic3e5c0d3eb814421201b9cf9eb76ec48d91acaf6
Reviewed-on: https://chromium-review.googlesource.com/587995
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490139}
Reviewed-on: https://chromium-review.googlesource.com/594360
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#165}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5e622af8f57f57c44e732431bda2cde464d7f8cd/ash/ash_view_ids.h
[modify] https://crrev.com/5e622af8f57f57c44e732431bda2cde464d7f8cd/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/5e622af8f57f57c44e732431bda2cde464d7f8cd/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/5e622af8f57f57c44e732431bda2cde464d7f8cd/ash/system/tray/tray_constants.h
[modify] https://crrev.com/5e622af8f57f57c44e732431bda2cde464d7f8cd/ash/system/tray_accessibility.cc
[modify] https://crrev.com/5e622af8f57f57c44e732431bda2cde464d7f8cd/ash/system/user/user_card_view.cc

Status: Fixed (was: Started)
Cc: dhadd...@chromium.org mkarkada@chromium.org
Status: Verified (was: Fixed)
Verified on Chrome OS 9827.0.0, 62.0.3176.0 dev build.

Sign in to add a comment