New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734486 link

Starred by 1 user
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Jul 2017
Cc:
sa...@chromium.org
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Web Share: share should throw TypeError if URL is invalid

Project Member Reported by mgiuca@chromium.org, Jun 19 2017 
What steps will reproduce the problem?
1. Go to https://wicg.github.io/web-share/demos/share.html
2. Type "http://localhost:65536" into the URL field.
3. Click Share.

What is the expected result?
Error: Invalid URL. (TypeError)

What happens instead of that?
Successfully shares, with an empty URL.

This was flagged in the spec review:
https://github.com/WICG/web-share/pull/35#discussion_r122607793

Not actually spec'd behaviour yet, so wait until that lands.

Comment 1 by paul.wr...@gmail.com, Jul 3 2017 

I think these are connected:
https://bugs.chromium.org/p/chromium/issues/detail?id=738943
"Chrome can't type port over 65535"

Comment 2 by paul.wr...@gmail.com, Jul 3 2017 

Stange things happen when editing url's in the Bookmark Manager too (port>65535)

Comment 3 by mgiuca@chromium.org, Jul 4 2017

Status: Fixed (was: Started)
#1, #2: See my comment on  Issue 738943 .

This landed 2 weeks ago but Bugdroid was down:

commit dd87f36fc7cb02198bca70daff3ec7708c4a67ee
Author: Matt Giuca <mgiuca@chromium.org>
Date:   Tue Jun 20 06:34:06 2017 +0000

    navigator.share: Reject with TypeError if invalid url.
    
    This is a spec compliance issue. Previously just succeeded with an empty
    URL.
    
    Bug:  734486 
    Change-Id: I8df989646227e9a75d8aaf807bf818ff971b878d
    Reviewed-on: https://chromium-review.googlesource.com/538385
    Commit-Queue: Matt Giuca <mgiuca@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#480756}
►

Sign in to add a comment