New issue
Advanced search Search tips

Issue 734484 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Prefs: don't call GetOffTheRecordPrefs when there's no OTR profile

Project Member Reported by tibell@chromium.org, Jun 19 2017

Issue description

prefence_api.cc (and some utility code that it calls) depends on being able to get a PrefService object for the OTR prefs even when there's no OTR profile. The reason for this is that the code wants to know what a pref value would be *if* there was an OTR profile.

In addition, several tests get the OTR prefs when that's not really sensible.

We should

 * fix the tests,
 * make GetOffTheRecordPrefs return null if there's no OTR profile, and
 * make preference_api.cc figure out what a pref would be in a different way (e.g. by providing some helpers in the prefs API to do this or just migrate the logic to preference_api.cc).

 

Comment 1 by dxie@chromium.org, May 30 2018

Labels: Hotlist-KnownIssue

Sign in to add a comment