New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734480 link

Starred by 1 user
Status: Verified
Owner:
calamity@chromium.org
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] Horizontal auto-scroll doesn't work on download page.

Reported by dchau...@etouch.net, Jun 19 2017 
Chrome Version: 61.0.3135.0 (Official Build)a990af190304be5bf38b120799c594df5a293518-refs/heads/master@{#480321} 32/64-bit.
OS: Windows(7,8,8.1,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.1, 10.12).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://downloads page.
2. Keep focus on 'More actions' icon using 'Tab' key.
3. Completely resize the browser from RHS to LHS.
4. Now, press 'Enter' key and observe the horizontal scroll bar.

Horizontal scroll bar doesn't auto-scroll towards RHS.
Horizontal scroll bar should auto-scroll towards RHS.

This is a regression issue, broken in M-60 series, below is manual regression range.

Good build: 60.0.3089.0 
Bad build: 60.0.3090.0 

kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.6 MB View Download
Expected behavior.mp4
944 KB View Download

Comment 1 by rbasuvula@chromium.org, Jun 19 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Providing the normal bisect due to chrome builds are not invoking in per revision bisect.
Good build:60.0.3089.0 (Revision:469220).
Bad build:60.0.3090.0 (Revision:469538).

You are probably looking for a change made after 469253 (known good), but no later than 469258 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/2d7e67c3c84d2f11e12d34bdb71fa1b2153e38a5..fb5f3276cf3cd22082643c699e6c568bdaf7e5d8

From the CL above, assigning the issue to the concern owner

@calamity: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2814743007
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3135.0

Comment 2 by dpa...@chromium.org, Jun 22 2017 

After patching https://codereview.chromium.org/2951703002 locally, I am observing a flicker, see repro in attached screencast.
viewport_scroll_flickers.mp4
143 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57f5b9ac01324e8db26dbcdca46544832088a7d

commit e57f5b9ac01324e8db26dbcdca46544832088a7d
Author: calamity <calamity@chromium.org>
Date: Fri Jun 30 04:58:49 2017

[cr-action-menu] Fix anchoring to offscreen elements.

This CL makes cr-action-menu anchor correctly to offscreen elements.
Previously, focusing the anchor element would shift the viewport, which
provided the wrong coordinates. By showing the dialog in the top-left, the
scroll is reset which correctly calculates the position of the dialog.

This CL also takes into account a scrolled body, which offsets the viewport.

BUG= 734480 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2951703002
Cr-Commit-Position: refs/heads/master@{#483634}

[modify] https://crrev.com/e57f5b9ac01324e8db26dbcdca46544832088a7d/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/e57f5b9ac01324e8db26dbcdca46544832088a7d/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Comment 4 by dchau...@etouch.net, Jul 5 2017 

Retested this issue on Windows-7 machine using Canary build# 61.0.3149.0 (Official Build). It's seems to be fixed and working as intended.

Comment 5 by calamity@chromium.org, Jul 6 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment