Issue metadata
Sign in to add a comment
|
Regression: Unnecessary dark black border is seen beneath bookmark bar if ’Show bookmark bar’ option is disable
Reported by
abom...@etouch.net,
Jun 19 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:61.0.3134.0 (Official Build) d6653466e313dc83a33ec049a6eef95a31dda435-refs/heads/master@{#480301} OS: MAC (10.12.3,10.11.6) Pre-condition:Show bookmark bar’ option should be disable. What steps will reproduce the problem? 1. Launch chrome ,Open NTP and observe beneath bookmark bar Actual: Unnecessary dark black border is seen beneath bookmark bar Expected: Unnecessary dark black border should not be seen beneath bookmark bar This is regression issue, broken in ‘M 61’ and below is manual bisect: Good build:61.0.3132.0 Bad build:61.0.3134.0 Note:Issue is not seen on Linux and Windows OS.
,
Jun 20 2017
So it appears that unlike Views, Cococa draws the bottom stroke opaquely (as opposed to on top of the bg color, honoring alpha). The code is here[1]. +tapted, do you know how to fix this or who else might have the cycles to help? Seems like it should be roughly a one liner. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm?rcl=5ea087fcae356e2f872d63d4aed4aecf20169135&l=82
,
Jun 21 2017
It should be compositing on the background..
My guess is that the line
strokeColor = [strokeColor colorWithAlphaComponent:0.5];
is replacing the 0x20 alpha with 0x80 alpha rather than multiplying it to be 0x10 alpha.
The fix is probably just to delete that line... I'll take a peep.
,
Jun 21 2017
Deleting seems to work. Attached is left-to-right: dev, canary, fixed@HEAD With the fix, the color is a *tiny* bit lighter. Certainly in incognito. But I think that was the intent of r480275 https://codereview.chromium.org/2946183002
,
Jun 21 2017
that wasn't technically the intent of that change, but I think this brings Cocoa into better alignment with Views.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36d91d332d9c8d867cd564f958e7406b7ef893c9 commit 36d91d332d9c8d867cd564f958e7406b7ef893c9 Author: tapted <tapted@chromium.org> Date: Thu Jun 22 00:34:19 2017 Mac: Don't replace the alpha on the detached toolbar separator color. The Cocoa browser used to clobber the theme's alpha with 50%. But since r480275, theme_service.cc makes appropriate adjustments to the color instead. BUG= 734476 Review-Url: https://codereview.chromium.org/2946183002 Cr-Commit-Position: refs/heads/master@{#481375} [modify] https://crrev.com/36d91d332d9c8d867cd564f958e7406b7ef893c9/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
,
Jun 22 2017
,
Jun 27 2017
Above issue seems to be fixed to Latest Dev Version:61.0.3141.0 (Official Build) 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} and Latest Canary Version:61.0.3142.0 (Official Build) using Mac Pro (10.12.3 & 10.11.6) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Jun 19 2017Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)