Migrate CupsPrintJobManagerImpl to TaskScheduler |
|||
Issue descriptionPer request from https://docs.google.com/spreadsheets/d/18x9PGMlfgWcBr4fDz2SEEtIwTpSjcBFT2Puib47ZF1w/edit#gid=0, migrate CupsPrintJobManagerImpl.
,
Jun 30 2017
In doing the migration, there are a few issues that can be cleaned up which will be attributed to this bug.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a75cc0f856961c2c8e9eed23eed3d18a8104c58 commit 2a75cc0f856961c2c8e9eed23eed3d18a8104c58 Author: skau <skau@chromium.org> Date: Thu Jul 06 01:46:14 2017 Fix nits from crrev.com/2943843002 Missed a few style issues in the last CL. Fix them. BUG= 734280 Review-Url: https://codereview.chromium.org/2968063002 Cr-Commit-Position: refs/heads/master@{#484441} [modify] https://crrev.com/2a75cc0f856961c2c8e9eed23eed3d18a8104c58/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecfb7892e75a1da32e60b9ca812066b7e18d81bb commit ecfb7892e75a1da32e60b9ca812066b7e18d81bb Author: skau <skau@chromium.org> Date: Thu Jul 13 23:26:49 2017 Remove the cups_print_job_manager_impl header The header can be merged with the implementation. Removing the extra file will result in a little less maintenance. This is a pure refactor. No code was changed. BUG= 734280 Review-Url: https://codereview.chromium.org/2963173003 Cr-Commit-Position: refs/heads/master@{#486526} [modify] https://crrev.com/ecfb7892e75a1da32e60b9ca812066b7e18d81bb/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/ecfb7892e75a1da32e60b9ca812066b7e18d81bb/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc [delete] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/chrome/browser/chromeos/printing/cups_print_job_manager_impl.h
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9195b2b71b5f80b084dac791607149b7c9550362 commit 9195b2b71b5f80b084dac791607149b7c9550362 Author: Sean Kau <skau@chromium.org> Date: Tue Jul 18 21:47:14 2017 Switch CupsPrintJobManagerImpl to use a Timer. Timer is the preferred method to schedule recurring tasks rather than rescheduling a PostDelayedTask. Bug: 734280 Change-Id: I2200a9fe636eb7e59bf868dc8227aecc82095bcc Reviewed-on: https://chromium-review.googlesource.com/575776 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#487615} [modify] https://crrev.com/9195b2b71b5f80b084dac791607149b7c9550362/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
,
Jul 18 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 29 2017