New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734280 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Migrate CupsPrintJobManagerImpl to TaskScheduler

Project Member Reported by skau@chromium.org, Jun 17 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bab2208a02c09baa03cb7cffd1bc3f6c996fa04c

commit bab2208a02c09baa03cb7cffd1bc3f6c996fa04c
Author: skau <skau@chromium.org>
Date: Thu Jun 29 17:00:40 2017

Convert to CupsPrintJobManagerImpl to TaskScheduler.

Place status polling on a sequenced task runner.  Run Cancel as a user visible task.

BUG= 734280 ,  667892 ,  689520 

Review-Url: https://codereview.chromium.org/2943843002
Cr-Commit-Position: refs/heads/master@{#483394}

[modify] https://crrev.com/bab2208a02c09baa03cb7cffd1bc3f6c996fa04c/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[modify] https://crrev.com/bab2208a02c09baa03cb7cffd1bc3f6c996fa04c/chrome/browser/chromeos/printing/cups_print_job_manager_impl.h

Comment 2 by skau@chromium.org, Jun 30 2017

In doing the migration, there are a few issues that can be cleaned up which will be attributed to this bug.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a75cc0f856961c2c8e9eed23eed3d18a8104c58

commit 2a75cc0f856961c2c8e9eed23eed3d18a8104c58
Author: skau <skau@chromium.org>
Date: Thu Jul 06 01:46:14 2017

Fix nits from crrev.com/2943843002

Missed a few style issues in the last CL.  Fix them.

BUG= 734280 

Review-Url: https://codereview.chromium.org/2968063002
Cr-Commit-Position: refs/heads/master@{#484441}

[modify] https://crrev.com/2a75cc0f856961c2c8e9eed23eed3d18a8104c58/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecfb7892e75a1da32e60b9ca812066b7e18d81bb

commit ecfb7892e75a1da32e60b9ca812066b7e18d81bb
Author: skau <skau@chromium.org>
Date: Thu Jul 13 23:26:49 2017

Remove the cups_print_job_manager_impl header

The header can be merged with the implementation. Removing the extra
file will result in a little less maintenance.

This is a pure refactor.  No code was changed.

BUG= 734280 

Review-Url: https://codereview.chromium.org/2963173003
Cr-Commit-Position: refs/heads/master@{#486526}

[modify] https://crrev.com/ecfb7892e75a1da32e60b9ca812066b7e18d81bb/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/ecfb7892e75a1da32e60b9ca812066b7e18d81bb/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[delete] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/chrome/browser/chromeos/printing/cups_print_job_manager_impl.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9195b2b71b5f80b084dac791607149b7c9550362

commit 9195b2b71b5f80b084dac791607149b7c9550362
Author: Sean Kau <skau@chromium.org>
Date: Tue Jul 18 21:47:14 2017

Switch CupsPrintJobManagerImpl to use a Timer.

Timer is the preferred method to schedule recurring tasks rather than
rescheduling a PostDelayedTask.

Bug:  734280 
Change-Id: I2200a9fe636eb7e59bf868dc8227aecc82095bcc
Reviewed-on: https://chromium-review.googlesource.com/575776
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487615}
[modify] https://crrev.com/9195b2b71b5f80b084dac791607149b7c9550362/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc

Comment 6 by skau@chromium.org, Jul 18 2017

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment