New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734275 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] toggle rows should be clickable

Project Member Reported by dschuyler@chromium.org, Jun 17 2017 
on chrome://settings in Appearance, Privacy and other pages there are rows with toggle buttons. The toggles will switch when clicking on the toggle itself or the row label, but they should switch on any click in the row (.settings-box). e.g. clicking slightly below or above the label or slightly left or right of the toggle doesn't move the control.

Comment 1 by dschuyler@chromium.org, Aug 4 2017

Labels: -Pri-3 Pri-2
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/661285b9d4dcf79b97c97581dfbe32c3954e7ec4

commit 661285b9d4dcf79b97c97581dfbe32c3954e7ec4
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Aug 09 21:24:36 2017

[MD settings] add action-target option to toggle button

This CL adds an optional action-target property for toggle buttons so
that another (e.g. parent) element can be the tap target for the toggle.
This is useful in the settings-box row elements, so that the whole row
is clickable (which is the intended UX design). A couple toggle buttons
were also changed to use action-target as examples and proof of concept,
but this CL is not intended to change all toggle buttons to use
action-target. The unchanged toggle-buttons serve as proof that action-
target is optional.

Also, now firing change when the action-target (e.g. the toggle label text) is tapped. The toggle label didn't previously fire a change on tap.

Bug:  734275 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iacf424754a7d47ea299c780a935bd22aa76f75dc
Reviewed-on: https://chromium-review.googlesource.com/602668
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493142}
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/test/data/webui/settings/category_default_setting_tests.js
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/test/data/webui/settings/google_assistant_page_test.js
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/661285b9d4dcf79b97c97581dfbe32c3954e7ec4/chrome/test/data/webui/settings/settings_toggle_button_tests.js
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10db7308a27aaedef35b99ca8c0dff339a8a27e7

commit 10db7308a27aaedef35b99ca8c0dff339a8a27e7
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Aug 17 22:43:41 2017

[MD settings] remove action-target on settings-toggle-buttons

This CL removes the action-target method of setting tap targets for toggle-buttons. 
To make the settings-toggle-buttons whole row tap/clickable, the extraneous outer 
<div> is removed.

This also includes a fix for the Launch button that appears within the toggle-button to user hardware acceleration.

Bug:  734275 ,  754584 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia8eee97f9f0d84f1c2d8352ad46494492c2b9001
Reviewed-on: https://chromium-review.googlesource.com/608817
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495359}
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/site_settings/pdf_documents.html
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/browser/resources/settings/system_page/system_page.js
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/category_default_setting_tests.js
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/google_assistant_page_test.js
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/10db7308a27aaedef35b99ca8c0dff339a8a27e7/chrome/test/data/webui/settings/settings_toggle_button_tests.js
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a

commit 8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Aug 19 02:50:52 2017

[MD settings] settings-toggle-button default to settings-box styling

This CL changes the default settings-toggle-button style to be as a
.settings-box so that class="settings-box" need not be used on every
instance. Also changes remaining toggles rows to be fully clickable;
along with a formatting error on mac/chromeos with the font size 
drop-down.

Bug:  734275 ,  756736 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e61fc4d7b6e2229aea1f1d05da0da0a7a5f05f2
Reviewed-on: https://chromium-review.googlesource.com/619757
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495792}
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/power.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/site_settings/category_default_setting.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/site_settings/pdf_documents.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/test/data/webui/settings/device_page_tests.js

Comment 6 by dschuyler@chromium.org, Aug 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment