New issue
Advanced search Search tips

Issue 734262 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713889



Sign in to add a comment

color: Enable color correct rendering for browser_tests and content_browsertests

Project Member Reported by ccameron@chromium.org, Jun 16 2017 
These tests need to be updated to have a predictable color space and color behavior.

This may be as simple as adding color correct rendering flags to BrowserTestBase::SetUp().

Comment 1 by ccameron@chromium.org, Jun 19 2017 

The following browser tests failed on Mac:

PluginPowerSaverBrowserTest.SmallerThanPlayIcon
TabCaptureApiPixelTest.OffscreenTabEndToEnd
CastStreamingApiTestWithPixelOutput.EndToEnd
TabCaptureApiPixelTest.EndToEndWithoutRemoting

The following content_browsertests failed on Mac:

GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_ForVideoFrame_Scaled/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_ForVideoFrame_Scaled/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Origin_Unscaled/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Origin_Unscaled/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_ForVideoFrame/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Origin_Scaled/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Origin_Scaled/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToBitmap_CenterRegion/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToBitmap_CenterRegion/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToVideoFrame_ScaledResult/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToVideoFrame_ScaledResult/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToBitmap_ScaledResult/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToBitmap_ScaledResult/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Cropped_Scaled/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Cropped_Scaled/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToVideoFrame_CenterRegion/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToVideoFrame_CenterRegion/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Cropped_Unscaled/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_Cropped_Unscaled/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToVideoFrame_EntireRegion/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToVideoFrame_EntireRegion/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToBitmap_EntireRegion/1
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCaptureHighDPI.CopyToBitmap_EntireRegion/0
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestTabCapture.CopyFromSurface_ForVideoFrame/1

I have a hunch that these can be fixed by just adding the --force-color-profile=srgb flag for these tests.

Comment 2 by ccameron@chromium.org, Jun 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment