New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734258 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 528104



Sign in to add a comment

Remove gfx::DIAGONAL_STRIKE

Project Member Reported by lgar...@chromium.org, Jun 16 2017

Issue description

After  Issue 528104 , the diagonal strike implementation is not used anymore.
 
Cc: -lgar...@chromium.org
Components: UI>GFX
Owner: lgar...@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/2943823002
Status: Fixed (was: Started)
Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms. Based on a user study, we are switching them to horizontal strikethroughs: https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG= 734258 

Review-Url: https://codereview.chromium.org/2943823002
Cr-Commit-Position: refs/heads/master@{#480668}
Committed: https://chromium.googlesource.com/chromium/src/+/cbac25a432e85afc77b6696c21d6216cbc225b39

Sign in to add a comment