New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Legacy CPU profiler flamechart is empty.

Project Member Reported by alph@chromium.org, Jun 16 2017

Issue description

Record a CPU profile using legacy JavaScript profiler and switch to the flamechart mode. The chart is empty.

Caused by this change:
https://chromium.googlesource.com/chromium/src/+/df53c315ea874b85d78d91b95443a9461c59d225
 

Comment 1 by alph@chromium.org, Jun 16 2017

Labels: M-60

Comment 2 by alph@chromium.org, Jun 20 2017

commit c81a6b895381f8d921cbee83bc814710856cdec2
Author: Alexei Filippov <alph@chromium.org>
Date:   Fri Jun 16 19:35:30 2017 -0700

    DevTools: Fix CPU profile flamechart empty.
    
    Bug:  734239 
    Change-Id: I509acca90a007c7705750d97c969ec028e0632e9
    Reviewed-on: https://chromium-review.googlesource.com/539132
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Commit-Queue: Alexei Filippov <alph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#480588}

Comment 3 by alph@chromium.org, Jun 20 2017

Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 20 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approved for merge into M60
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cbaae4360fc0ebbf45c65870a1e6a336034064f

commit 6cbaae4360fc0ebbf45c65870a1e6a336034064f
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Jun 21 01:10:57 2017

DevTools: Fix CPU profile flamechart empty.

TBR=alph@chromium.org

(cherry picked from commit c81a6b895381f8d921cbee83bc814710856cdec2)

Bug:  734239 
Change-Id: I509acca90a007c7705750d97c969ec028e0632e9
Reviewed-on: https://chromium-review.googlesource.com/539132
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480588}
Reviewed-on: https://chromium-review.googlesource.com/541863
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#416}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/6cbaae4360fc0ebbf45c65870a1e6a336034064f/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3962a4d775dd5d0a0e82af29ee0da507b8693377

commit 3962a4d775dd5d0a0e82af29ee0da507b8693377
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Jul 20 17:44:47 2017

DevTools: Fix CPU profile flamechart is empty.

Bug:  734239 
Change-Id: Ia815aa693ab6719a0a26d65231db1a04c26a2c4d
Reviewed-on: https://chromium-review.googlesource.com/578513
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488294}
[modify] https://crrev.com/3962a4d775dd5d0a0e82af29ee0da507b8693377/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Comment 8 by alph@chromium.org, Jul 20 2017

Status: Fixed (was: Assigned)
Cc: kavvaru@chromium.org
Labels: Needs-Feedback
alph@ Could you please provide us repro steps and expected behaviour if this requires manual verification.

Thanks,

Comment 10 by alph@chromium.org, Jul 26 2017

1. Open JavaScript CPU profiler panel
2. Record CPU profile of a page
3. Switch to Chart view
4. The flamechart was empty before the fix.
Labels: TE-Verified-61.0.3163.13
Verified the fix with Chrome version 61.0.3163.13 on Windows 7,10, Mac and Linux and able to see the Flamechart.

Sign in to add a comment