Issue metadata
Sign in to add a comment
|
Legacy CPU profiler flamechart is empty. |
||||||||||||||||||||||
Issue descriptionRecord a CPU profile using legacy JavaScript profiler and switch to the flamechart mode. The chart is empty. Caused by this change: https://chromium.googlesource.com/chromium/src/+/df53c315ea874b85d78d91b95443a9461c59d225
,
Jun 20 2017
commit c81a6b895381f8d921cbee83bc814710856cdec2 Author: Alexei Filippov <alph@chromium.org> Date: Fri Jun 16 19:35:30 2017 -0700 DevTools: Fix CPU profile flamechart empty. Bug: 734239 Change-Id: I509acca90a007c7705750d97c969ec028e0632e9 Reviewed-on: https://chromium-review.googlesource.com/539132 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#480588}
,
Jun 20 2017
,
Jun 20 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2017
Approved for merge into M60
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cbaae4360fc0ebbf45c65870a1e6a336034064f commit 6cbaae4360fc0ebbf45c65870a1e6a336034064f Author: Alexei Filippov <alph@chromium.org> Date: Wed Jun 21 01:10:57 2017 DevTools: Fix CPU profile flamechart empty. TBR=alph@chromium.org (cherry picked from commit c81a6b895381f8d921cbee83bc814710856cdec2) Bug: 734239 Change-Id: I509acca90a007c7705750d97c969ec028e0632e9 Reviewed-on: https://chromium-review.googlesource.com/539132 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#480588} Reviewed-on: https://chromium-review.googlesource.com/541863 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#416} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/6cbaae4360fc0ebbf45c65870a1e6a336034064f/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3962a4d775dd5d0a0e82af29ee0da507b8693377 commit 3962a4d775dd5d0a0e82af29ee0da507b8693377 Author: Alexei Filippov <alph@chromium.org> Date: Thu Jul 20 17:44:47 2017 DevTools: Fix CPU profile flamechart is empty. Bug: 734239 Change-Id: Ia815aa693ab6719a0a26d65231db1a04c26a2c4d Reviewed-on: https://chromium-review.googlesource.com/578513 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488294} [modify] https://crrev.com/3962a4d775dd5d0a0e82af29ee0da507b8693377/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
,
Jul 20 2017
,
Jul 26 2017
alph@ Could you please provide us repro steps and expected behaviour if this requires manual verification. Thanks,
,
Jul 26 2017
1. Open JavaScript CPU profiler panel 2. Record CPU profile of a page 3. Switch to Chart view 4. The flamechart was empty before the fix.
,
Jul 26 2017
Verified the fix with Chrome version 61.0.3163.13 on Windows 7,10, Mac and Linux and able to see the Flamechart. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alph@chromium.org
, Jun 16 2017