New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734237 link

Starred by 1 user
Status: Assigned
Owner:
█ bdea@chromium.org
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Adding the Incognito feature to the FeatureEngagementTracker features list

Project Member Reported by bdea@google.com, Jun 16 2017 
For the Deferred Onboarding process, an Incognito feature needs to be added to the features list in FeatureEngagementTracker.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57

commit 5a4595eeb0fc6e337fbfe3204b4a9c990f295b57
Author: Bettina Dea <bdea@chromium.org>
Date: Thu Jun 29 04:18:50 2017

Add IncognitoWindow feature into IPH and UMA for OS_WIN and OS_LINUX and add NewTab into OS_LINUX.

To implement the FeatureEngagementTracker for an Incognito Window feature,
code was added to include a kIPHIncognitoWindowFeature.

Added Mark Pearson for actions.xml/histograms.xml

Bug: 734237
Change-Id: I99e75e1b3a908dd8cdaa9a15dbced4e412c6894e
Reviewed-on: https://chromium-review.googlesource.com/541123
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483294}
[modify] https://crrev.com/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57/components/feature_engagement_tracker/public/feature_constants.cc
[modify] https://crrev.com/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57/components/feature_engagement_tracker/public/feature_constants.h
[modify] https://crrev.com/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57/components/feature_engagement_tracker/public/feature_list.cc
[modify] https://crrev.com/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57/components/feature_engagement_tracker/public/feature_list.h
[modify] https://crrev.com/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57/tools/metrics/actions/actions.xml
[modify] https://crrev.com/5a4595eeb0fc6e337fbfe3204b4a9c990f295b57/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Google

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)

Comment 4 by benhenry@chromium.org, Aug 2

Owner: bdea@chromium.org
►

Sign in to add a comment