New issue
Advanced search Search tips

Issue 734221 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

ContextMenuParams enum out of sync with WebKit

Project Member Reported by dtrainor@chromium.org, Jun 16 2017

Issue description

Looks like CANVAS got added but not pushed to java.
 
Labels: -M-61 M-62
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a173b077b929561bce1072fcd0c97c244cafde6

commit 3a173b077b929561bce1072fcd0c97c244cafde6
Author: David Trainor <dtrainor@chromium.org>
Date: Thu Aug 17 23:18:54 2017

Update WebContextMenuData to build a Java enum

WebContextMenuData's values were copied to ContextMenuParams.java so
they could be used in the Java UI layer.  This led to bugs where the new
enum value CANVAS was added but wasn't added to the Java layer.

This CL removes the duplicated enum and automatically generates the Java
enum from the C++ one, so the values are never mixed up.

BUG= 734221 

Change-Id: I7bf35e91647ade52c1bc8041b88a5c4490ca5b21
Reviewed-on: https://chromium-review.googlesource.com/590102
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495374}
[modify] https://crrev.com/3a173b077b929561bce1072fcd0c97c244cafde6/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[modify] https://crrev.com/3a173b077b929561bce1072fcd0c97c244cafde6/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java
[modify] https://crrev.com/3a173b077b929561bce1072fcd0c97c244cafde6/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/3a173b077b929561bce1072fcd0c97c244cafde6/third_party/WebKit/public/web/WebContextMenuData.h

Status: Fixed (was: Started)

Sign in to add a comment