New issue
Advanced search Search tips

Issue 734212 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 734142



Sign in to add a comment

Allow localization of app name

Project Member Reported by yfried...@chromium.org, Jun 16 2017

Issue description

Now that we have localized strings in the webapk, we should move the app name to resources. This will enable us to override the app name with localized versions
 
Owner: hanxi@chromium.org
Status: Assigned (was: Untriaged)
In stand-up Peter pointed out that we'll need to localize both "short_name" and "name". I suspect both of these will need some extra re-jiggering to ensure that WebApkInfo/webappregistry gets the localized app name instead of just reading the fields out of the WebApk metadata
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82c6369965606f7ce2098aac7c442ca7e1f1f28e

commit 82c6369965606f7ce2098aac7c442ca7e1f1f28e
Author: hanxi <hanxi@chromium.org>
Date: Mon Jun 26 14:55:24 2017

Allow localization of WebApk name.

We want to support WebAPK with localized names. In this CL:
1. Removes "name" and "short_name" metadata from shell APK's
AndroidManifest.xml.
   Instead, these two fields in WebApkInfo and the application label will
   obtained from resources (string).
2. Adds non translateable strings.
3. Ensures WebApkInfo is compatible with existing WebAPKs that don't have these
   two strings.

BUG= 734212 

Review-Url: https://codereview.chromium.org/2948653002
Cr-Commit-Position: refs/heads/master@{#482274}

[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/shell_apk/AndroidManifest.xml
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/shell_apk/BUILD.gn
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/WebApkUtilsTest.java
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/strings/android_webapk_strings.grd
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/test/BUILD.gn
[modify] https://crrev.com/82c6369965606f7ce2098aac7c442ca7e1f1f28e/chrome/android/webapk/test/src/org/chromium/webapk/test/WebApkTestHelper.java

Status: Fixed (was: Assigned)

Sign in to add a comment