This code: https://cs.chromium.org/chromium/src/ui/display/manager/display_manager_utilities.cc?q=display_manager_utilities.cc+package:%5Echromium$&dr&l=69 Is getting hit in passing HWTest runs, e.g. this run: https://uberchromegw.corp.google.com/i/chromeos/builders/nyan_kitty-release/builds/1198 Logs: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/123587974-chromeos-test/chromeos4-row13-rack1-host3/login_LoginSuccess/sysinfo/var/log_diff/chrome/ It is a supper confusing red herring when debugging failures. Unfortunately NOTREACHED() does not appear to actually show the extra info in the log, so it's unclear what the resolution is. I don't know whether or not the error is specific to this board.
This means that chrome detected unknown internal display. What kind of hardware it is running?
If you look at the link you can see it's nyan_kitty :) (I don't know anything more about that board config).
Thanks, I think this is the one, that I didn't know about. https://www.bhphotovideo.com/bnh/controller/home?A=details&O=&Q=&ap=y&c3api=1876%2C%7Bcreative%7D%2C%7Bkeyword%7D&is=REG&sku=1181960 I'll update the code to include this configuration.
oshima@ assigning to you then? Because while the fix seems easy, I have no idea what the right width should be.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f120a7f827522fa4b6e724b87a399615b86e8ae commit 2f120a7f827522fa4b6e724b87a399615b86e8ae Author: oshima <oshima@chromium.org> Date: Wed Jun 21 00:27:00 2017 Add 1.6x mode. * Remove unsupported 1.5x. * Removed obsolete use_125_dsf_for_ui_scaling flag. (it should be always true) * Added large FHD screen scenario. BUG= 734204 BUG=b/62475614 TEST=Updated unit tests. Manual test on cave with manually teaking the scale. Review-Url: https://codereview.chromium.org/2945913003 Cr-Commit-Position: refs/heads/master@{#481042} [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ash/display/display_manager_unittest.cc [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/manager/chromeos/display_change_observer.cc [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/manager/chromeos/display_change_observer_unittest.cc [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/manager/display_manager_utilities.cc [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/manager/managed_display_info.cc [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/manager/managed_display_info.h [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/test/display_manager_test_api.cc [modify] https://crrev.com/2f120a7f827522fa4b6e724b87a399615b86e8ae/ui/display/test/display_manager_test_api.h
Comment 1 by osh...@chromium.org
, Jun 16 2017