Repro steps:
1. Build ToT chrome (e.g. at )
2. Launch Chrome (no special command-line flags needed)
3. Navigate to http://anforowicz.github.io/janky-frame/
4. Right click in the main frame and try to "inspect" the page in DevTools.
Expected: nothing exciting
Actual: crash:
[FATAL:DocumentMarkerController.cpp(428)] Check failed: !document_->NeedsLayoutTreeUpdate().
...
#2 logging::LogMessage::~LogMessage() base/logging.cc:552:29
#3 blink::DocumentMarkerController::LayoutRectsForTextMatchMarkers() third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:428:3
#4 blink::LocalFrameView::GetTickmarks(...) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:2676:43
#5 blink::ScrollbarTheme::PaintTickmarks(...) third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp:244:13
#6 blink::WebScrollbarThemePainter::PaintTickmarks(...) third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp:141:11
#7 cc_blink::ScrollbarImpl::PaintPart(...) cc/blink/scrollbar_impl.cc:126:12
#8 cc::PaintedScrollbarLayer::RasterizeScrollbarPart(...) cc/layers/painted_scrollbar_layer.cc:274:15
#9 cc::PaintedScrollbarLayer::Update() cc/layers/painted_scrollbar_layer.cc:224:9
er_tree_host.cc:1102:33
#11 cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:739:7
#12 cc::LayerTreeHost::UpdateLayers() cc/trees/layer_tree_host.cc:619:17
#13 cc::ProxyMain::BeginMainFrame(...) cc/trees/proxy_main.cc:225:60
Repro steps:
1. Build ToT chrome (e.g. at ce85174f53239960c7007e4b6c8bc6bde272f1a5 / r480098)
2. Launch Chrome (no special command-line flags needed)
3. Navigate to http://anforowicz.github.io/janky-frame/
4. Right click in the main frame and try to "inspect" the page in DevTools.
Expected: nothing exciting
Actual: crash:
[FATAL:DocumentMarkerController.cpp(428)] Check failed: !document_->NeedsLayoutTreeUpdate().
...
#2 logging::LogMessage::~LogMessage() base/logging.cc:552:29
#3 blink::DocumentMarkerController::LayoutRectsForTextMatchMarkers() third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:428:3
#4 blink::LocalFrameView::GetTickmarks(...) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:2676:43
#5 blink::ScrollbarTheme::PaintTickmarks(...) third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp:244:13
#6 blink::WebScrollbarThemePainter::PaintTickmarks(...) third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp:141:11
#7 cc_blink::ScrollbarImpl::PaintPart(...) cc/blink/scrollbar_impl.cc:126:12
#8 cc::PaintedScrollbarLayer::RasterizeScrollbarPart(...) cc/layers/painted_scrollbar_layer.cc:274:15
#9 cc::PaintedScrollbarLayer::Update() cc/layers/painted_scrollbar_layer.cc:224:9
er_tree_host.cc:1102:33
#11 cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:739:7
#12 cc::LayerTreeHost::UpdateLayers() cc/trees/layer_tree_host.cc:619:17
#13 cc::ProxyMain::BeginMainFrame(...) cc/trees/proxy_main.cc:225:60
Repro steps:
1. Build ToT chrome (e.g. at ce85174f53239960c7007e4b6c8bc6bde272f1a5 / r480098) with DCHECKs enabled.
2. Launch Chrome (no special command-line flags needed)
3. Navigate to http://anforowicz.github.io/janky-frame/
4. Right click in the main frame and try to "inspect" the page in DevTools.
Expected: nothing exciting
Actual: crash:
[FATAL:DocumentMarkerController.cpp(428)] Check failed: !document_->NeedsLayoutTreeUpdate().
...
#2 logging::LogMessage::~LogMessage() base/logging.cc:552:29
#3 blink::DocumentMarkerController::LayoutRectsForTextMatchMarkers() third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:428:3
#4 blink::LocalFrameView::GetTickmarks(...) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:2676:43
#5 blink::ScrollbarTheme::PaintTickmarks(...) third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp:244:13
#6 blink::WebScrollbarThemePainter::PaintTickmarks(...) third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp:141:11
#7 cc_blink::ScrollbarImpl::PaintPart(...) cc/blink/scrollbar_impl.cc:126:12
#8 cc::PaintedScrollbarLayer::RasterizeScrollbarPart(...) cc/layers/painted_scrollbar_layer.cc:274:15
#9 cc::PaintedScrollbarLayer::Update() cc/layers/painted_scrollbar_layer.cc:224:9
er_tree_host.cc:1102:33
#11 cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:739:7
#12 cc::LayerTreeHost::UpdateLayers() cc/trees/layer_tree_host.cc:619:17
#13 cc::ProxyMain::BeginMainFrame(...) cc/trees/proxy_main.cc:225:60
Repro steps:
1. Build ToT chrome (e.g. at ce85174f53239960c7007e4b6c8bc6bde272f1a5 / r480098) with DCHECKs enabled.
2. Launch Chrome (no special command-line flags needed)
3. Navigate to http://anforowicz.github.io/janky-frame/
4. Right click in the main frame and try to "inspect" the page in DevTools.
Expected: nothing exciting
Actual: renderer hits a DCHECK:
[FATAL:DocumentMarkerController.cpp(428)] Check failed: !document_->NeedsLayoutTreeUpdate().
...
#2 logging::LogMessage::~LogMessage() base/logging.cc:552:29
#3 blink::DocumentMarkerController::LayoutRectsForTextMatchMarkers() third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:428:3
#4 blink::LocalFrameView::GetTickmarks(...) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:2676:43
#5 blink::ScrollbarTheme::PaintTickmarks(...) third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp:244:13
#6 blink::WebScrollbarThemePainter::PaintTickmarks(...) third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp:141:11
#7 cc_blink::ScrollbarImpl::PaintPart(...) cc/blink/scrollbar_impl.cc:126:12
#8 cc::PaintedScrollbarLayer::RasterizeScrollbarPart(...) cc/layers/painted_scrollbar_layer.cc:274:15
#9 cc::PaintedScrollbarLayer::Update() cc/layers/painted_scrollbar_layer.cc:224:9
er_tree_host.cc:1102:33
#11 cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:739:7
#12 cc::LayerTreeHost::UpdateLayers() cc/trees/layer_tree_host.cc:619:17
#13 cc::ProxyMain::BeginMainFrame(...) cc/trees/proxy_main.cc:225:60
Comment 1 by lukasza@chromium.org
, Jun 16 2017Summary: Check failed: !document->needsLayoutTreeUpdate() in DocumentMarkerController::LayoutRectsForTextMatchMarkers (was: Check failed: !document->needsLayoutTreeUpdate() (DevTools-related?))