DevToolsEmulator shouldn't assume that the main frame is local |
||
Issue descriptionThis came up in https://codereview.chromium.org/2936423003/diff/1/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp#newcode439. I see that DevToolsEmulator::HandleInputEvent and DevToolsEmulator::ApplyViewportOverride call into GetScrollOffset/SetScrollOffset which in case of WebRemoteFrameImpl will most likely do a wrong thing. No repro steps yet. :-(
,
Oct 4 2017
We are not using DevToolsEmulator for non-local main frame.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/391420fffc5d5aa2683e5bada83210fffa60ca65 commit 391420fffc5d5aa2683e5bada83210fffa60ca65 Author: Kevin McNee <mcnee@chromium.org> Date: Fri May 25 21:02:22 2018 Remove obsolete DevTools pinch emulation workaround DevToolsEmulator::HandleInputEvent handles the case of a gesture pinch being handled on the main thread. Since touchscreen gesture pinch events are all handled on the compositor thread, this workaround is no longer needed. Bug: 787924 , 734201 Change-Id: I3499c1129b0ee529a8d218a652c69e258fa93fc0 Reviewed-on: https://chromium-review.googlesource.com/1073401 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#562006} [modify] https://crrev.com/391420fffc5d5aa2683e5bada83210fffa60ca65/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/391420fffc5d5aa2683e5bada83210fffa60ca65/third_party/blink/renderer/core/inspector/dev_tools_emulator.cc [modify] https://crrev.com/391420fffc5d5aa2683e5bada83210fffa60ca65/third_party/blink/renderer/core/inspector/dev_tools_emulator.h |
||
►
Sign in to add a comment |
||
Comment 1 by chenwilliam@chromium.org
, Jun 17 2017Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)