New issue
Advanced search Search tips

Issue 734199 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Make most URLRequestContext creators use URLRequestContextBuilder

Project Member Reported by mmenke@chromium.org, Jun 16 2017

Issue description

This makes maintaining both net/ and net/ consumers easier by reducing their dependencies on each other.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c15ff49e64bda7efc4d6259296f1bcdca64039b

commit 0c15ff49e64bda7efc4d6259296f1bcdca64039b
Author: mmenke <mmenke@chromium.org>
Date: Wed Jul 12 01:25:49 2017

Make ProfileURLRequestContexts use their own CTPolicyEnforcer.

This is mostly about making URLRequestContextBuilder creation simpler,
so the NetworkService doesn't have to worry about sharing
CTPolicyEnforcers between URLRequestContexts.

BUG= 734199 

Review-Url: https://codereview.chromium.org/2975903002
Cr-Commit-Position: refs/heads/master@{#485765}

[modify] https://crrev.com/0c15ff49e64bda7efc4d6259296f1bcdca64039b/chrome/browser/io_thread.cc
[modify] https://crrev.com/0c15ff49e64bda7efc4d6259296f1bcdca64039b/chrome/browser/profiles/profile_io_data.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e90690d092c46535ebabcedaab4c8514c3c0094

commit 3e90690d092c46535ebabcedaab4c8514c3c0094
Author: mmenke <mmenke@chromium.org>
Date: Wed Jul 12 09:47:07 2017

Make iOS's IOThread set up the SystemURLRequestContext all at once.

It was jumping back to the UI thread and back because the
PrefProxyConfigTracker required it. Now that that's no longer the
case, get rid of the extra thread hops. The same thing has already
been done to chrome/'s IOThead.

BUG= 734199 

Review-Url: https://codereview.chromium.org/2943783002
Cr-Commit-Position: refs/heads/master@{#485906}

[modify] https://crrev.com/3e90690d092c46535ebabcedaab4c8514c3c0094/ios/components/io_thread/ios_io_thread.h
[modify] https://crrev.com/3e90690d092c46535ebabcedaab4c8514c3c0094/ios/components/io_thread/ios_io_thread.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af

commit 5f72b7fbfd9626c67decee2bfff2f6c26d6d85af
Author: mmenke <mmenke@chromium.org>
Date: Wed Jul 12 10:54:10 2017

Use TaskRunner passed in to URLRequestContextBuilder only for the cache

It used to be used for file URLs and TransportSecurityStatePersister as
well, but this CL moves those over to using the task scheduler. Can't
just always use that for the cache as well due to the cache needing a
SingleThreadTaskRunner, and getting one of those from the task scheduler
is a bit more resource intensive.

BUG= 734199 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2977693003
Cr-Commit-Position: refs/heads/master@{#485919}

[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/headless/lib/browser/headless_url_request_context_getter.h
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/net/url_request/url_request_context_builder.h
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/remoting/base/url_request_context_getter.cc
[modify] https://crrev.com/5f72b7fbfd9626c67decee2bfff2f6c26d6d85af/remoting/base/url_request_context_getter.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f

commit 189ddf60b2f4034a2ab6efb16e22ea389b2b779f
Author: mmenke <mmenke@chromium.org>
Date: Tue Jul 18 20:34:30 2017

Make ProfileIOData use URLRequestContextBuilder

BUG= 734199 

Review-Url: https://codereview.chromium.org/2978443002
Cr-Commit-Position: refs/heads/master@{#487590}

[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/io_thread.cc
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/io_thread.h
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/net/proxy_service_factory.h
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/189ddf60b2f4034a2ab6efb16e22ea389b2b779f/net/url_request/url_request_context_builder.h

Comment 5 by mmenke@chromium.org, Jul 20 2017

Components: -Internals>Network Internals>Network>Service
Owner: ----
Status: Available (was: Assigned)
Going to unassign this from me - we still need to think about the App request contexts, and then there are the other one-off request contexts, and I may be the one who ends up working on them, but not my current focus.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de

commit 8636cbd6b9449dd374d6879b6fad0e8ed7bf61de
Author: mmenke <mmenke@chromium.org>
Date: Fri Jul 21 02:50:21 2017

Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12 id:330001 of https://codereview.chromium.org/2978443002/ )

Reason for revert:
Wasn't thinking when I landed this just before branch.

Original issue's description:
> Make ProfileIOData use URLRequestContextBuilder
>
> BUG= 734199 
>
> Review-Url: https://codereview.chromium.org/2978443002
> Cr-Commit-Position: refs/heads/master@{#487590}
> Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f

TBR=rdsmith@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 734199 

Review-Url: https://codereview.chromium.org/2986623002
Cr-Commit-Position: refs/heads/master@{#488562}

[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/io_thread.cc
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/io_thread.h
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/net/proxy_service_factory.h
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de/net/url_request/url_request_context_builder.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c261ff43979396e53729da97763a8d261c7616c

commit 1c261ff43979396e53729da97763a8d261c7616c
Author: mmenke <mmenke@chromium.org>
Date: Sun Jul 23 17:06:35 2017

Reland of Make ProfileIOData use URLRequestContextBuilder (patchset #1 id:1 of https://codereview.chromium.org/2986623002/ )

Reason for revert:
We're now after branch, re-landing this (Since I'll need it for a number of CLs).  I'll fix devtools in a followup CL, and merge the revert if needed.

Original issue's description:
> Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12 id:330001 of https://codereview.chromium.org/2978443002/ )
>
> Reason for revert:
> Wasn't thinking when I landed this just before branch.
>
> Original issue's description:
> > Make ProfileIOData use URLRequestContextBuilder
> >
> > BUG= 734199 
> >
> > Review-Url: https://codereview.chromium.org/2978443002
> > Cr-Commit-Position: refs/heads/master@{#487590}
> > Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f
>
> TBR=rdsmith@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 734199 
>
> Review-Url: https://codereview.chromium.org/2986623002
> Cr-Commit-Position: refs/heads/master@{#488562}
> Committed: https://chromium.googlesource.com/chromium/src/+/8636cbd6b9449dd374d6879b6fad0e8ed7bf61de

TBR=rdsmith@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 734199 

Review-Url: https://codereview.chromium.org/2986733002
Cr-Commit-Position: refs/heads/master@{#488887}

[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/io_thread.cc
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/io_thread.h
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/net/proxy_service_factory.h
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/1c261ff43979396e53729da97763a8d261c7616c/net/url_request/url_request_context_builder.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b090f508c6735d85b0418075f6f0d5042b848bc0

commit b090f508c6735d85b0418075f6f0d5042b848bc0
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Jul 26 02:12:44 2017

Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12 id:330001 of https://codereview.chromium.org/2978443002/ )

Reason for revert:
Wasn't thinking when I landed this just before branch.

Original issue's description:
> Make ProfileIOData use URLRequestContextBuilder
>
> BUG= 734199 
>
> Review-Url: https://codereview.chromium.org/2978443002
> Cr-Commit-Position: refs/heads/master@{#487590}
> Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f

TBR=mmenke@chromium.org, rdsmith@chromium.org
BUG= 734199 , 746576 #c3

(cherry picked from commit 8636cbd6b9449dd374d6879b6fad0e8ed7bf61de)

Review-Url: https://codereview.chromium.org/2986623002
Cr-Original-Commit-Position: refs/heads/master@{#488562}
Change-Id: Iff1b60065f76c6fad9aea8e82c5fa7a3ff584ebc
Reviewed-on: https://chromium-review.googlesource.com/585894
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#47}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/io_thread.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/io_thread.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/net/proxy_service_factory.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/net/url_request/url_request_context_builder.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f

commit ae6a4eaded5d143dc65beb5703efd6e7d4536a8f
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Jul 26 22:15:21 2017

Fix DevTools throttling.

This was broken in  https://codereview.chromium.org/2978443002, which
completely refactored network stack configuration, and no tests caught
the breakage.

Bug:  746576 , 734199 
Change-Id: Ib0fdd0fff3a988c91302b4ba6778a41b55b20d9a
Reviewed-on: https://chromium-review.googlesource.com/582935
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489774}
[modify] https://crrev.com/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f/net/url_request/url_request_context_builder.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fda6e374f41bd3740e15d4cf1c96094b5a5b32d

commit 4fda6e374f41bd3740e15d4cf1c96094b5a5b32d
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Jul 27 17:24:27 2017

Switch content_shell over to URLRequestContextBuilder.

This both simplifies construction, and makes the code closer to
URLRequestContext creation logic in the network service.

Bug:  734199 
Change-Id: I65d3f87c18206bff55fb024d1c6ac2fc5fc30a5d
Reviewed-on: https://chromium-review.googlesource.com/582084
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490007}
[modify] https://crrev.com/4fda6e374f41bd3740e15d4cf1c96094b5a5b32d/content/shell/BUILD.gn
[modify] https://crrev.com/4fda6e374f41bd3740e15d4cf1c96094b5a5b32d/content/shell/DEPS
[modify] https://crrev.com/4fda6e374f41bd3740e15d4cf1c96094b5a5b32d/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/4fda6e374f41bd3740e15d4cf1c96094b5a5b32d/content/shell/browser/shell_url_request_context_getter.h

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 12 by dxie@chromium.org, May 22 2018

this does not block canary.

Comment 13 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue
Status: Fixed (was: Available)
Going to close this, and file a new bug for app request constexts, which do block canary.

Sign in to add a comment