New issue
Advanced search Search tips

Issue 734193 link

Starred by 1 user
Status: Duplicate
Merged: issue 716381
Owner: ----
Closed: Jun 2017
Cc:
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chrome://media-internals leaks memory

Project Member Reported by brucedaw...@chromium.org, Jun 16 2017 
While using chrome://media-internals to monitor audio usage ( crbug.com/732450 ) I noticed that the media-internals tab had grown to 900 MB of RAM. I then opened it on my work computer and it grew over a few hours to 414 MB, still growing.

Now, a leak in an internal page that is used by few people is not a critical problem. But, it is possible that it represents an indication of other problems.

Comment 1 by dalecur...@chromium.org, Jun 16 2017 

Can you grab a heap snapshot from dev tools? The page accumulates media data in JS, not C++, so growth is expected when the tab is open.

Comment 2 by brucedaw...@chromium.org, Jun 16 2017 

Task manager currently shows 605,240 K of memory, with JavaScript memory at just 68,936 K. The heap snapshot is over 16 MB compressed so I can't attach it to the bug but I will share it.

Comment 3 by dalecur...@chromium.org, Jun 16 2017

Mergedinto: 716381
Status: Duplicate (was: Untriaged)
Thanks for the heap snapshot, this is definitely  issue 716381 . It has tons of useless CacheEntry and canvas objects. The CL I just put together should fix this https://chromium-review.googlesource.com/c/538899
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b

commit 1ff5a375ab0b3c53a6893a1e257c2d81a16a485b
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Jun 16 23:55:52 2017

Remove dead code around media-internals buffering extents.

BUG= 716381 , 734193 
TEST=chrome://media-internals still works

Change-Id: I1f8f1bf4bb209b84ec718ced4a34ca3190457e71
Reviewed-on: https://chromium-review.googlesource.com/538899
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480229}
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/media/media_internals.cc
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/media/media_internals_proxy.cc
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/media/media_internals_proxy.h
[delete] https://crrev.com/df131c01ccdbc3f32eb7fe6066a2d75ef8e5a07e/content/browser/resources/media/cache_entry.js
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/resources/media/client_renderer.js
[delete] https://crrev.com/df131c01ccdbc3f32eb7fe6066a2d75ef8e5a07e/content/browser/resources/media/disjoint_range_set.js
[delete] https://crrev.com/df131c01ccdbc3f32eb7fe6066a2d75ef8e5a07e/content/browser/resources/media/disjoint_range_set_test.html
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/resources/media/main.js
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/browser/resources/media/media_internals.js
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/renderer/media/render_media_log.cc
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/renderer/media/render_media_log.h
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/content/renderer/media/render_media_log_unittest.cc
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/base/media_log.cc
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/base/media_log.h
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/base/media_log_event.h
[modify] https://crrev.com/1ff5a375ab0b3c53a6893a1e257c2d81a16a485b/media/blink/webmediaplayer_impl.cc
►

Sign in to add a comment