New issue
Advanced search Search tips

Issue 734189 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve clarity of error message for missing coverage.

Project Member Reported by erikc...@chromium.org, Jun 16 2017 
I added a conditional to "scripts/slave/recipe_modules/chromium_tests/api.py". I then added a test to scripts/slave/recipes/chromium_trybot.py that exercised this conditional. However, I was still missing coverage. Apparently this is because coverage is evaluated on a per-module basis. Please improve the error message to indicate this.

"""
Name                                                 Stmts   Miss  Cover   Missing
----------------------------------------------------------------------------------
scripts/slave/recipe_modules/chromium_tests/api.py     424      1    99%   876
----------------------------------------------------------------------------------
TOTAL                                                19505      1    99%

481 files skipped due to complete coverage.

FATAL: Insufficient coverage (99%)
----------------------------------------------------------------------
Ran 1782 tests in 85.751s

FAILED

NOTE: You may need to re-train the expectation files by running:

  ./scripts/slave/.recipe_deps/recipe_engine/recipes.py --package /Users/erikchen/projects/infra/build/infra/config/recipes.cfg test train
"""

Comment 1 by tandrii@chromium.org, Jun 20 2017

Status: Available (was: Untriaged)
This is fair, and in fact this is relatively recent change wrt to strict module coverage.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 20 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by s...@google.com, Jun 20 2018

Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
This is intentional but I agree the error message should say that chromium_tests needs to cover chromium_tests and that chromium_trybot covering chromium_test's new codepath doesn't suffice.

Comment 4 by martiniss@chromium.org, Jul 13

Owner: ----
Status: Available (was: Assigned)
I'm not directly working on recipes anymore, marking this as available.

Comment 5 by iannu...@google.com, Oct 18

Cc: iannu...@google.com
►

Sign in to add a comment