New issue
Advanced search Search tips

Issue 734165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 723233



Sign in to add a comment

Remove 10s delay in throttling backgrounded tabs

Project Member Reported by skyos...@chromium.org, Jun 16 2017

Issue description

We currently wait 10s before throttling background tabs. We should avoid this because it means backgrounded tabs can negatively affect the performance of the foreground tab during this period.
 
Blocking: 723233
I ran a custom build Chrome without 10s delay to check if the new wake-up based throttling code in the latest Chrome can avoid the problems with  crbug.com/649942 .

As far as I can perceive, Tampermonkey and Feedly Notifier do not show any performance regression.
Owner: toyoshim@chromium.org
Status: Started (was: Available)
Labels: -Pri-3 M-61 Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa449b76a4ea265126b7c3bdd5084589e5b66adf

commit aa449b76a4ea265126b7c3bdd5084589e5b66adf
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Jun 22 05:33:41 2017

Remove 10s delay in throttling backgrounded tabs

The background tab throttling is delayed by 10s mainly to solve the
slow extension pop-up issue ( crbug.com/649942 ).
But, now that Blink scheduler has the he new wake-up based throttling,
this workaround should not be needed any more.

This patch virtually reverts https://codereview.chromium.org/2620743002/

BUG= 734165 
TEST=manually check if this does not cause the extension pop-up issue.

Change-Id: Id8459e43340e50ce48c0d443d6bd8a9bcaee64a6
Reviewed-on: https://chromium-review.googlesource.com/543095
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481449}
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/LayoutTests/fast/dom/timer-throttling-hidden-page-expected.txt
[add] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/LayoutTests/fast/dom/timer-throttling-hidden-page.html
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/WebFrameScheduler.h
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/aa449b76a4ea265126b7c3bdd5084589e5b66adf/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment