New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734164 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 735708
issue 735709



Sign in to add a comment

Suggested apps UI specification for new launcher

Project Member Reported by warx@chromium.org, Jun 16 2017

Issue description

Open a bug for specs:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZY5BZ8F2qhKy/files/MCHgFRh42HkbNeJY6DX6XZqi

03 - Collapsed launcher, Suggested apps detailed visual design section.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261cfcff3d89a69ca461e9db74e75acd907b057b

commit 261cfcff3d89a69ca461e9db74e75acd907b057b
Author: warx <warx@chromium.org>
Date: Wed Jun 21 21:21:14 2017

cros: Make SearchResultTileItemView layout per DisplayType customized

changes:
(1) TileItemView used to do layout work for both start page tile items
and search box searched app results tile items. For new launcher, their
layout requirements are different. We shall consider put the layout
code in SearchResultTileItemView, as there we can know the
SearchResult::DISPLAY_TYPE and then customize the layout.
(2) Some UI adjustment of recommendation DISPLAY_TYPE:
based on specification of https://screenshot.googleplex.com/wb5PjqfLSCf
tile size, icon top padding, title top spacing, title color/size.

R=xiyuan@chromium.org, weidongg@chromium.org
CC=newcomer@chromium.org
BUG= 734164 
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag

Review-Url: https://codereview.chromium.org/2952823002
Cr-Commit-Position: refs/heads/master@{#481307}

[modify] https://crrev.com/261cfcff3d89a69ca461e9db74e75acd907b057b/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/261cfcff3d89a69ca461e9db74e75acd907b057b/ui/app_list/app_list_constants.h
[modify] https://crrev.com/261cfcff3d89a69ca461e9db74e75acd907b057b/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/261cfcff3d89a69ca461e9db74e75acd907b057b/ui/app_list/views/search_result_tile_item_view.h
[modify] https://crrev.com/261cfcff3d89a69ca461e9db74e75acd907b057b/ui/app_list/views/tile_item_view.cc
[modify] https://crrev.com/261cfcff3d89a69ca461e9db74e75acd907b057b/ui/app_list/views/tile_item_view.h

Comment 2 by warx@chromium.org, Jun 21 2017

Blockedon: 735709

Comment 3 by warx@chromium.org, Jun 21 2017

Blockedon: 735708
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eb7d7b4449fee720181f73e4ea0947fc903b88d

commit 4eb7d7b4449fee720181f73e4ea0947fc903b88d
Author: warx <warx@chromium.org>
Date: Fri Jun 23 00:29:31 2017

cros: add SUGGESTED APPS indicator to start page

Changes:
(1) Create IndicatorChipView, as it is needed for both suggested apps
and all apps.
(2) add 24px top padding for search box on start page.
(3) change start page search box width to 544px.
(4) 21px padding between search box and indicator.

WIP screenshot: https://screenshot.googleplex.com/XqW9ZXqVVnO
Note: tiles layout are not updated yet.

R=xiyuan@chromium.org
CC=newcomer@chromium.org
BUG= 734164 
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag

Review-Url: https://codereview.chromium.org/2952303002
Cr-Commit-Position: refs/heads/master@{#481745}

[modify] https://crrev.com/4eb7d7b4449fee720181f73e4ea0947fc903b88d/ui/app_list/BUILD.gn
[add] https://crrev.com/4eb7d7b4449fee720181f73e4ea0947fc903b88d/ui/app_list/views/indicator_chip_view.cc
[add] https://crrev.com/4eb7d7b4449fee720181f73e4ea0947fc903b88d/ui/app_list/views/indicator_chip_view.h
[modify] https://crrev.com/4eb7d7b4449fee720181f73e4ea0947fc903b88d/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/4eb7d7b4449fee720181f73e4ea0947fc903b88d/ui/app_list/views/start_page_view.h
[modify] https://crrev.com/4eb7d7b4449fee720181f73e4ea0947fc903b88d/ui/strings/ui_strings.grd

Comment 5 by warx@chromium.org, Jun 27 2017

Labels: NewLauncherUIV1
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e14c4c49b1644ac9afce55148186cd0c9d9ad3a8

commit e14c4c49b1644ac9afce55148186cd0c9d9ad3a8
Author: Qiang Xu <warx@chromium.org>
Date: Wed Jun 28 23:32:03 2017

cros: num_results() for new launcher excluding all apps button

changes:
This will fix the crash when tabbing suggestion tiles over 5 times.

R: xiyuan@chromium.org
Bug:  734164 
Test: crash does not happen any more
Change-Id: Ieb3ea0570239b589d809e3776a0d6119a4d6f23d
Reviewed-on: https://chromium-review.googlesource.com/553539
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483190}
[modify] https://crrev.com/e14c4c49b1644ac9afce55148186cd0c9d9ad3a8/ui/app_list/views/suggestions_container_view.cc
[modify] https://crrev.com/e14c4c49b1644ac9afce55148186cd0c9d9ad3a8/ui/app_list/views/suggestions_container_view.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e

commit b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e
Author: Qiang Xu <warx@chromium.org>
Date: Fri Jun 30 16:28:59 2017

cros: keyboard focus for expand arrow button

changes:
(1) When expand arrow selected, draw a #FFF 12%,  18px radius circle.
(2) add keyboard focus behaviors related with expand arrow button:
a. when expand arrow selected:
arrow up/arrow left/shift-tab move focus to the last suggestion tile,
arrow right/tab move focus to the first suggestion tile.
b. when focus is inside suggestions container, arrow down would move
focus to expand arrow button; when focus is at the last tile of
suggestions, arrow right would move focus to expand arrow button.
c. tab/shift-tab just work as usual.

tested with and without --enable-features=EnableFullscreenAppList

Bug:  735708 ,  734164 
TEST: screenshot of highlight:
https: //screenshot.googleplex.com/YdFbRnKVXyF
Change-Id: Ice124bb69123b1331608c6a45b17a0debdc6335c
Reviewed-on: https://chromium-review.googlesource.com/557464
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483728}
[modify] https://crrev.com/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e/ui/app_list/views/expand_arrow_view.cc
[modify] https://crrev.com/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e/ui/app_list/views/expand_arrow_view.h
[modify] https://crrev.com/b80af55bbd0fc71afbdbfdaa95160e8947bf4b0e/ui/app_list/views/start_page_view.cc

Comment 8 by warx@chromium.org, Jul 6 2017

Status: Fixed (was: Assigned)
mostly done.

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment