New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Retire legacy USB printer detection code

Project Member Reported by justincarlson@chromium.org, Jun 16 2017

Issue description

The legacy USB detection has been cleared for destruction in favor of the new CUPS hotness.  Remove it with prejudice.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ddcddc4b0adad18246c1bea349dd7b5129357f

commit 77ddcddc4b0adad18246c1bea349dd7b5129357f
Author: justincarlson <justincarlson@chromium.org>
Date: Sat Jun 17 01:53:11 2017

Remove the legacy (extension-notifier) usb printer detector.

Also, Rename the remaining printerdetector with the less prefix 'Usb' in preparation for other work on printer detection.

BUG= 734161 

Review-Url: https://codereview.chromium.org/2945653002
Cr-Commit-Position: refs/heads/master@{#480267}

[modify] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/ba7d2a4286782b977191392e2d3ff128e995dd35/chrome/browser/chromeos/printer_detector/legacy_printer_detector.cc
[delete] https://crrev.com/ba7d2a4286782b977191392e2d3ff128e995dd35/chrome/browser/chromeos/printer_detector/printer_detector.h
[delete] https://crrev.com/ba7d2a4286782b977191392e2d3ff128e995dd35/chrome/browser/chromeos/printer_detector/printer_detector_factory.cc
[delete] https://crrev.com/ba7d2a4286782b977191392e2d3ff128e995dd35/chrome/browser/chromeos/printer_detector/printer_detector_factory.h
[delete] https://crrev.com/ba7d2a4286782b977191392e2d3ff128e995dd35/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc
[rename] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/chromeos/printer_detector/usb_printer_detector.cc
[add] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/chromeos/printer_detector/usb_printer_detector.h
[add] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/chromeos/printer_detector/usb_printer_detector_factory.cc
[add] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/chromeos/printer_detector/usb_printer_detector_factory.h
[modify] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/chromeos/printing/printer_discoverer.cc
[modify] https://crrev.com/77ddcddc4b0adad18246c1bea349dd7b5129357f/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

Status: Fixed (was: Assigned)

Sign in to add a comment