[autofill] Delete profiles that are unused after some threshold |
||||||||
Issue descriptionChrome accumulates addresses and credit cards indefinitely (modulo merge). After 6 months of disuse for a given address/profile or expired credit card, stop suggesting it unless it is a match for what the user has started typing. I.e., elide it from the initial set of suggestions. After one year of disuse for a given address/profile or expired card, delete it.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8af7f59317c7fe10cd1e013c69d506544a9eb685 commit 8af7f59317c7fe10cd1e013c69d506544a9eb685 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Jul 21 16:10:02 2017 [autofill] Suppress disused address suggestions If enabled, suppress the suggestion of disused addresses (i.e., those not used the last 6 months) unless they match non-empty user input. BUG= 734151 Change-Id: I6b2e52cce16f36af16b41d5a1aeafa2dd79752aa Reviewed-on: https://chromium-review.googlesource.com/576627 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#488671} [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/8af7f59317c7fe10cd1e013c69d506544a9eb685/tools/metrics/histograms/histograms.xml
,
Jul 26 2017
Merge requested to M61 for https://chromium-review.googlesource.com/576627
,
Jul 26 2017
Please add appropriate OSs.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e35c2f80469d4135cb2df766134ce65a8c54f2e commit 4e35c2f80469d4135cb2df766134ce65a8c54f2e Author: Roger McFarlane <rogerm@chromium.org> Date: Thu Jul 27 14:49:56 2017 [autofill] Additional tests for disused address suggestion suppression. This CL adds two additional test scenarios (1) All of the candidate suggestions are disused. (2) None of the candidate suggestions are disused. BUG= 734151 R=sebsg@chromium.org Change-Id: Ifa8d61bd5e95e55e6f9348106da9e3e1ec8d2c07 Reviewed-on: https://chromium-review.googlesource.com/587708 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#489922} [modify] https://crrev.com/4e35c2f80469d4135cb2df766134ce65a8c54f2e/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb1b869e89119b630ff37d2a6a7588c49a5bace commit 9cb1b869e89119b630ff37d2a6a7588c49a5bace Author: Roger McFarlane <rogerm@chromium.org> Date: Thu Jul 27 14:59:39 2017 [autofill] Log disused addresses count iff user actually has addresses. autofill::PersonalDataManager::LogStoredProfileMetrics was always logging the number of disused address profiles (i.e., addresses that have not been use for at least 180 days) irrespective of whether or not the user had any addresses to consider. This dilutes the signal of this metric with 0 for all the user's that don't actually have ANY addresses stored. BUG= 734151 R=sebsg@chromium.org Change-Id: I55f04bb060e4cb6dbf40780d446b3973993d6c0d Reviewed-on: https://chromium-review.googlesource.com/587338 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#489924} [modify] https://crrev.com/9cb1b869e89119b630ff37d2a6a7588c49a5bace/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/9cb1b869e89119b630ff37d2a6a7588c49a5bace/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Jul 27 2017
,
Jul 28 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
Pls merge you change to M61 branch 3163 by 5:00 PM today, Friday if possible so we can take it in for next week M61 last dev release. Thank you.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fef42fc5346f6a4339c499632b491d9c8de12944 commit fef42fc5346f6a4339c499632b491d9c8de12944 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Jul 28 18:20:10 2017 [autofill] Suppress disused address suggestions If enabled, suppress the suggestion of disused addresses (i.e., those not used the last 6 months) unless they match non-empty user input. BUG= 734151 TBR=rogerm@chromium.org (cherry picked from commit 8af7f59317c7fe10cd1e013c69d506544a9eb685) Change-Id: I6b2e52cce16f36af16b41d5a1aeafa2dd79752aa Reviewed-on: https://chromium-review.googlesource.com/576627 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488671} Reviewed-on: https://chromium-review.googlesource.com/592138 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#104} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/fef42fc5346f6a4339c499632b491d9c8de12944/tools/metrics/histograms/histograms.xml
,
Jul 28 2017
Also requesting merge approval for https://chromium-review.googlesource.com/587338 the change takes some logging and puts an if around it to avoid logging a 0 because the user has no data what-so-ever as opposed the user having data, but no data meeting the criteria. It also simplifies the logging a bit. The tests validate that the logging is otherwise the same as it was before.
,
Jul 28 2017
Approving merge to M61 branch 3163 per comment #11 and chat with rogerm@.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bae8a407ad18db5543da5e0861efc0147abda966 commit bae8a407ad18db5543da5e0861efc0147abda966 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Jul 28 18:58:11 2017 [autofill] Log disused addresses count iff user actually has addresses. autofill::PersonalDataManager::LogStoredProfileMetrics was always logging the number of disused address profiles (i.e., addresses that have not been use for at least 180 days) irrespective of whether or not the user had any addresses to consider. This dilutes the signal of this metric with 0 for all the user's that don't actually have ANY addresses stored. BUG= 734151 R=sebsg@chromium.org TBR=rogerm@chromium.org (cherry picked from commit 9cb1b869e89119b630ff37d2a6a7588c49a5bace) Change-Id: I55f04bb060e4cb6dbf40780d446b3973993d6c0d Reviewed-on: https://chromium-review.googlesource.com/587338 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489924} Reviewed-on: https://chromium-review.googlesource.com/592268 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#109} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/bae8a407ad18db5543da5e0861efc0147abda966/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/bae8a407ad18db5543da5e0861efc0147abda966/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Aug 3 2017
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a458110f5f0d57fc58682767b2699de7356dce03 commit a458110f5f0d57fc58682767b2699de7356dce03 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Sep 08 18:23:18 2017 [autofill] Add UMA metrics to track disused credit cards. This CL expands the UMA metrics which track the number of autofill credit cards the user has at Chrome profile launch as well as their last use distribution (in days) and the number of them that would be considered disused. BUG= 734151 Change-Id: Ibc551f848a8ce05d30cea8d1a3cabb2b5b9845db Reviewed-on: https://chromium-review.googlesource.com/650806 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#500625} [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/autofill_test_utils.cc [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/autofill_test_utils.h [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/a458110f5f0d57fc58682767b2699de7356dce03/tools/metrics/histograms/histograms.xml
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17b54c0f301b7bb0b097b5a612e37b4ec8714249 commit 17b54c0f301b7bb0b097b5a612e37b4ec8714249 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Sep 08 22:28:03 2017 [autofill] test util was misusing base::RandInt Fix a bug where base::RandInt(a, b) was being used as if it generated numbers in the range [a, b) when it in fact generates numbers in the range [a, b] (i.e., the last value is inclusive). (Mis)Use to randomly index into a table... Flakiness ensues... :( Bug: 734151 Change-Id: I58ac0cf6696af8b3d181504b976a79cf14136888 Reviewed-on: https://chromium-review.googlesource.com/657892 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#500708} [modify] https://crrev.com/17b54c0f301b7bb0b097b5a612e37b4ec8714249/components/autofill/core/browser/autofill_test_utils.cc
,
Sep 15 2017
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba commit ba7fd66dfd5421370a901e2207db13eb0e8ff0ba Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Mon Sep 18 16:51:48 2017 [autofill] Stop suggesting disused credit cards that are expired too If enabled, suppress the suggestion of credit cards that are disused (have not been used in last 6 month) and expired, unless they match non-empty user input. Bug: 734151 Change-Id: Ida498c2294202d46a336e276c1f5daa2c4d5d83c Reviewed-on: https://chromium-review.googlesource.com/660397 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#502587} [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/ba7fd66dfd5421370a901e2207db13eb0e8ff0ba/tools/metrics/histograms/histograms.xml
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d601bd49511ec735f2a7ffb297298ef0ea99682 commit 6d601bd49511ec735f2a7ffb297298ef0ea99682 Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Mon Sep 25 15:20:09 2017 [autofill] Delete disused expired credit cards after 13 month If enabled, delete autofill credit cards that are expired more than 13 month ago and also have not been used in last 13 month. This will run only once for every major version upgrade. Bug: 734151 Change-Id: I426a80062d5c403d96e270b9ebd0c101bae79234 Reviewed-on: https://chromium-review.googlesource.com/671502 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504058} [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/common/autofill_pref_names.cc [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/components/autofill/core/common/autofill_pref_names.h [modify] https://crrev.com/6d601bd49511ec735f2a7ffb297298ef0ea99682/tools/metrics/histograms/histograms.xml
,
Oct 4 2017
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b54dd1ebcf8d40da3ea218472de1d4aafe4e5375 commit b54dd1ebcf8d40da3ea218472de1d4aafe4e5375 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Aug 10 14:31:24 2018 [autofill] Make unittests agnostic to default state of deletion feature. This CL fixes the following two unit tests: - PersonalDataManagerTest.DeleteDisusedAdddresses_DoNothingWhenDisabled - PersonalDataManagerTest.DeleteDisusedCreditCards_DoNothingWhenDisabled Both tests expected that the deletion feature was disabled by default in the context of the test; the tests now explicitly disable the deletion feature. This CL also ensures that the deletion related Autofill Prefs are registered for autofill-related sync unittests. The prefs need to have been properly registered if the deletion feature is enabled when those tests are run. Bug: 734151 Change-Id: Iec6585536c5e563d81d8404f717438832e65ebdb Reviewed-on: https://chromium-review.googlesource.com/1169423 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#582153} [modify] https://crrev.com/b54dd1ebcf8d40da3ea218472de1d4aafe4e5375/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/b54dd1ebcf8d40da3ea218472de1d4aafe4e5375/components/browser_sync/profile_sync_service_autofill_unittest.cc
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bab4b77b5bc3fff476935ad75bcf40f7f9692a61 commit bab4b77b5bc3fff476935ad75bcf40f7f9692a61 Author: Roger McFarlane <rogerm@chromium.org> Date: Fri Aug 10 17:04:20 2018 [autofill] Add fieldtrial config for AutofillDeleteDisusedData Bug: 734151 Change-Id: Ia2a04fd5acaae8cfa32bbec102a47d31e4294db1 Reviewed-on: https://chromium-review.googlesource.com/1169422 Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582215} [modify] https://crrev.com/bab4b77b5bc3fff476935ad75bcf40f7f9692a61/testing/variations/fieldtrial_testing_config.json |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017