TestBrowserThreadBundle Should Initialize COM |
||
Issue descriptionbase::debug::StackTrace::StackTrace [0x023B0297+55] base::debug::StackTrace::StackTrace [0x023BF1FA+10] base::win::AssertComInitialized [0x023DA7D3+115] base::win::ComInitCheckHook::~ComInitCheckHook [0x023D88B8+24] base::win::ResolveShortcutProperties [0x0236CD66+230] base::win::ResolveShortcut [0x0236CC0D+157] profiles::internal::ShortcutFilenameMatcher::IsCanonical [0x0337BAE6+445] std::insert_iterator<std::set<base::FilePath,std::less<base::FilePath>,std::allocator<base::FilePath> > >::operator= [0x03379EC3+101] ProfileShortcutManager::IsFeatureEnabled [0x0337BC08+201] profiles::internal::CreateProfileShortcutFlags [0x0337AF0D+426] base::internal::Invoker<base::internal::BindState<base::internal::IgnoreResultHelper<bool (__cdecl*)(base::FilePath const &,bool)>,base::FilePath,bool>,void __cdecl(void)>::RunOnce [0x0337C502+18] base::debug::TaskAnnotator::RunTask [0x023C2339+409] base::MessageLoop::RunTask [0x02342991+1233] base::MessageLoop::DoWork [0x02341C7D+765] base::MessagePumpForUI::DoRunLoop [0x023B837D+93] base::MessagePumpWin::Run [0x023B8B0A+74] base::MessageLoop::Run [0x023424AB+107] base::RunLoop::Run [0x0232F353+147] base::RunLoop::RunUntilIdle [0x0232F433+99] content::TestBrowserThreadBundle::~TestBrowserThreadBundle [0x01C8F60D+82] ProfileAttributesStorageTest::~ProfileAttributesStorageTest [0x004D52C8+25] content::ServiceWorkerDispatcher::WillStopCurrentWorkerThread [0x02ADD66A+10] testing::TestInfo::Run [0x00CB326F+156] testing::TestCase::Run [0x00CB317C+133] testing::internal::UnitTestImpl::RunAllTests [0x00CB3501+433]
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bde45e4ced6daf620f669e0987f390a2a8846f2 commit 0bde45e4ced6daf620f669e0987f390a2a8846f2 Author: Robert Liao <robliao@chromium.org> Date: Fri Jun 23 15:59:26 2017 Add COM Initialization to TestBrowserThread and TestBrowserThreadBundle BrowserProcessSubThread initializes COM, so TestBrowserThread and TestBrowserThreadBundle should too. BUG= 734135 Change-Id: I8cd0f1422bd4e680372c542f79dc9763879433ec Reviewed-on: https://chromium-review.googlesource.com/540100 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#481908} [modify] https://crrev.com/0bde45e4ced6daf620f669e0987f390a2a8846f2/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc [modify] https://crrev.com/0bde45e4ced6daf620f669e0987f390a2a8846f2/content/public/test/test_browser_thread.cc [modify] https://crrev.com/0bde45e4ced6daf620f669e0987f390a2a8846f2/content/public/test/test_browser_thread_bundle.cc [modify] https://crrev.com/0bde45e4ced6daf620f669e0987f390a2a8846f2/content/public/test/test_browser_thread_bundle.h
,
Jun 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by robliao@chromium.org
, Jun 19 2017