New issue
Advanced search Search tips

Issue 734131 link

Starred by 1 user
Status: Fixed
Owner:
pkotw...@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 734142



Sign in to add a comment

Add support for HTTP->HTTPS rewriting to shell apk

Project Member Reported by yfried...@chromium.org, Jun 16 2017 
We want to experiment with adding support for having a webapk also register for http protocol but seemlessly rewriting to https. This is only for main frame requests which fall into its scope. Given that we don't yet have an approved way of specifying this in a manifest (and we aren't sure whether we want it there), let's start conservatively and only add this for unbound webapks.

Comment 1 by yfried...@chromium.org, Jun 16 2017 

Server work tracking in b/62709676

Comment 2 by yfried...@chromium.org, Jun 16 2017

Blocking: 734142
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/938436754b8913bdfff87341189844b7f3cf7a57

commit 938436754b8913bdfff87341189844b7f3cf7a57
Author: pkotwicz <pkotwicz@chromium.org>
Date: Fri Jul 21 13:18:27 2017

Adding pystache to third_party

BUG= 734131 ,  734136 

Review-Url: https://codereview.chromium.org/2962783004
Cr-Commit-Position: refs/heads/master@{#488641}

[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/LICENSE
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/OWNERS
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/README.chromium
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/__init__.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/common.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/context.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/defaults.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/init.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/loader.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/locator.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/parsed.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/parser.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/renderengine.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/renderer.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/specloader.py
[add] https://crrev.com/938436754b8913bdfff87341189844b7f3cf7a57/third_party/pystache/src/template_spec.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb0e86ae26eaa4205601bc78c9db1a665c805fdc

commit eb0e86ae26eaa4205601bc78c9db1a665c805fdc
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Mon Jul 24 15:23:57 2017

Move third_party/pystache/src to third_party/pystache

This enables importing the library via "import pystache".

BUG= 734131 ,  734136 

Change-Id: Ica55346a40e256fe7f12d4cf0454e0cde36c40f9
Reviewed-on: https://chromium-review.googlesource.com/582170
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488976}
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/__init__.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/common.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/context.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/defaults.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/init.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/loader.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/locator.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/parsed.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/parser.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/renderengine.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/renderer.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/specloader.py
[rename] https://crrev.com/eb0e86ae26eaa4205601bc78c9db1a665c805fdc/third_party/pystache/template_spec.py
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c7ac7c0265c50a2da530c21f040a90413a2b080

commit 6c7ac7c0265c50a2da530c21f040a90413a2b080
Author: pkotwicz <pkotwicz@chromium.org>
Date: Fri Jul 28 05:07:20 2017

[Android] Enable WebAPK to have multiple intent filters

This CL:
- Changes AndroidManifest.xml MoTemplate to support multiple intent filters
- Moves the MoTemplate configuration to external .json files
- Adds logic to rewrite URLs from deep links to the scope URL's scheme and host
  name. This handles the case of:
  1) The WebAPK has intent filters for several TLDs (e.g.
https://maps.google.ca,
     https://maps.google.fr, ...)
  2) It is desired to change the TLD of the intent URL to '.com' so that all
     incoming intent URLs fall under one service worker.

BUG= 734131 , 734136 

Review-Url: https://codereview.chromium.org/2956193002
Cr-Commit-Position: refs/heads/master@{#490275}

[modify] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/AndroidManifest.xml
[modify] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/BUILD.gn
[add] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/bound_manifest_config.json
[add] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/javatest_manifest_config.json
[add] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
[modify] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/manifest_processor.gni
[modify] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/manifest_processor.py
[modify] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
[add] https://crrev.com/6c7ac7c0265c50a2da530c21f040a90413a2b080/chrome/android/webapk/shell_apk/unbound_manifest_config.json

Comment 6 by yfried...@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment