New issue
Advanced search Search tips

Issue 734126 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 669453



Sign in to add a comment

Use Skia Variable Font Instantiation based on Font properties, not based on CSS

Project Member Reported by drott@chromium.org, Jun 16 2017

Issue description

In FontCustomPlatformData we're currently going through the FreeType or CoreText variable font path depending on CSS, but we should do that whenever we encounter a variable font.


 

Comment 1 by drott@chromium.org, Jun 16 2017

Blocking: 669453
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65fe7ca188fcd0ad75d49b8c577e9966c9487fea

commit 65fe7ca188fcd0ad75d49b8c577e9966c9487fea
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Jun 16 21:03:12 2017

Switch to instantiating variable fonts based on font properties

Instead of choosing the variable font path based on CSS, we should
switch to it dependent on characteristics of the font itself.

BUG= 734126 
TEST=fast/text/variable-fonts/*

Change-Id: Ic9bff20d8fa09329169b21450085330c620ce346
Reviewed-on: https://chromium-review.googlesource.com/538661
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480157}
[modify] https://crrev.com/65fe7ca188fcd0ad75d49b8c577e9966c9487fea/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/65fe7ca188fcd0ad75d49b8c577e9966c9487fea/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[add] https://crrev.com/65fe7ca188fcd0ad75d49b8c577e9966c9487fea/third_party/WebKit/Source/platform/fonts/opentype/VariableFontCheck.cpp
[add] https://crrev.com/65fe7ca188fcd0ad75d49b8c577e9966c9487fea/third_party/WebKit/Source/platform/fonts/opentype/VariableFontCheck.h

Comment 3 by drott@chromium.org, Jun 28 2017

Status: Fixed (was: Started)

Sign in to add a comment