New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734125 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add support for querying controls and min/max for PTZ to chrome.webcamPrivate.

Project Member Reported by pbos@chromium.org, Jun 16 2017

Issue description

chrome.webcamPrivate currently only supports getting/setting PTZ values, but not querying for the absolute ranges (and setting is using range-specific values), which results in apps using hard-coded ranges per detected camera.

VIDIOC_QUERYCTRL should be exposed to provide min/max for these (+ query whether absolute or relative PTZ is supported).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ff2e79d39922b52b76c1f71cddb6d2f2597272

commit 69ff2e79d39922b52b76c1f71cddb6d2f2597272
Author: Peter Boström <pbos@chromium.org>
Date: Fri Jun 23 18:57:45 2017

Add support for querying min/max PTZ values.

Pan, tilt and zoom commands in chrome.webcamPrivate all use
device-specific ranges for argument values. To reasonably support
multiple cameras, or devices where PTZ ranges depend on firmware version
it makes sense to add support for querying ranges.

This adds support for V4L2, and the values are optional. If a camera
supports absolute pan for instance, then minPan and maxPan will be
available in the resultant struct. Same for tilt- zoom-equivalent
values.

Support for querying these values have not been added to VISCA as I do
not have this camera available. For this camera the range will currently
be absent.

BUG= chromium:734125 
R=tbarzic@chromium.org, zork@chromium.org

Change-Id: I75a004c5b971d238a6372f796000eebb7327f8a0
Reviewed-on: https://chromium-review.googlesource.com/544315
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481976}
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/v4l2_webcam.cc
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/v4l2_webcam.h
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/visca_webcam.cc
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/visca_webcam_unittest.cc
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/webcam.h
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/webcam_private_api.h
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
[modify] https://crrev.com/69ff2e79d39922b52b76c1f71cddb6d2f2597272/extensions/common/api/webcam_private.idl

Comment 2 by pbos@chromium.org, Jun 23 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment