Remove strago from pre-cq COMMIT-QUEUE.ini files
Reported by
jrbarnette@chromium.org,
Jun 16 2017
|
|||||||||||||
Issue description
Chrome Version: N/A
Chrome OS Version: current ToT since ?
Chrome OS Platform: strago
Network info: N/A
Steps To Reproduce:
(1) Create a chroot, and run these commands:
./setup_board --board=strago
./build_packages --board=strago
Expected Result:
The build should succeed.
Actual Result:
!!! The ebuild selected to satisfy "chromeos-base/android-container-nyc" for /build/strago/ has unmet requirements.
- chromeos-base/android-container-nyc-4106211-r1::cheets-private USE="cheets_user -cheets_aosp_userdebug -cheets_local_img -cheets_sdk_userdebug -cheets_user_64 -cheets_userdebug -direncryption" ABI_X86="64"
The following REQUIRED_USE flag constraints are unsatisfied:
direncryption
The above constraints are a subset of the following complete expression:
exactly-one-of ( cheets_aosp_userdebug cheets_sdk_userdebug cheets_user cheets_user_64 cheets_userdebug ) arm? ( !cheets_aosp_userdebug !cheets_sdk_userdebug !cheets_userdebug !cheets_user_64 ) direncryption
How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
This problem is currently causing all "strago" pre-CQ builds to
fail. "strago" is part of the default pre-CQ config for v3.18
kernel code changes, so all v3.18 kernel changes are blocked.
What is the impact to the user, and is there a workaround? If so, what is
it?
No workaround for the pre-CQ failures as such. If you just want to test
build 3.18 changes, "cyan" and "reks" still build properly.
Please provide any additional information below. Attach a screen shot or
log if possible.
For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
,
Jun 16 2017
Possibly related to this change? https://chromium-review.googlesource.com/c/525997/ Deprecate strago paladin The strago paladin is covered by cyan already, so we should not need this paladin builder.
,
Jun 16 2017
> Possibly related to this change? > https://chromium-review.googlesource.com/c/525997/ Probably so. I'll go ask if it's likely that reverting that CL can get the pre-CQ back on track...
,
Jun 16 2017
I've been looking at the failures, and looking at our options for
a fix. I think reverting the problem CL isn't a good way forward.
The best option seems to be to find all COMMIT-QUEUE.ini files that
name a "strago" builder, and convert them to use "cyan" or "reks"
instead.
The top two repos that need updating are these:
src/third_party/kernel/v3.18/COMMIT-QUEUE.ini
src/platform/ec/COMMIT-QUEUE.ini
,
Jun 16 2017
Right, we can probably just deprecate cyan, in the interim we can give cyan the direncryption use flag.
,
Jun 16 2017
> Right, we can probably just deprecate cyan, in the interim we can > give cyan the direncryption use flag. "deprecate cyan" - Um, did you mean "strago"? Perhaps "deprecate strago in favor of cyan?" Also, ATM I don't think that the direncryption use flag is a concern. cyan and reks still build: That's what matters first.
,
Jun 16 2017
Here's the list of COMMIT-QUEUE.ini files needing fixes:
src/partner_private/marvell-kernel/COMMIT-QUEUE.ini
src/platform/depthcharge/COMMIT-QUEUE.ini
src/platform/ec/COMMIT-QUEUE.ini
src/overlays/overlay-strago/COMMIT-QUEUE.ini
src/overlays/baseboard-strago/COMMIT-QUEUE.ini
src/private-overlays/overlay-strago-private/COMMIT-QUEUE.ini
src/third_party/coreboot/COMMIT-QUEUE.ini
src/third_party/kernel/v3.18/COMMIT-QUEUE.ini
Most important are the ec, kernel, and coreboot files.
,
Jun 16 2017
Is the marvell-kernel related to "cyclone"? If yes, that is a dead project and should be deleted. (this was a prototype AP/router board that predates gale)
,
Jun 16 2017
This is taking down the pre-CQ nearly across the board. Upping to P0.
,
Jun 16 2017
Actually not across the board. Perhaps only in those unlucky repos. Borderline between major/minor outage. Returning to P1.
,
Jun 16 2017
I think we need to go back to plan A, and start changing the COMMIT-QUEUE.ini files listed in c#7.
,
Jun 16 2017
https://chromium-review.googlesource.com/#/c/538874/ should fix the actual failure. https://chromium-review.googlesource.com/#/c/538068/ https://chromium-review.googlesource.com/#/c/538912/ https://chromium-review.googlesource.com/#/c/538571/ should prevent breakage in strago from causing harm, replacing it with more carefully watched systems.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ca32d7a13f50fe6564ab86fd912c62ce67583328 commit ca32d7a13f50fe6564ab86fd912c62ce67583328 Author: Bernie Thompson <bhthompson@google.com> Date: Fri Jun 16 19:21:33 2017 strago: set direncryption USE flag BUG= chromium:734103 TEST=`emerge-strago chromeos-cheets` Change-Id: I282922c8a2c02559e8a9860f5f8ae2f5948a8f1a Reviewed-on: https://chromium-review.googlesource.com/538874 Tested-by: Richard Barnette <jrbarnette@google.com> Trybot-Ready: Richard Barnette <jrbarnette@google.com> Trybot-Ready: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/ca32d7a13f50fe6564ab86fd912c62ce67583328/overlay-strago/profiles/base/make.defaults
,
Jun 16 2017
The change to the strago overlay has been chumped. There's decent evidence that that change will make strago build again. That in turn _should_ enable all the blocked CLs to move forward. Still need to wait and see if that's actually true.
,
Jun 16 2017
There's now a good half-dozen strago-pre-cq runs in progress, and all have passed the AndroidMetadata phase that used to fail. I _think_ that means the outage is over. We still need to take strago out of all the COMMIT-QUEUE.ini files, as listed in c#7.
,
Jun 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/dd18876337715d2d9e50ce807770b9ae474e34e7 commit dd18876337715d2d9e50ce807770b9ae474e34e7 Author: Bernie Thompson <bhthompson@google.com> Date: Sat Jun 17 00:24:28 2017 baseboard-strago: Use cyan-pre-cq instead of strago-pre-cq The stago build is not well kept after, as it is not used in production, cyan however is. BUG= chromium:734103 TEST=None Change-Id: I09b8fdbe33ec9969eb491efb6df5cbbdec8f39bb Reviewed-on: https://chromium-review.googlesource.com/538912 Commit-Ready: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Yixiang Li <yixiang@google.com> [modify] https://crrev.com/dd18876337715d2d9e50ce807770b9ae474e34e7/baseboard-strago/COMMIT-QUEUE.ini
,
Jun 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/deeb0ac7de3774b50c8468dfe281e0b9f03d2d46 commit deeb0ac7de3774b50c8468dfe281e0b9f03d2d46 Author: Bernie Thompson <bhthompson@google.com> Date: Sat Jun 17 00:24:25 2017 Use celes-pre-cq instead of strago-pre-cq The stago build is not well kept after, as it is not used in production, celes however is. BUG= chromium:734103 TEST=None Change-Id: Ie62a4729192fe63d18348f47105a2585c9e4f5be Reviewed-on: https://chromium-review.googlesource.com/538571 Commit-Ready: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Yixiang Li <yixiang@google.com> [modify] https://crrev.com/deeb0ac7de3774b50c8468dfe281e0b9f03d2d46/COMMIT-QUEUE.ini
,
Jun 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c0ce5dad5216a957459d7d28b3ac49082a47272b commit c0ce5dad5216a957459d7d28b3ac49082a47272b Author: Bernie Thompson <bhthompson@google.com> Date: Sat Jun 17 00:24:27 2017 Use cyan-pre-cq instead of strago-pre-cq The stago build is not well kept after, as it is not used in production, cyan however is. BUG= chromium:734103 TEST=None Change-Id: If559e9f6f3f7b8fe205b410b1fcd5041e1aa0adc Reviewed-on: https://chromium-review.googlesource.com/538068 Commit-Ready: Bernie Thompson <bhthompson@chromium.org> Tested-by: Richard Barnette <jrbarnette@google.com> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/c0ce5dad5216a957459d7d28b3ac49082a47272b/COMMIT-QUEUE.ini
,
Jun 19 2017
I haven't received strago-no-vmtest-pre-cq alerts since Friday. Declaring victory.
,
Jun 19 2017
We silenced the symptom by fixing strago. However, long term, we want to get rid of all our dependencies on strago. I haven't heard that we've definitively finished that work. bhthompson@ - can you comment on what additional work is needed?
,
Jun 19 2017
Re #21: What is the work needed to clean out strago? This bug is about a particular incident that was handled by unblocking CLs that were failing strago-no-vmtest-pre-cq. Please don't co-opt the bug for other work. File a follow up bug for strago cleanup, then close this bug as Fixed.
,
Jun 19 2017
I think we got all the strago-pre-cq configurations out. I see no mention of strago on the internal waterfall, and I don't see it being used on cbuildbot_config.py. We could remove the internal overlay from the manifest, and remove the public overlay to more definitively seal off the dead build, I am not sure if anyone is potentially using it anywhere that may object though.
,
Jun 19 2017
The list of files that need attention is in c#7. The following
still need attention:
src/partner_private/marvell-kernel/COMMIT-QUEUE.ini
src/platform/depthcharge/COMMIT-QUEUE.ini
src/overlays/overlay-strago/COMMIT-QUEUE.ini
src/private-overlays/overlay-strago-private/COMMIT-QUEUE.ini
src/third_party/coreboot/COMMIT-QUEUE.ini
This bug is and has been principally about the changes to
COMMIT-QUEUE.ini files listed above. I don't think we'll
obtain any benefit with a new bug, given all the history and
the outlines of the work are here.
I'm not going to be making those changes; I'm open to suggestions
for who should be assigned the work.
,
Jun 19 2017
Remove more pre-cq configs (missed compile-only versions earlier): https://chromium-review.googlesource.com/#/c/540275/ https://chromium-review.googlesource.com/#/c/540139/ https://chrome-internal-review.googlesource.com/#/c/397209/ (this one may be dead already? last commit was last August) Remove strago: https://chromium-review.googlesource.com/#/c/540156/ https://chrome-internal-review.googlesource.com/#/c/397129/
,
Jun 20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/vendor/marvell-kernel/+/083faa0dc1aa1c47d00c04ba12d7487b8d107440 commit 083faa0dc1aa1c47d00c04ba12d7487b8d107440 Author: Bernie Thompson <bhthompson@google.com> Date: Tue Jun 20 20:38:11 2017
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f6f1dcf1edf34c047dae63cd69f3f3f8bff81ee7 commit f6f1dcf1edf34c047dae63cd69f3f3f8bff81ee7 Author: Bernie Thompson <bhthompson@google.com> Date: Wed Jun 21 00:24:18 2017 overlay-strago: remove COMMIT-QUEUE.ini This is in preparation for removing Strago, if we remove the pre-cq config first, we should be able to land the removal cleanly. BUG= chromium:734103 TEST=None Change-Id: I28bda0457ed49a9e6c4dffeb76a516aa469d6090 Reviewed-on: https://chromium-review.googlesource.com/540176 Commit-Ready: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [delete] https://crrev.com/6458a6552ef20e3d606df6fca666c433bb9257af/overlay-strago/COMMIT-QUEUE.ini
,
Jul 10 2017
All that's left is this CL:
https://chrome-internal-review.googlesource.com/c/397209/
Which seems to be ready, but needs final approval from pprabhu@.
So, passing the buck.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8bb9dc37b337a0da6668acac1eeb7d435dacacbe commit 8bb9dc37b337a0da6668acac1eeb7d435dacacbe Author: Bernie Thompson <bhthompson@google.com> Date: Fri Jul 14 02:46:17 2017 Remove strago build configs BUG= chromium:734103 TEST=None Change-Id: Ife74a310548d10c945f843337bc7fba1637b5202 Reviewed-on: https://chromium-review.googlesource.com/545159 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/8bb9dc37b337a0da6668acac1eeb7d435dacacbe/cbuildbot/config_dump.json [modify] https://crrev.com/8bb9dc37b337a0da6668acac1eeb7d435dacacbe/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/8bb9dc37b337a0da6668acac1eeb7d435dacacbe/cbuildbot/chromeos_config.py
,
Jul 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/9e8984b9efd9c406d64139662c3d64f6173374e6 commit 9e8984b9efd9c406d64139662c3d64f6173374e6 Author: Bernie Thompson <bhthompson@google.com> Date: Fri Jul 14 22:01:20 2017
,
Jul 14 2017
I think.
,
Jan 22 2018
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/92dff894f06343afb3a5515cf5889f12d4f4c119 commit 92dff894f06343afb3a5515cf5889f12d4f4c119 Author: Bernie Thompson <bhthompson@google.com> Date: Sat Apr 28 01:05:16 2018 Remove strago overlay The strago build is no longer used, so we can remove it. BUG= chromium:734103 TEST=None Change-Id: I9e7063edb0801203f45073c83997da5a8fb7398c Reviewed-on: https://chromium-review.googlesource.com/540156 Commit-Ready: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/profiles/base/parent [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/toolchain.conf [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/profiles/base/make.defaults [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/chromeos-base/chromeos-bsp-strago/files/powerd_prefs/low_battery_shutdown_percent [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/chromeos-base/chromeos-bsp-strago/chromeos-bsp-strago-0.0.1-r7.ebuild [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/chromeos-base/chromeos-bsp-strago/chromeos-bsp-strago-0.0.1.ebuild [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/virtual/chromeos-bsp/chromeos-bsp-2.ebuild [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/metadata/layout.conf [delete] https://crrev.com/76a3202cad9f244b2b67129e93e52877bafaa1ed/overlay-strago/make.conf |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by jrbarnette@chromium.org
, Jun 16 2017Labels: -Pri-3 Pri-1
Owner: yixiang@chromium.org
Status: Assigned (was: Unconfirmed)