Issue 734095 link

Starred by 35 users

Issue metadata

Status:	Fixed
Owner:	finnur@chromium.org
Closed:	Aug 29
Cc:	hua...@chromium.org █ picksi@chromium.org chengx@chromium.org █ owe...@chromium.org brucedaw...@chromium.org chrisha@chromium.org peter@chromium.org █ rpop@chromium.org
Components:	UI>Notifications
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	2
Type:	Bug
merge-merged-testbranch merge-merged-3538

Blocked on:
issue 734098
issue 781792
issue 783018
issue 817974

Blocking:
issue 516147
issue 819675

Use the Windows Action Center for displaying Chrome's notifications

Project Member Reported by peter@chromium.org, Jun 16 2017

Issue description

Let's use this issue to track implementation progress so that we can use Issue 516147 as a forum for progress announcements given the number of people that have starred it.

Let's continue with the existing plan to use Windows 10 Anniversary Edition as a baseline - we can decide on bringing a modified experience to older versions of Windows afterwards.

I'll land the first two or three patches to hook it up with our existing notification system, after which Finnur will take over the display side and our Windows team will help out with the event propagation side. No ETAs.

Let's use this issue to track implementation progress so that we can use Issue 516147 as a forum for progress announcements given the number of people that have starred it.

Let's continue with the existing plan to use Windows 10 Anniversary Edition as a baseline - we can decide on bringing a modified experience to older versions of Windows afterwards.

I'll land the first two or three patches to hook it up with our existing notification system, after which Finnur will take over the display side and our Windows team will help out with the event propagation side. No ETAs.

The design doc is https://docs.google.com/document/d/12XgIHmR2-FbFv1Fa4-MlFL_3V2X39WcowjhHvN_YZ7k/edit#

If you want to view this doc, you probably need to register a chromium account.

Let's use this issue to track implementation progress so that we can use Issue 516147 as a forum for progress announcements given the number of people that have starred it.

Let's continue with the existing plan to use Windows 10 Anniversary Edition as a baseline - we can decide on bringing a modified experience to older versions of Windows afterwards.

I'll land the first two or three patches to hook it up with our existing notification system, after which Finnur will take over the display side and our Windows team will help out with the event propagation side. No ETAs.

The design doc is https://docs.google.com/document/d/12XgIHmR2-FbFv1Fa4-MlFL_3V2X39WcowjhHvN_YZ7k/edit#
You probably need to register a chromium account to view this doc.

Showing comments 48 - 147 of 147 Older ›

Project Member

Comment 48 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ca404e17644da5b9afb452366188a1114c93f7

commit 34ca404e17644da5b9afb452366188a1114c93f7
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Feb 23 00:10:12 2018

[Reland] Run notification_helper_unittests on Chromium buildbots

This is a reland of  issue 915016 . The difference between these two CLs
is that this CL removes this unit test from more buildbots which run on
Windows 7 machines. Since this unit test is Windows 8+ only, running it
on those buildbots caused exceptions.

Bug:  734095 ,  813553 
Change-Id: I3b7718a270f08052c81355c36c684156caeb5a1c
Reviewed-on: https://chromium-review.googlesource.com/927107
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538630}
[modify] https://crrev.com/34ca404e17644da5b9afb452366188a1114c93f7/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/34ca404e17644da5b9afb452366188a1114c93f7/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/34ca404e17644da5b9afb452366188a1114c93f7/testing/buildbot/chromium.win.json
[modify] https://crrev.com/34ca404e17644da5b9afb452366188a1114c93f7/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/34ca404e17644da5b9afb452366188a1114c93f7/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/34ca404e17644da5b9afb452366188a1114c93f7/testing/buildbot/test_suites.pyl

Project Member

Comment 49 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ccc758457bea7316db9687f0696ce1fe6d3159c

commit 2ccc758457bea7316db9687f0696ce1fe6d3159c
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Fri Feb 23 20:55:50 2018

Windows Native Notifications: Introduce NotificationLaunchId.

... a class that handles the encoding and decoding of the data
passing back and forth to the Windows Action Center. This also
changes the syntax of the encoded string to use only the pipe
sign (no more $) and introduce a type at the beginning of the
string, which indicates what syntax the rest of the string
follows.

Bug:  734095 
Change-Id: I8d9181ee784ea7d8aae0907af4f3fd1dda68314c
Reviewed-on: https://chromium-review.googlesource.com/932661
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538892}
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/BUILD.gn
[add] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_launch_id.cc
[add] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_launch_id.h
[add] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_launch_id_unittest.cc
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_template_builder.cc
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_template_builder.h
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/browser/notifications/notification_template_builder_unittest.cc
[modify] https://crrev.com/2ccc758457bea7316db9687f0696ce1fe6d3159c/chrome/test/BUILD.gn

Project Member

Comment 50 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c70d2d70dba5b4794b0a81806acce1eb3a321104

commit c70d2d70dba5b4794b0a81806acce1eb3a321104
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Feb 23 23:28:52 2018

Clean up chrome_switches.{h,cc} and move to lib "non_code_constants"

This CL consists of the following changes:
1) Remove function PowerOverlayEnabled() which is not used.
2) Remove function ExtensionsDisabled() which is not used.
3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc,
   which is the only call site.
4) Move chrome_switches.{h,cc} to lib "non_code_constants", as they don't contain any
   functions now.

After this change, including "chrome_switches.h" (and "chrome_constants.h")
only requires a dependence on lib "non_code_constants", rather than lib
"constants" which is overkill.

This applies to notification_helper which only includes "chrome_switches.h"
and "chrome_constants.h" under chrome/common.

Bug:  734095 
Change-Id: I3be5ffff70e9f594989c2058dca0ef109eabf085
Reviewed-on: https://chromium-review.googlesource.com/930368
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538941}
[modify] https://crrev.com/c70d2d70dba5b4794b0a81806acce1eb3a321104/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/c70d2d70dba5b4794b0a81806acce1eb3a321104/chrome/common/BUILD.gn
[modify] https://crrev.com/c70d2d70dba5b4794b0a81806acce1eb3a321104/chrome/common/chrome_switches.cc
[modify] https://crrev.com/c70d2d70dba5b4794b0a81806acce1eb3a321104/chrome/common/chrome_switches.h

Project Member

Comment 51 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25072f82f7cf45bdeaa8e667d8eb4b9445b80f95

commit 25072f82f7cf45bdeaa8e667d8eb4b9445b80f95
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Feb 23 23:41:06 2018

Revert "Clean up chrome_switches.{h,cc} and move to lib "non_code_constants""

This reverts commit c70d2d70dba5b4794b0a81806acce1eb3a321104.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Clean up chrome_switches.{h,cc} and move to lib "non_code_constants"
> 
> This CL consists of the following changes:
> 1) Remove function PowerOverlayEnabled() which is not used.
> 2) Remove function ExtensionsDisabled() which is not used.
> 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc,
>    which is the only call site.
> 4) Move chrome_switches.{h,cc} to lib "non_code_constants", as they don't contain any
>    functions now.
> 
> After this change, including "chrome_switches.h" (and "chrome_constants.h")
> only requires a dependence on lib "non_code_constants", rather than lib
> "constants" which is overkill.
> 
> This applies to notification_helper which only includes "chrome_switches.h"
> and "chrome_constants.h" under chrome/common.
> 
> Bug:  734095 
> Change-Id: I3be5ffff70e9f594989c2058dca0ef109eabf085
> Reviewed-on: https://chromium-review.googlesource.com/930368
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538941}

TBR=sky@chromium.org,chengx@chromium.org

Change-Id: If9a6c26836432e7b857ec350abc9370fac810f7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  734095 
Reviewed-on: https://chromium-review.googlesource.com/935758
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538944}
[modify] https://crrev.com/25072f82f7cf45bdeaa8e667d8eb4b9445b80f95/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/25072f82f7cf45bdeaa8e667d8eb4b9445b80f95/chrome/common/BUILD.gn
[modify] https://crrev.com/25072f82f7cf45bdeaa8e667d8eb4b9445b80f95/chrome/common/chrome_switches.cc
[modify] https://crrev.com/25072f82f7cf45bdeaa8e667d8eb4b9445b80f95/chrome/common/chrome_switches.h

Project Member

Comment 52 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23313de89c4647733df671642c2901ea4c8cac15

commit 23313de89c4647733df671642c2901ea4c8cac15
Author: Xi Cheng <chengx@chromium.org>
Date: Sat Feb 24 04:15:39 2018

[notification_helper.exe] Launch Chrome to handle toast activation

This CL implements NotificationActivator::Activate() which launches Chrome
to handle native notification activation, using a command line with the
--notification-launch-id switch.

Bug:  734095 
Change-Id: I90c67ced93de1f4cc377188e0f414f2d2a9da2a5
Reviewed-on: https://chromium-review.googlesource.com/917821
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538985}
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/browser/notifications/notification_display_service_impl.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/common/chrome_switches.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/chrome/common/chrome_switches.h
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/notification_helper/BUILD.gn
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/notification_helper/DEPS
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/notification_helper/notification_activator.cc
[modify] https://crrev.com/23313de89c4647733df671642c2901ea4c8cac15/tools/metrics/histograms/enums.xml

Project Member

Comment 53 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d2613270f364350b45a2a809dcf5dbe29598fc

commit 97d2613270f364350b45a2a809dcf5dbe29598fc
Author: Xi Cheng <chengx@chromium.org>
Date: Sat Feb 24 08:45:55 2018

Remove obsolete code in notification_platform_bridge_win.h

Bug:  734095 
Change-Id: Ie561eb6c06bbc55c7074335b4867d9061e39b4d0
Reviewed-on: https://chromium-review.googlesource.com/935364
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539005}
[modify] https://crrev.com/97d2613270f364350b45a2a809dcf5dbe29598fc/chrome/browser/notifications/notification_platform_bridge_win.h

Project Member

Comment 54 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f1357adfc5687abdab0be97b7ffdc2931e515f

commit 34f1357adfc5687abdab0be97b7ffdc2931e515f
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Feb 26 17:31:28 2018

Windows Native Notifications: Store arguments on stack.

This prevents a UaF in notification_helper, triggered by
the fact that c_str() points to a deleted string when the
ShellExecute call runs.

TBR: robliao, chengx
Bug:  734095 
Change-Id: I17437368254fb138d1a3fe5db432dba86e30c161
Reviewed-on: https://chromium-review.googlesource.com/937702
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539182}
[modify] https://crrev.com/34f1357adfc5687abdab0be97b7ffdc2931e515f/notification_helper/notification_activator.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d485067dbba1c43d3156c97d2b7b30aac913a3c2

commit d485067dbba1c43d3156c97d2b7b30aac913a3c2
Author: Xi Cheng <chengx@chromium.org>
Date: Mon Feb 26 18:01:52 2018

[Reland] Clean up chrome_switches.{h,cc} and move to lib "non_code_constants"

This is a reland of issue 930368, which has a race condition with the following CL
in the CQ:
https://chromium.googlesource.com/chromium/src/+/6200d332518cd781f87ab86554bc71ff7a01ec4e%5E%21
This CL fixes the race condition by merging that CL.

For chrome_switches.{h,cc}, this CL makes the following changes:
1) Remove function PowerOverlayEnabled() which is not used.
2) Remove function ExtensionsDisabled() which is not used.
3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc,
   which is the only call site.
4) Move them to lib "non_code_constants", as they don't contain any functions now.

Now notification_helper can have a deps on lib "non_code_constants" rather than lib
"constants", hence more lightweight.

Bug:  734095 
Change-Id: I2b5ca5ffa873537c8df21315cd0850b2433dbc4d
Reviewed-on: https://chromium-review.googlesource.com/935826
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539195}
[modify] https://crrev.com/d485067dbba1c43d3156c97d2b7b30aac913a3c2/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/d485067dbba1c43d3156c97d2b7b30aac913a3c2/chrome/common/BUILD.gn
[modify] https://crrev.com/d485067dbba1c43d3156c97d2b7b30aac913a3c2/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d485067dbba1c43d3156c97d2b7b30aac913a3c2/chrome/common/chrome_switches.h
[modify] https://crrev.com/d485067dbba1c43d3156c97d2b7b30aac913a3c2/notification_helper/BUILD.gn

Project Member

Comment 56 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca23dc56b2f90e444b04d8fc72dc9f81835088b

commit 0ca23dc56b2f90e444b04d8fc72dc9f81835088b
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Feb 27 11:07:19 2018

Format ShellExecuteEx call in notification_activator.cc

Bug:  734095 
Change-Id: Ia29c55079a1fa0be50ef2053636b63288c0d92d6
Reviewed-on: https://chromium-review.googlesource.com/938656
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539418}
[modify] https://crrev.com/0ca23dc56b2f90e444b04d8fc72dc9f81835088b/notification_helper/notification_activator.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f9fb5f46e3486edcbf1320b447f0d6c0abfd093

commit 2f9fb5f46e3486edcbf1320b447f0d6c0abfd093
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Feb 27 19:03:17 2018

End-of-line conversion to Unix style

This .ver file in currently in Windows style (CR LF), which should be
converted to Unix style (LF).

Bug:  734095 
Change-Id: I7560924f308ce2e7936c982b049e84e83f35231d
Reviewed-on: https://chromium-review.googlesource.com/938966
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539514}
[modify] https://crrev.com/2f9fb5f46e3486edcbf1320b447f0d6c0abfd093/notification_helper/notification_helper_exe.ver

Comment 58 by chengx@chromium.org, Feb 27 2018

Description: Show this description

Comment 59 by chengx@chromium.org, Feb 27 2018

Description: Show this description

Comment 60 by chengx@chromium.org, Feb 27 2018

Re comment 46:
wenrui@, please find the link to the design doc in the bug description, which is at the very top of this webpage. I think a chromium account is still needed, which you can register one easily.

Comment 61 by chengx@chromium.org, Mar 1 2018

Blockedon: 817974

Project Member

Comment 62 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c830643ee44dc236f77e6b561b45ba697c71d12f

commit c830643ee44dc236f77e6b561b45ba697c71d12f
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Fri Mar 02 21:15:07 2018

Windows Native Notifications: Make sure env setup is correct.

If the COM server is not registered or the properly defined
shortcut is not available, native notifications won't work,
so fall back to non-native notifications.

Bug:  734095 
Change-Id: I739fe5d6a4a066a19b88d4b7a9b45411c91f5963
Reviewed-on: https://chromium-review.googlesource.com/941127
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540626}
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/setup/setup_util.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/setup/setup_util.h
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/setup/setup_util_unittest.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/util/install_util.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/util/install_util.h
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/chrome/installer/util/install_util_unittest.cc
[modify] https://crrev.com/c830643ee44dc236f77e6b561b45ba697c71d12f/notification_helper/notification_helper_process_unittest.cc

Project Member

Comment 63 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e13fa8e454198c8bd0b37e89c63893a2dc9441c0

commit e13fa8e454198c8bd0b37e89c63893a2dc9441c0
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Mar 07 02:07:10 2018

[notification_helper.exe] Add crash reporting support

This CL enables crash reporting for notification_helper.exe by reusing the
crashpad handler embedded in chrome.exe. A new crash reporter client is
implemented for the notification_helper process as in class
NotificationHelperCrashReporterClient.

Bug:  734095 ,  817974 
Change-Id: I279e1d7c8e1741fd09af9db9d4915d69b92e56c9
Reviewed-on: https://chromium-review.googlesource.com/924981
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Jianzhou Feng <jzfeng@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541283}
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/chrome/app/chrome_crash_reporter_client_win.h
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/chrome/installer/setup/installer_crash_reporting.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad.h
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad_mac.mm
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad_win.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/BUILD.gn
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/DEPS
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_activator.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper.cc
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_crash_reporter_client.cc
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_crash_reporter_client.h
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_util.cc
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_util.h

Comment 64 by peter@chromium.org, Mar 7 2018

Blocking: 819675

Project Member

Comment 65 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db89194244321f17037226c74df950279e16b38a

commit db89194244321f17037226c74df950279e16b38a
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Mar 08 15:28:56 2018

Windows Native Notifications: Plumb the Context Menu value through.

This adds support for encoding the launch id for the context menu item,
in a similar way as for the button index (context menu click is treated
by the Action Center as a button click).

This also removes the check for native notifications being enabled
while processing the command line at startup. Main reason for that
is that the notification activator does not enable native notifications
when it passes the command line to Chrome, but native notifications
are already implied anyway (otherwise the notification activator wouldn't
be used). So, we can remove the check.

Bug:  734095 
Change-Id: I629dabaab290fba9043114bf2403daba2b8b7f0c
Reviewed-on: https://chromium-review.googlesource.com/952446
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541800}
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_launch_id.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_launch_id.h
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_launch_id_unittest.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_template_builder.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_template_builder.h
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/notifications/notification_template_builder_unittest.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/db89194244321f17037226c74df950279e16b38a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8207c45b64541a591cf601f4a5b9790b41a0572e

commit 8207c45b64541a591cf601f4a5b9790b41a0572e
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Mar 08 22:11:07 2018

Supply button_index in HandleActivation()

Bug:  734095 
Change-Id: Ib77b7a86351151cdb109fe86bbff291b1519f6c9
Reviewed-on: https://chromium-review.googlesource.com/953082
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541901}
[modify] https://crrev.com/8207c45b64541a591cf601f4a5b9790b41a0572e/chrome/browser/notifications/notification_platform_bridge_win.cc

Project Member

Comment 67 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fcad4939c2de514758faa2d3735a4729af65101

commit 5fcad4939c2de514758faa2d3735a4729af65101
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Mar 08 22:27:33 2018

Windows Native Notifications: Enable flag toggling on Windows.

This allows the user to manually opt into using Windows native
notifications instead of Chrome's version of the notifications.

Note: This flag is ignored on versions of Windows old enough
not to support native notifications.

Bug:  734095 , 516147
Change-Id: Ic5475e6fa13e29207a5d417efc996f16fdf997db
Reviewed-on: https://chromium-review.googlesource.com/955244
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541904}
[modify] https://crrev.com/5fcad4939c2de514758faa2d3735a4729af65101/chrome/browser/about_flags.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66cc022ecbeec821074e825e778a187912317adb

commit 66cc022ecbeec821074e825e778a187912317adb
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Fri Mar 09 14:22:40 2018

Windows Native Notifications: Inline reply.

Bug:  734095 
Change-Id: I87213656fd5e692650d75e8ca7929931bcb54f2d
Reviewed-on: https://chromium-review.googlesource.com/955482
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542100}
[modify] https://crrev.com/66cc022ecbeec821074e825e778a187912317adb/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/66cc022ecbeec821074e825e778a187912317adb/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/66cc022ecbeec821074e825e778a187912317adb/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/66cc022ecbeec821074e825e778a187912317adb/chrome/common/chrome_switches.cc
[modify] https://crrev.com/66cc022ecbeec821074e825e778a187912317adb/chrome/common/chrome_switches.h
[modify] https://crrev.com/66cc022ecbeec821074e825e778a187912317adb/notification_helper/notification_activator.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcd84b82e4654d687f93a4272a4b3233cd80e708

commit bcd84b82e4654d687f93a4272a4b3233cd80e708
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Mar 12 17:44:49 2018

Windows Native Notifications: Fix crash in startup.

The Ready callback passed to SetReadyCallback is executed
on the task runner thread, and not the UI thread.

This causes a crash in startup when launching Chrome.

Also adding a DCHECK to catch this in tests in the
future.

Bug: 820925,  734095 
Change-Id: I59d2b152bbc6538d857f3e6884544217b347885e
Reviewed-on: https://chromium-review.googlesource.com/959017
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542532}
[modify] https://crrev.com/bcd84b82e4654d687f93a4272a4b3233cd80e708/chrome/browser/notifications/notification_display_service_impl.cc
[modify] https://crrev.com/bcd84b82e4654d687f93a4272a4b3233cd80e708/chrome/browser/notifications/notification_platform_bridge_win.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eed7acf526a7b66c989beb1c15ac8d366c7524c2

commit eed7acf526a7b66c989beb1c15ac8d366c7524c2
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Mar 13 00:40:18 2018

Early return when notification_helper.exe is not launched by COM

The notification_helper process is designed to be launched by COM only. For other
launches, it just won't exit until it's killed manually. Therefore, we should make
the process exit immediately once detecting it's not launched by COM.

Bug:  734095 
Change-Id: I0cc23768cf0ec96e8ecbd9b55ab526ba0e1e37c9
Reviewed-on: https://chromium-review.googlesource.com/959347
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542673}
[modify] https://crrev.com/eed7acf526a7b66c989beb1c15ac8d366c7524c2/notification_helper/README.md
[modify] https://crrev.com/eed7acf526a7b66c989beb1c15ac8d366c7524c2/notification_helper/notification_helper.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/490cbadc4d5f5a6533064264998a7f43e5943bb0

commit 490cbadc4d5f5a6533064264998a7f43e5943bb0
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Mar 15 18:52:57 2018

Fix passing activation information from startup to NotificationPlatformBridgeWin

This should fix the issue that notification activation is not working in some cases.

Bug:  734095 ,  821793 
Change-Id: If19f1c802b7da3b1cd0476c0a585138a2d2edcaa
Reviewed-on: https://chromium-review.googlesource.com/963685
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543461}
[modify] https://crrev.com/490cbadc4d5f5a6533064264998a7f43e5943bb0/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/490cbadc4d5f5a6533064264998a7f43e5943bb0/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/490cbadc4d5f5a6533064264998a7f43e5943bb0/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c7bf2301a92281fc7367392848508a77cb7126

commit 78c7bf2301a92281fc7367392848508a77cb7126
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Mar 19 15:31:34 2018

Native Notifications: A bit of cleanup.

Remove helper functions for posting tasks
and a bit of header cleanup.

Note: This was split of from review:
https://chromium-review.googlesource.com/c/chromium/src/+/963685

Bug:  734095 
Change-Id: If3a58f70c1ffcc63c2998adc27eb885f20f8fe46
Reviewed-on: https://chromium-review.googlesource.com/963324
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544038}
[modify] https://crrev.com/78c7bf2301a92281fc7367392848508a77cb7126/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/78c7bf2301a92281fc7367392848508a77cb7126/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/78c7bf2301a92281fc7367392848508a77cb7126/chrome/browser/notifications/notification_platform_bridge_win.h

Project Member

Comment 73 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bfb7e7871b0a516522ccd6caa337056e7e414c9

commit 0bfb7e7871b0a516522ccd6caa337056e7e414c9
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Mar 20 12:26:06 2018

Notifications: Minor cleanup.

Convert ...
  const CallBack& callback
... to ...
  CallBack callback

Bug:  734095 
Change-Id: I96125e214b5337c78763ba304e8a7135cd42b635
Reviewed-on: https://chromium-review.googlesource.com/964327
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544336}
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/chrome_ash_message_center_client.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/chrome_ash_message_center_client.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_display_service_impl.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_display_service_impl.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_display_service_tester.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_android.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_chromeos.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_chromeos.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_linux.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_mac.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_message_center.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_message_center.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/0bfb7e7871b0a516522ccd6caa337056e7e414c9/chrome/browser/notifications/stub_notification_display_service.h

Project Member

Comment 74 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f864095f806ff710559f4ae6445019c3dd81e0f6

commit f864095f806ff710559f4ae6445019c3dd81e0f6
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Mar 20 18:55:38 2018

Fix string encoding for Windows native notification's launch id

Bug:  734095 ,  822183 
Change-Id: I4552f53f66f70e7f90a256187070f96fef02efed
Reviewed-on: https://chromium-review.googlesource.com/965381
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544458}
[modify] https://crrev.com/f864095f806ff710559f4ae6445019c3dd81e0f6/chrome/browser/notifications/notification_launch_id.h
[modify] https://crrev.com/f864095f806ff710559f4ae6445019c3dd81e0f6/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/f864095f806ff710559f4ae6445019c3dd81e0f6/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/f864095f806ff710559f4ae6445019c3dd81e0f6/chrome/browser/ui/startup/startup_browser_creator.cc

Project Member

Comment 75 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d25db2f01ebe5e1b602a2678b24397ac55f9ee

commit 28d25db2f01ebe5e1b602a2678b24397ac55f9ee
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Mar 26 14:11:55 2018

Windows Native Notifications: Add UMA for errors.

Bug:  734095 
Change-Id: Ic65f138b41d76ffddec97eb6ec229e64f612a880
Reviewed-on: https://chromium-review.googlesource.com/970474
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545780}
[modify] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/chrome/browser/BUILD.gn
[modify] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/chrome/browser/notifications/notification_platform_bridge_win.cc
[add] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/chrome/browser/notifications/notification_platform_bridge_win_metrics.cc
[add] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/tools/metrics/histograms/histograms.xml

Project Member

Comment 76 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8ac0347aa8b704251b53f3f318c935b0f6d05a

commit ce8ac0347aa8b704251b53f3f318c935b0f6d05a
Author: Xi Cheng <chengx@chromium.org>
Date: Mon Mar 26 17:39:55 2018

Add test coverage for NotificationPlatformBridgeWin::HandleActivation

Bug:  734095 
Change-Id: I936ce7cba93d5c0d3a895c287325167bb6b8f754
Reviewed-on: https://chromium-review.googlesource.com/978588
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545833}
[modify] https://crrev.com/ce8ac0347aa8b704251b53f3f318c935b0f6d05a/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/264544cf9a7c69c5e7bd56959c639297ed3254ca

commit 264544cf9a7c69c5e7bd56959c639297ed3254ca
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Mar 27 16:10:47 2018

Add test coverage for launching Chrome using notification launch id

This adds test coverage for correctly passing launch id from browser startup
to the notification system when Chrome is launched by the notification_helper
process.

Bug:  734095 
Change-Id: If902781ab49368616857ab72a1fa02f4a9949e2f
Reviewed-on: https://chromium-review.googlesource.com/981198
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546126}
[modify] https://crrev.com/264544cf9a7c69c5e7bd56959c639297ed3254ca/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384abc658c6ffac8b9439c9c4925334b5040f3d0

commit 384abc658c6ffac8b9439c9c4925334b5040f3d0
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Mar 27 18:18:39 2018

Windows Native Notifications: UMA for settings.

Notifications can be disabled for a number of
reasons. This logs those reasons with UMA.

Bug:  734095 
Change-Id: I05e61b287312a42707d78415d2186909fae87fb7
Reviewed-on: https://chromium-review.googlesource.com/980559
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546174}
[modify] https://crrev.com/384abc658c6ffac8b9439c9c4925334b5040f3d0/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/384abc658c6ffac8b9439c9c4925334b5040f3d0/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/384abc658c6ffac8b9439c9c4925334b5040f3d0/tools/metrics/histograms/enums.xml

Project Member

Comment 79 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48adb7367b809e9943430a14814c8b7b3d8c7588

commit 48adb7367b809e9943430a14814c8b7b3d8c7588
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Mar 27 18:53:45 2018

Polish NotificationPlatformBridgeWinImpl::OnDismissed

Bug:  734095 
Change-Id: I688b172764d97c6a759435d227fa8e030bfb82d5
Reviewed-on: https://chromium-review.googlesource.com/979118
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546188}
[modify] https://crrev.com/48adb7367b809e9943430a14814c8b7b3d8c7588/chrome/browser/notifications/notification_platform_bridge_win.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f34bd6f9e7ee01a7babc886dac444efb6c01264d

commit f34bd6f9e7ee01a7babc886dac444efb6c01264d
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Mar 27 19:19:20 2018

Implement NotificationPlatformBridgeWinImpl::OnFailed

Bug:  734095 
Change-Id: Ie7226ab3811c7615ab7a077a243f744effa4ca5e
Reviewed-on: https://chromium-review.googlesource.com/979115
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546198}
[modify] https://crrev.com/f34bd6f9e7ee01a7babc886dac444efb6c01264d/chrome/browser/notifications/notification_platform_bridge_win.cc

Project Member

Comment 81 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235e98888e5588d215db94d8730020c4fc6f1f9d

commit 235e98888e5588d215db94d8730020c4fc6f1f9d
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Mar 30 01:10:00 2018

[notification_helper.exe] Add UMA support and log its runtime

Since notification_helper is a standalone executable, adding UMA support for
it needs extra work. We need to create persistent histograms in memory and
write the memory to a file upon exit of the process. These files are
accumulated inside a new directory called NotificationHelperMetrics under User
Data directory, and will eventually be reported by the browser process.

This CL moves persistent_histogram_storage.{h,cc} from chrome/installer/setup
to base/metrics as the class is now also used by notification_helper.exe, in
addition to setup.exe. This CL updates this class for general-purpose usage,
and adds unit tests for it.

This CL also logs the runtime of the notification_helper process to UMA.

Bug:  734095 
Change-Id: Ia95f002378718b0e033f8da1aa7c260ec04030c3
Reviewed-on: https://chromium-review.googlesource.com/959543
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547052}
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/base/BUILD.gn
[add] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/base/metrics/persistent_histogram_storage.cc
[add] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/base/metrics/persistent_histogram_storage.h
[add] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/base/metrics/persistent_histogram_storage_unittest.cc
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/chrome/installer/setup/BUILD.gn
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/chrome/installer/setup/install_worker.cc
[delete] https://crrev.com/8ec33b0423eea487835bdc9a1574a454ab4555ee/chrome/installer/setup/persistent_histogram_storage.cc
[delete] https://crrev.com/8ec33b0423eea487835bdc9a1574a454ab4555ee/chrome/installer/setup/persistent_histogram_storage.h
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/notification_helper/notification_helper.cc
[modify] https://crrev.com/235e98888e5588d215db94d8730020c4fc6f1f9d/tools/metrics/histograms/histograms.xml

Project Member

Comment 82 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d0cc288be00b92b4aef18974718ff46949dfeaa

commit 3d0cc288be00b92b4aef18974718ff46949dfeaa
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Mar 30 19:31:16 2018

Revert "Windows Native Notifications: UMA for settings."

This reverts commit 384abc658c6ffac8b9439c9c4925334b5040f3d0.

Reason for revert: The method call notifier_->get_Setting(&setting) failed which caused the native notification feature not to work. 

Original change's description:
> Windows Native Notifications: UMA for settings.
> 
> Notifications can be disabled for a number of
> reasons. This logs those reasons with UMA.
> 
> Bug:  734095 
> Change-Id: I05e61b287312a42707d78415d2186909fae87fb7
> Reviewed-on: https://chromium-review.googlesource.com/980559
> Reviewed-by: Xi Cheng <chengx@chromium.org>
> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546174}

TBR=finnur@chromium.org,chengx@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  734095 
Change-Id: I5ce33af6cc6657c3bd4ce093a449f7dc4aacff84
Reviewed-on: https://chromium-review.googlesource.com/988173
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547240}
[modify] https://crrev.com/3d0cc288be00b92b4aef18974718ff46949dfeaa/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/3d0cc288be00b92b4aef18974718ff46949dfeaa/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/3d0cc288be00b92b4aef18974718ff46949dfeaa/tools/metrics/histograms/enums.xml

Project Member

Comment 83 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82729d7823cb5333a3cce66e0f388cd49cdc89ec

commit 82729d7823cb5333a3cce66e0f388cd49cdc89ec
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Mar 30 22:43:44 2018

Log ComServerModule execute status to UMA

Bug:  734095 
Change-Id: I95a81a14b46c80b852e80552b00920866bcb9b3c
Reviewed-on: https://chromium-review.googlesource.com/988303
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547297}
[modify] https://crrev.com/82729d7823cb5333a3cce66e0f388cd49cdc89ec/notification_helper/com_server_module.cc
[modify] https://crrev.com/82729d7823cb5333a3cce66e0f388cd49cdc89ec/notification_helper/com_server_module.h
[modify] https://crrev.com/82729d7823cb5333a3cce66e0f388cd49cdc89ec/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/82729d7823cb5333a3cce66e0f388cd49cdc89ec/tools/metrics/histograms/histograms.xml

Project Member

Comment 84 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4489ddf53a5202eb21fbf93c6d07dfa496e5b3e3

commit 4489ddf53a5202eb21fbf93c6d07dfa496e5b3e3
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Apr 03 16:24:58 2018

Make launch id valid in NPBW unittest

Bug:  734095 
Change-Id: I0ad44050d97f942e5cebf4d9f302ce74f4527b34
Reviewed-on: https://chromium-review.googlesource.com/990574
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547729}
[modify] https://crrev.com/4489ddf53a5202eb21fbf93c6d07dfa496e5b3e3/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc

Project Member

Comment 85 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b7447db9451e4dcfade274aebd8b49675245e2

commit 85b7447db9451e4dcfade274aebd8b49675245e2
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Apr 03 16:55:53 2018

Add test coverage for NotificationPlatformBridgeWin::GetProfileIdFromLaunchId

Bug:  734095 
Change-Id: Iefbf6199c442ce15104e9afbc449ae910d620079
Reviewed-on: https://chromium-review.googlesource.com/989833
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547735}
[modify] https://crrev.com/85b7447db9451e4dcfade274aebd8b49675245e2/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc

Project Member

Comment 86 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f75b204be5dd86dce3a19e25986a7a9c1d2d6a56

commit f75b204be5dd86dce3a19e25986a7a9c1d2d6a56
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 04 02:15:11 2018

Improve persistent histogram storage's usage in uninstall and crashpad

Disable histogram persistence during uninstall since there's neither a directory
in which to write them nor a browser to subsequently upload them. This allows
to add LOG(ERROR) without breaking the installation tests when it detects the
storage directory does not exist.

Also, do not attempt to store histograms from setup.exe executions dedicated to
crashpad. Otherwise, this will trigger LOG(ERROR) in the destructor of class
PersistentHistogramStorage.

Bug:  734095 
Change-Id: Iffff0fab25eedb7f934144802e805ba2d047a42a
Reviewed-on: https://chromium-review.googlesource.com/987541
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547957}
[modify] https://crrev.com/f75b204be5dd86dce3a19e25986a7a9c1d2d6a56/base/metrics/persistent_histogram_storage.cc
[modify] https://crrev.com/f75b204be5dd86dce3a19e25986a7a9c1d2d6a56/base/metrics/persistent_histogram_storage.h
[modify] https://crrev.com/f75b204be5dd86dce3a19e25986a7a9c1d2d6a56/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/f75b204be5dd86dce3a19e25986a7a9c1d2d6a56/notification_helper/notification_helper.cc

Project Member

Comment 87 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4693a267d5360100d8669f076ccb6d01ca474a20

commit 4693a267d5360100d8669f076ccb6d01ca474a20
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 04 16:57:23 2018

Clean up notification_platform_bridge_win.{h,cc} and related tests

... mostly by removing the inclusion of redundant header files.

Bug:  734095 
Change-Id: Ibed243cbdedba4499a6e62f2b79d31cdbf77b535
Reviewed-on: https://chromium-review.googlesource.com/989396
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548100}
[modify] https://crrev.com/4693a267d5360100d8669f076ccb6d01ca474a20/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/4693a267d5360100d8669f076ccb6d01ca474a20/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/4693a267d5360100d8669f076ccb6d01ca474a20/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[modify] https://crrev.com/4693a267d5360100d8669f076ccb6d01ca474a20/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc

Project Member

Comment 88 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f0b44fa19dc8ef59e74ba5abf6d2a3616f79ef

commit 29f0b44fa19dc8ef59e74ba5abf6d2a3616f79ef
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 04 18:33:14 2018

Start crashpad as early as possible in notification_helper.exe

Bug:  734095 
Change-Id: Id6812f667fffe493e5f846e59fa7783d104bb930
Reviewed-on: https://chromium-review.googlesource.com/993399
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548135}
[modify] https://crrev.com/29f0b44fa19dc8ef59e74ba5abf6d2a3616f79ef/notification_helper/notification_helper.cc

Project Member

Comment 89 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab9d3399d588ae6a7626ae57a6efd0262a811ac7

commit ab9d3399d588ae6a7626ae57a6efd0262a811ac7
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Apr 05 01:44:14 2018

Windows Native Notifications: UMA for settings.

Notifications can be disabled for a number of
reasons. This logs those reasons with UMA.

This is a retry of my earlier CL, but does
not abort if getting settings failed (not
a fatal failure anyway).

Bug:  734095 
Change-Id: I9a04f666e8181d87fd945fcdcac0c3a0371aa2f0
Reviewed-on: https://chromium-review.googlesource.com/995536
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548287}
[modify] https://crrev.com/ab9d3399d588ae6a7626ae57a6efd0262a811ac7/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/ab9d3399d588ae6a7626ae57a6efd0262a811ac7/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/ab9d3399d588ae6a7626ae57a6efd0262a811ac7/tools/metrics/histograms/enums.xml

Comment 90 by travismc...@gmail.com, Apr 5 2018

The flag disappeared after a reinstall. Did you guys remove it? 😡

Project Member

Comment 91 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7588992ff17348b0c9d74201f7fd4b605237d80

commit d7588992ff17348b0c9d74201f7fd4b605237d80
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Apr 06 02:40:48 2018

Remove notification_helper's deps on chrome/installer/setup

This dependence is unnecessary so remove it.

Bug:  734095 
Change-Id: Ibadaab346553f3d842ecc371328bf624583f25ec
Reviewed-on: https://chromium-review.googlesource.com/999039
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548646}
[modify] https://crrev.com/d7588992ff17348b0c9d74201f7fd4b605237d80/notification_helper/BUILD.gn
[modify] https://crrev.com/d7588992ff17348b0c9d74201f7fd4b605237d80/notification_helper/DEPS
[modify] https://crrev.com/d7588992ff17348b0c9d74201f7fd4b605237d80/notification_helper/notification_helper_process_unittest.cc

Comment 92 by finnur@chromium.org, Apr 6 2018

@90: No, not to my knowledge. 

Note though that this is not the place to attach new bug reports. If you have an issue you can file a new bug.

Project Member

Comment 93 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e8c8f571f4a09349db64f0f013eb8274b10c8c4

commit 8e8c8f571f4a09349db64f0f013eb8274b10c8c4
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Apr 06 18:18:20 2018

Tweaks on persistent histogram storage's implementation and usage

Bug:  734095 
Change-Id: Ia832d7b3b176d90d4c5d618ac169ad0cc5fe8a72
Reviewed-on: https://chromium-review.googlesource.com/996455
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548861}
[modify] https://crrev.com/8e8c8f571f4a09349db64f0f013eb8274b10c8c4/base/metrics/persistent_histogram_storage.cc
[modify] https://crrev.com/8e8c8f571f4a09349db64f0f013eb8274b10c8c4/base/metrics/persistent_histogram_storage.h
[modify] https://crrev.com/8e8c8f571f4a09349db64f0f013eb8274b10c8c4/base/metrics/persistent_histogram_storage_unittest.cc
[modify] https://crrev.com/8e8c8f571f4a09349db64f0f013eb8274b10c8c4/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/8e8c8f571f4a09349db64f0f013eb8274b10c8c4/notification_helper/notification_helper.cc

Project Member

Comment 94 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07c0beaeaad3850591584afeb52bddaa96e5b5da

commit 07c0beaeaad3850591584afeb52bddaa96e5b5da
Author: Xi Cheng <chengx@chromium.org>
Date: Sat Apr 07 04:45:08 2018

Log event handling status for OnDismissed and OnFailed

Bug:  734095 
Change-Id: I57fc9564417e3491275e92c90531b02b04b11a40
Reviewed-on: https://chromium-review.googlesource.com/996634
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549036}
[modify] https://crrev.com/07c0beaeaad3850591584afeb52bddaa96e5b5da/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/07c0beaeaad3850591584afeb52bddaa96e5b5da/chrome/browser/notifications/notification_platform_bridge_win_metrics.cc
[modify] https://crrev.com/07c0beaeaad3850591584afeb52bddaa96e5b5da/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/07c0beaeaad3850591584afeb52bddaa96e5b5da/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/07c0beaeaad3850591584afeb52bddaa96e5b5da/tools/metrics/histograms/histograms.xml

Project Member

Comment 95 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77be1ee0bc236c898b4eb49d18f6d0da0cd38840

commit 77be1ee0bc236c898b4eb49d18f6d0da0cd38840
Author: Xi Cheng <chengx@chromium.org>
Date: Mon Apr 09 22:35:56 2018

Polish notification_helper_process_unittests

Bug:  734095 
Change-Id: I0bac9ecbaedad6d39a16b04442a361b22d45fcfd
Reviewed-on: https://chromium-review.googlesource.com/1002542
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549306}
[modify] https://crrev.com/77be1ee0bc236c898b4eb49d18f6d0da0cd38840/notification_helper/notification_helper_process_unittest.cc

Project Member

Comment 96 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75bf65e4b1e7690b735eb3bb043e9dbacb7b320d

commit 75bf65e4b1e7690b735eb3bb043e9dbacb7b320d
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 11 03:12:12 2018

More tweaks on notification_helper_process_unittest

Bug:  734095 
Change-Id: Ied1ecf1351b951d4e9c810aab7da4ac1e8d85520
Reviewed-on: https://chromium-review.googlesource.com/1005365
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549741}
[modify] https://crrev.com/75bf65e4b1e7690b735eb3bb043e9dbacb7b320d/notification_helper/notification_helper_process_unittest.cc

Project Member

Comment 97 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d71124c573c03895699ccc3cb4154c7cca6e8c99

commit d71124c573c03895699ccc3cb4154c7cca6e8c99
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Apr 11 12:05:42 2018

Windows Native Notifications: Add test coverage for HandleActivation.

Bug:  734095 
Change-Id: I01e5d3c8bd133d8914fd64626494d12531dbcf37
Reviewed-on: https://chromium-review.googlesource.com/955596
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549863}
[modify] https://crrev.com/d71124c573c03895699ccc3cb4154c7cca6e8c99/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[modify] https://crrev.com/d71124c573c03895699ccc3cb4154c7cca6e8c99/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc

Project Member

Comment 98 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a54940fa5f5ee07f1119b97e17499a8b35577c2

commit 8a54940fa5f5ee07f1119b97e17499a8b35577c2
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Apr 16 16:14:50 2018

Win Native Notifications: Add UMA for getSettings call.

Bug:  734095 
Change-Id: I3a7e869ca908e53436ff3e78f43f13af1dccedce
Reviewed-on: https://chromium-review.googlesource.com/998032
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550986}
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/chrome/browser/notifications/notification_platform_bridge_win_metrics.cc
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/tools/metrics/histograms/histograms.xml

Project Member

Comment 99 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66d2b45bd08fa43a7ec18814660d50c63836e972

commit 66d2b45bd08fa43a7ec18814660d50c63836e972
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Apr 17 13:03:10 2018

Win Native Notifications: Log get_Setting results separately
from the Display status and make it informational only (not
abort the call).

Bug:  734095 
Change-Id: Id55c2c32a077d27ae06b11ee36241df5ee5a8318
Reviewed-on: https://chromium-review.googlesource.com/1007278
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551305}
[modify] https://crrev.com/66d2b45bd08fa43a7ec18814660d50c63836e972/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/66d2b45bd08fa43a7ec18814660d50c63836e972/chrome/browser/notifications/notification_platform_bridge_win_metrics.cc
[modify] https://crrev.com/66d2b45bd08fa43a7ec18814660d50c63836e972/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/66d2b45bd08fa43a7ec18814660d50c63836e972/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/66d2b45bd08fa43a7ec18814660d50c63836e972/tools/metrics/histograms/histograms.xml

Project Member

Comment 100 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a54940fa5f5ee07f1119b97e17499a8b35577c2

commit 8a54940fa5f5ee07f1119b97e17499a8b35577c2
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Apr 16 16:14:50 2018

Win Native Notifications: Add UMA for getSettings call.

Bug:  734095 
Change-Id: I3a7e869ca908e53436ff3e78f43f13af1dccedce
Reviewed-on: https://chromium-review.googlesource.com/998032
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550986}
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/chrome/browser/notifications/notification_platform_bridge_win_metrics.cc
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8a54940fa5f5ee07f1119b97e17499a8b35577c2/tools/metrics/histograms/histograms.xml

Project Member

Comment 101 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af44f46e84c3f659feddbdf0e0cf2144a75bda9b

commit af44f46e84c3f659feddbdf0e0cf2144a75bda9b
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 18 00:47:26 2018

Add test coverage for NotificationActivator::Activate in notification_helper

We introduce notification_helper_launches_chrome_unittest, which is evolution
of notification_helper_process_unittest. In addition to testing the launch of
notification_helper by the OS which is notification_helper_process_unittest
all about, the new unit test also tests if chrome.exe can be successfully
launched by notification_helper.exe via the NotificationActivator::Activate
function.

This new unit test is compiled into unit_tests.exe under chrome rather than
notification_helper_unittests.exe. This is because unit_tests.exe has data
dependency on chrome.exe which is required by this new unit test, and it's
undesired to make notification_helper_unittests.exe have data dependency on
chrome.exe.

Bug:  734095 
Change-Id: I07ac90a84d7f885a359867f79ce613a194e0bb64
Reviewed-on: https://chromium-review.googlesource.com/1002132
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551540}
[modify] https://crrev.com/af44f46e84c3f659feddbdf0e0cf2144a75bda9b/chrome/browser/notifications/OWNERS
[add] https://crrev.com/af44f46e84c3f659feddbdf0e0cf2144a75bda9b/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc
[modify] https://crrev.com/af44f46e84c3f659feddbdf0e0cf2144a75bda9b/chrome/test/BUILD.gn

Project Member

Comment 102 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02df6ab3df7084903033394f89d9435f34b57384

commit 02df6ab3df7084903033394f89d9435f34b57384
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 18 06:27:14 2018

Add file comments to link two notification_helper related tests

... because they have quite different file locations due to data
dependency restriction.

Bug:  734095 
Change-Id: I737e7a9f7edc3fb12ef14ccd025ff0afc6688535
Reviewed-on: https://chromium-review.googlesource.com/1013096
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551595}
[modify] https://crrev.com/02df6ab3df7084903033394f89d9435f34b57384/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc
[modify] https://crrev.com/02df6ab3df7084903033394f89d9435f34b57384/notification_helper/notification_helper_process_unittest.cc

Project Member

Comment 103 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be471526132c18c0b11b655d94e7d0c9145ce3fc

commit be471526132c18c0b11b655d94e7d0c9145ce3fc
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Apr 18 12:33:41 2018

Win Native Notifications: Add test coverage for Display path.

This creates a mock ToastNotifier, which replaces the Windows
Action Center and allows us to validate that the values sent
over are as expected.

BUG:  734095 
Change-Id: Ibaee2fa161d9025c4b747a75943e5e20d3abffc8
Reviewed-on: https://chromium-review.googlesource.com/1003155
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551642}
[modify] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/BUILD.gn
[modify] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/OWNERS
[add] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/mock_itoastnotifier.cc
[add] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/mock_itoastnotifier.h
[modify] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[add] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/notification_platform_bridge_win_util.cc
[add] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/browser/notifications/notification_platform_bridge_win_util.h
[modify] https://crrev.com/be471526132c18c0b11b655d94e7d0c9145ce3fc/chrome/test/BUILD.gn

Project Member

Comment 104 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afa390e43c2b883d4e5d9fec1521e76546deb8be

commit afa390e43c2b883d4e5d9fec1521e76546deb8be
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Apr 19 21:20:59 2018

Make profile id in kNotificationLaunchId take precedence over kProfileDirectory

If the command line has both switches, the profile id in kNotificationLaunchId should
be chosen over that in kProfileDirectory.

Bug:  734095 
Change-Id: Ifeb693414a50f7e865c808ba75ce99d3e7db4733
Reviewed-on: https://chromium-review.googlesource.com/1018100
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552159}
[modify] https://crrev.com/afa390e43c2b883d4e5d9fec1521e76546deb8be/chrome/browser/ui/startup/startup_browser_creator.cc

Project Member

Comment 105 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9b8270a64dc81be573382d16f345d76cf53ee8

commit 8f9b8270a64dc81be573382d16f345d76cf53ee8
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Apr 20 18:49:34 2018

Dedup notification_helper OS registration code -- part 1

This makes notification_helper_process_unittest.cc reuse the code in
install_worker.*

Bug:  734095 
Change-Id: I058971502e3681244e034de413acb891758045ba
Reviewed-on: https://chromium-review.googlesource.com/1014328
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552411}
[modify] https://crrev.com/8f9b8270a64dc81be573382d16f345d76cf53ee8/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/8f9b8270a64dc81be573382d16f345d76cf53ee8/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/8f9b8270a64dc81be573382d16f345d76cf53ee8/notification_helper/BUILD.gn
[modify] https://crrev.com/8f9b8270a64dc81be573382d16f345d76cf53ee8/notification_helper/DEPS
[modify] https://crrev.com/8f9b8270a64dc81be573382d16f345d76cf53ee8/notification_helper/notification_helper_process_unittest.cc

Project Member

Comment 106 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eb46ecf2375dcafb3739ef98e73657b8c5fc89d

commit 8eb46ecf2375dcafb3739ef98e73657b8c5fc89d
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Apr 23 16:51:42 2018

Win Native Notifications: Minor test cleanup.

Bug:  734095 
Change-Id: If429e9c97875e0a53242f2192f960e1def009667
Reviewed-on: https://chromium-review.googlesource.com/1024041
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552731}
[modify] https://crrev.com/8eb46ecf2375dcafb3739ef98e73657b8c5fc89d/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc

Project Member

Comment 107 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/850001f395fe619b3add0fdb80a1cfbd7d32df01

commit 850001f395fe619b3add0fdb80a1cfbd7d32df01
Author: Xi Cheng <chengx@chromium.org>
Date: Mon Apr 23 18:34:25 2018

Move notification_helper/ to chrome/notification_helper/

... plus all the necessary code migration. A follow-up CL will be used
to update relevant comments.

Bug:  734095 
Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b
Reviewed-on: https://chromium-review.googlesource.com/1022957
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552762}
[modify] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/BUILD.gn
[modify] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/WATCHLISTS
[modify] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/BUILD.gn
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/BUILD.gn
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/DEPS
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/OWNERS
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/README.md
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/com_server_module.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/com_server_module.h
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/com_server_module_unittest.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_activator.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_activator.h
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper.rc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper_crash_reporter_client.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper_crash_reporter_client.h
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper_exe.ver
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper_process_unittest.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper_util.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/notification_helper_util.h
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/run_all_unittests.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/trace_util.cc
[rename] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/notification_helper/trace_util.h
[modify] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/chrome/test/BUILD.gn
[modify] https://crrev.com/850001f395fe619b3add0fdb80a1cfbd7d32df01/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 108 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b372f1d8d371f231b4f8e3dce511f8a5917b854d

commit b372f1d8d371f231b4f8e3dce511f8a5917b854d
Author: Xi Cheng <chengx@chromium.org>
Date: Mon Apr 23 19:16:07 2018

Revert "Move notification_helper/ to chrome/notification_helper/"

This reverts commit 850001f395fe619b3add0fdb80a1cfbd7d32df01.

Reason for revert: <file://notification_helper/OWNERS is referenced in chrome/browser/notifications/OWNERS. After moving this folder, the file is gone which creates a deadlock for "git cl upload".>

Original change's description:
> Move notification_helper/ to chrome/notification_helper/
> 
> ... plus all the necessary code migration. A follow-up CL will be used
> to update relevant comments.
> 
> Bug:  734095 
> Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b
> Reviewed-on: https://chromium-review.googlesource.com/1022957
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552762}

TBR=jam@chromium.org,chengx@chromium.org

Change-Id: Idc75aa458afeaf6c7fe5d36c85c76c60947c0687
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  734095 
Reviewed-on: https://chromium-review.googlesource.com/1024590
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552785}
[modify] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/BUILD.gn
[modify] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/WATCHLISTS
[modify] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/chrome/BUILD.gn
[modify] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/chrome/test/BUILD.gn
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/BUILD.gn
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/DEPS
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/OWNERS
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/README.md
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/com_server_module.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/com_server_module.h
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/com_server_module_unittest.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_activator.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_activator.h
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper.rc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper_crash_reporter_client.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper_crash_reporter_client.h
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper_exe.ver
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper_process_unittest.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper_util.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/notification_helper_util.h
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/run_all_unittests.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/trace_util.cc
[rename] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/notification_helper/trace_util.h
[modify] https://crrev.com/b372f1d8d371f231b4f8e3dce511f8a5917b854d/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 109 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d47af34de93b83534846542feb5da5403ae64e8f

commit d47af34de93b83534846542feb5da5403ae64e8f
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Apr 24 02:36:33 2018

Reland "Move notification_helper/ to chrome/notification_helper/"

This is a reland of 850001f395fe619b3add0fdb80a1cfbd7d32df01, which caused
a pre-submit deadlock for chrome/browser/notifications/OWNERS.

This is now safe to land as the following CL has been landed:
https://chromium-review.googlesource.com/c/chromium/src/+/1024633

Original change's description:
> Move notification_helper/ to chrome/notification_helper/
>
> ... plus all the necessary code migration. A follow-up CL will be used
> to update relevant comments.
>
> Bug:  734095 
> Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b
> Reviewed-on: https://chromium-review.googlesource.com/1022957
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552762}

Bug:  734095 
Change-Id: Id4e0818d7e3ea2b0ea7633e883bc5cea42705167
Reviewed-on: https://chromium-review.googlesource.com/1024744
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552971}
[modify] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/BUILD.gn
[modify] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/WATCHLISTS
[modify] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/BUILD.gn
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/BUILD.gn
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/DEPS
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/OWNERS
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/README.md
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/com_server_module.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/com_server_module.h
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/com_server_module_unittest.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_activator.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_activator.h
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper.rc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper_crash_reporter_client.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper_crash_reporter_client.h
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper_exe.ver
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper_process_unittest.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper_util.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/notification_helper_util.h
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/run_all_unittests.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/trace_util.cc
[rename] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/notification_helper/trace_util.h
[modify] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/chrome/test/BUILD.gn
[modify] https://crrev.com/d47af34de93b83534846542feb5da5403ae64e8f/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 110 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8854dd178f1a475200c52c254825117a76d010

commit 2c8854dd178f1a475200c52c254825117a76d010
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Apr 24 14:59:04 2018

Win Native Notifications: Add profile id and incognito status to hashed tag.

Also fix a parameter mismatch in the Close function.

Bug:  834101 ,  826817 ,  734095 
Change-Id: I94bef0defae6c7179605db23bfc8ff0020433f75
Reviewed-on: https://chromium-review.googlesource.com/1023231
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553105}
[modify] https://crrev.com/2c8854dd178f1a475200c52c254825117a76d010/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/2c8854dd178f1a475200c52c254825117a76d010/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/2c8854dd178f1a475200c52c254825117a76d010/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc

Project Member

Comment 111 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c35726b2d64cea420b700c0c0938bd0713d0ac

commit b7c35726b2d64cea420b700c0c0938bd0713d0ac
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Apr 25 04:55:14 2018

Introduce notification_helper_constants.* to improve code consistency

Bug:  734095 
Change-Id: Idf5637bb57a7cbfb0b5831cf99e45806d8a9abc6
Reviewed-on: https://chromium-review.googlesource.com/1026972
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553451}
[modify] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/browser/BUILD.gn
[modify] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/browser/DEPS
[modify] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/notification_helper/BUILD.gn
[modify] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/notification_helper/notification_helper.cc
[add] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/notification_helper/notification_helper_constants.cc
[add] https://crrev.com/b7c35726b2d64cea420b700c0c0938bd0713d0ac/chrome/notification_helper/notification_helper_constants.h

Project Member

Comment 112 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37ae0ba4f193a38c061c6e5eac09135664aaf341

commit 37ae0ba4f193a38c061c6e5eac09135664aaf341
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Apr 26 17:52:39 2018

Update chrome/browser/notifications/OWNERS to ref another OWNERS file

Bug:  734095 
Change-Id: Ic642eb558061604583ce425ee1ad38615c6d46de
Reviewed-on: https://chromium-review.googlesource.com/1028993
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554075}
[modify] https://crrev.com/37ae0ba4f193a38c061c6e5eac09135664aaf341/chrome/browser/notifications/OWNERS

Project Member

Comment 113 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca393f861a7aaa10a2d85a55836752c073974d5c

commit ca393f861a7aaa10a2d85a55836752c073974d5c
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Apr 26 18:42:12 2018

Dedup notification_helper OS registration code -- part 2

This CL consists of the following changes:

1) Make notification_helper_launches_chrome_unittest.cc reuse the code in
   install_worker.*
2) chrome/installer/setup:lib does not need a dependency on
   //content/public/common:static_switches. This dependency also prevents
   chrome/installer/setup:lib from being added to the deps list of
   unit_tests build target.
3) Simplify registry restoration by replacing RegistryKeyBackup with
   WorkItemList.RollBack().
4) Delete both old 32-bit and 64-bit registries in the tests so that we
   can make sure Windows uses the test's registration.

Bug:  734095 
Change-Id: Ie349555ec1da93a8d3bfd04f977344bcc9533087
Reviewed-on: https://chromium-review.googlesource.com/1021798
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554099}
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/browser/notifications/DEPS
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/installer/setup/BUILD.gn
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/installer/setup/install_worker.h
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/installer/setup/setup_util.cc
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/installer/setup/setup_util.h
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/notification_helper/notification_helper_process_unittest.cc
[modify] https://crrev.com/ca393f861a7aaa10a2d85a55836752c073974d5c/chrome/test/BUILD.gn

Project Member

Comment 114 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4c327a66bf2628085047b311ff9b5ef540e418

commit 4a4c327a66bf2628085047b311ff9b5ef540e418
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Apr 26 22:35:46 2018

Not show profile picker when chrome's launched by notification activation

In this case, always use |last_used_profile| which contains the profile id
extracted from the notification launch id, rather than |last_opened_profiles|.

Bug:  833663 ,  734095 
Change-Id: I1f8721ba1dcb7b7ab60264dfcae873f664d8121e
Reviewed-on: https://chromium-review.googlesource.com/1031010
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554175}
[modify] https://crrev.com/4a4c327a66bf2628085047b311ff9b5ef540e418/chrome/browser/ui/startup/startup_browser_creator.cc

Project Member

Comment 115 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c68c6d9c9cf2c1aaf0b91dfb7c0be4dbb3761f0

commit 8c68c6d9c9cf2c1aaf0b91dfb7c0be4dbb3761f0
Author: Xi Cheng <chengx@chromium.org>
Date: Tue May 01 17:46:24 2018

Use ScopedCOMInitializer instead of ScopedWinrtInitializer

... as Windows Runtime is not needed in ComServerModuleTest.

Bug:  734095 
Change-Id: I9ab37ecb500375f6b5c7bae47a684dbffcd5475a
Reviewed-on: https://chromium-review.googlesource.com/1036480
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555098}
[modify] https://crrev.com/8c68c6d9c9cf2c1aaf0b91dfb7c0be4dbb3761f0/chrome/notification_helper/com_server_module_unittest.cc

Project Member

Comment 116 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dd94398bc1f0e9750018637b492ce98e085cf89

commit 5dd94398bc1f0e9750018637b492ce98e085cf89
Author: Xi Cheng <chengx@chromium.org>
Date: Wed May 02 03:16:09 2018

Make kNotificationLaunchId take precedence over kProfileDirectory

... in CreatePrimaryProfile(). This is consistent with the logic in
GetStartupProfilePath() in startup_browser_creator.cc file.

Bug:  734095 ,  833663 
Change-Id: Ic74bf5af947d0ef75006169676ed3bfcad7cde91
Reviewed-on: https://chromium-review.googlesource.com/1037930
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555298}
[modify] https://crrev.com/5dd94398bc1f0e9750018637b492ce98e085cf89/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/5dd94398bc1f0e9750018637b492ce98e085cf89/chrome/browser/ui/startup/startup_browser_creator.cc

Project Member

Comment 117 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6975e7ccc3e471372dc8ca68e8ca08cb12fd9cd8

commit 6975e7ccc3e471372dc8ca68e8ca08cb12fd9cd8
Author: Xi Cheng <chengx@chromium.org>
Date: Thu May 03 21:18:06 2018

Enable StartupBrowserCreatorTest.*NotificationId on Win7 bots

These tests can run on Win7 machines so enable them.

Bug:  734095 
Change-Id: Idcd8e426feaf1202e544db2793a50f3574bdaaed
Reviewed-on: https://chromium-review.googlesource.com/1041154
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555872}
[modify] https://crrev.com/6975e7ccc3e471372dc8ca68e8ca08cb12fd9cd8/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Project Member

Comment 118 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c721c6d43cc9a77e4e4557bba52ebe1f78a8c4f8

commit c721c6d43cc9a77e4e4557bba52ebe1f78a8c4f8
Author: Xi Cheng <chengx@chromium.org>
Date: Thu May 03 21:22:39 2018

Add StartupBrowserCreatorTest.NotificationLaunchIdDisablesLastOpenProfiles

This covers the code added in crrev/c/1031010.

Bug:  833663 ,  734095 
Change-Id: Iea3502b3543d076d6dc3285bea6e229320a2b980
Reviewed-on: https://chromium-review.googlesource.com/1040739
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555876}
[modify] https://crrev.com/c721c6d43cc9a77e4e4557bba52ebe1f78a8c4f8/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/c721c6d43cc9a77e4e4557bba52ebe1f78a8c4f8/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Project Member

Comment 119 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44e2fc52cb3cc13a92ca381d005ec86bdde8232e

commit 44e2fc52cb3cc13a92ca381d005ec86bdde8232e
Author: Xi Cheng <chengx@chromium.org>
Date: Fri May 04 04:43:24 2018

Make sure kNotificationId and kAppId are mutual exclusive on Windows

Bug:  734095 
Change-Id: I08275fff11aef97c3265a6832dc1485b4ef19b61
Reviewed-on: https://chromium-review.googlesource.com/1038432
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555986}
[modify] https://crrev.com/44e2fc52cb3cc13a92ca381d005ec86bdde8232e/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Project Member

Comment 120 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e82edb257d2c687861e79174bea4cd07b9b03f

commit 71e82edb257d2c687861e79174bea4cd07b9b03f
Author: Xi Cheng <chengx@chromium.org>
Date: Fri May 04 16:40:51 2018

Revert "Make sure kNotificationId and kAppId are mutual exclusive on Windows"

This reverts commit 44e2fc52cb3cc13a92ca381d005ec86bdde8232e.

Reason for revert: <CL title/description is inaccurate>

Original change's description:
> Make sure kNotificationId and kAppId are mutual exclusive on Windows
> 
> Bug:  734095 
> Change-Id: I08275fff11aef97c3265a6832dc1485b4ef19b61
> Reviewed-on: https://chromium-review.googlesource.com/1038432
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555986}

TBR=tmartino@chromium.org,chengx@chromium.org

Change-Id: I050712e720d65ab5b59ef67752c0c1bd3bbbbe02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  734095 
Reviewed-on: https://chromium-review.googlesource.com/1044569
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556085}
[modify] https://crrev.com/71e82edb257d2c687861e79174bea4cd07b9b03f/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Project Member

Comment 121 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4284f64ff3b868136997c824e40499f89f696055

commit 4284f64ff3b868136997c824e40499f89f696055
Author: Xi Cheng <chengx@chromium.org>
Date: Fri May 04 19:28:10 2018

Give precedence to kNotificationLaunchId over kAppId

These two switches are not intended to be used together. On the off
chance that they are, process the former and ignore the latter.

Bug:  734095 
Change-Id: Iede04895e9bef055df66fff4019e091ba7e8f09b
Reviewed-on: https://chromium-review.googlesource.com/1044543
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556148}
[modify] https://crrev.com/4284f64ff3b868136997c824e40499f89f696055/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Project Member

Comment 122 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91695ae4ffcb13db2fb6df061d198d7474d32871

commit 91695ae4ffcb13db2fb6df061d198d7474d32871
Author: Xi Cheng <chengx@chromium.org>
Date: Sat May 05 00:34:43 2018

Dedup enums in Notifications.Windows.ActivationStatus

Methods GetProfileIdFromLaunchId() and HandleActivation() are both called
in a single notification activation run. They log the same failure to UMA,
which skews the UMA failure metrics. This CL fixes it.

Bug:  734095 ,  839942 
Change-Id: If7e7cd63869a19b815052bd2b470577e06660252
Reviewed-on: https://chromium-review.googlesource.com/1040349
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556272}
[modify] https://crrev.com/91695ae4ffcb13db2fb6df061d198d7474d32871/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/91695ae4ffcb13db2fb6df061d198d7474d32871/chrome/browser/notifications/notification_platform_bridge_win_metrics.h
[modify] https://crrev.com/91695ae4ffcb13db2fb6df061d198d7474d32871/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/91695ae4ffcb13db2fb6df061d198d7474d32871/tools/metrics/histograms/histograms.xml

Project Member

Comment 123 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/933cf169043979b8fc594877d0cfe20dbd6ffe27

commit 933cf169043979b8fc594877d0cfe20dbd6ffe27
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue May 08 20:57:16 2018

Win Native Notifications: Fix window activation.

This fixes the issue with window activation not functioning correctly
when notifications are activated while Chrome is running but in the
background.

Bug:  837796 ,  734095 
Change-Id: I8eac14403850a13d60e7a50c3c795fed96205d7e
Reviewed-on: https://chromium-review.googlesource.com/1049984
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556955}
[modify] https://crrev.com/933cf169043979b8fc594877d0cfe20dbd6ffe27/chrome/notification_helper/notification_activator.cc

Project Member

Comment 124 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b260a210beabbbcf0cfc449188208dedaf92fa2

commit 2b260a210beabbbcf0cfc449188208dedaf92fa2
Author: Greg Thompson <grt@chromium.org>
Date: Wed May 09 08:50:04 2018

Revert "Win Native Notifications: Fix window activation."

This reverts commit 933cf169043979b8fc594877d0cfe20dbd6ffe27.

Reason for revert: Handle leak causing test failures.

Original change's description:
> Win Native Notifications: Fix window activation.
> 
> This fixes the issue with window activation not functioning correctly
> when notifications are activated while Chrome is running but in the
> background.
> 
> Bug:  837796 ,  734095 
> Change-Id: I8eac14403850a13d60e7a50c3c795fed96205d7e
> Reviewed-on: https://chromium-review.googlesource.com/1049984
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556955}

TBR=finnur@chromium.org,grt@chromium.org

Change-Id: Ib0e0d132867555f822dc13061b63bca123c16df9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  837796 ,  734095 
Reviewed-on: https://chromium-review.googlesource.com/1051385
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557125}
[modify] https://crrev.com/2b260a210beabbbcf0cfc449188208dedaf92fa2/chrome/notification_helper/notification_activator.cc

Project Member

Comment 125 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da40ea379decf0fefd8bb92c5a93d3f7015d7433

commit da40ea379decf0fefd8bb92c5a93d3f7015d7433
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Fri May 11 18:28:49 2018

Win Native Notifications: Fix window activation (2nd attempt).

This fixes the issue with window activation not functioning correctly
when notifications are activated while Chrome is running but in the
background.

Bug:  837796 ,  734095 
Change-Id: I69f5c358ba55fa997e1c3859d653638131f1394c
Reviewed-on: https://chromium-review.googlesource.com/1051708
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557949}
[modify] https://crrev.com/da40ea379decf0fefd8bb92c5a93d3f7015d7433/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc
[modify] https://crrev.com/da40ea379decf0fefd8bb92c5a93d3f7015d7433/chrome/notification_helper/notification_activator.cc

Project Member

Comment 126 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04

commit 31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu May 17 13:23:24 2018

Win Native Notifications: Don't abort if AllowSetForegroundWindow fails.

It may have unwanted side-effects in the Action Center and is really
a benign failure.

Bug:  841475 ,  837796 ,  734095 
Change-Id: I61cc2736742a50de72fd5a5b9c87ae233ff9a5f0
Reviewed-on: https://chromium-review.googlesource.com/1061414
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559508}
[modify] https://crrev.com/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc
[modify] https://crrev.com/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04/chrome/notification_helper/notification_activator.cc

Project Member

Comment 127 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d177c06ea367e81a95deedbf346084ab50084a1

commit 4d177c06ea367e81a95deedbf346084ab50084a1
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue May 22 16:07:54 2018

Win Native Notifications: Deflake activation test.

Bug:  845176 ,  734095 
Change-Id: Ia826226aa8fe509c0f2d7a80a106b5a60d293528
Reviewed-on: https://chromium-review.googlesource.com/1068968
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560625}
[modify] https://crrev.com/4d177c06ea367e81a95deedbf346084ab50084a1/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc

Project Member

Comment 128 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/464ac56cfa314e2823f50be894095963b1683969

commit 464ac56cfa314e2823f50be894095963b1683969
Author: Xi Cheng <chengx@chromium.org>
Date: Wed May 23 19:15:12 2018

Retire metric Notifications.Windows.UserManagerShowupStatus

This metric is no longer needed as the issue has been fixed already.

Bug:  833663 ,  734095 
Change-Id: I1a1683370700cdd650e7bdca651c27a2a7a25db4
Reviewed-on: https://chromium-review.googlesource.com/1066998
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561195}
[modify] https://crrev.com/464ac56cfa314e2823f50be894095963b1683969/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/464ac56cfa314e2823f50be894095963b1683969/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/464ac56cfa314e2823f50be894095963b1683969/tools/metrics/histograms/histograms.xml

Project Member

Comment 129 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa67db5c1a6e20836650aa14e15f7a6507a44da0

commit fa67db5c1a6e20836650aa14e15f7a6507a44da0
Author: Xi Cheng <chengx@chromium.org>
Date: Wed May 23 20:50:39 2018

Log notification launch id decode status

We have ~1% invalid launch ids that are invalid, which needs more investigation.

Bug:  839942 ,  734095 
Change-Id: Ibebb6beeebb6fe4200d49a728dde56d979a795cc
Reviewed-on: https://chromium-review.googlesource.com/1068655
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561249}
[modify] https://crrev.com/fa67db5c1a6e20836650aa14e15f7a6507a44da0/chrome/browser/notifications/notification_launch_id.cc
[modify] https://crrev.com/fa67db5c1a6e20836650aa14e15f7a6507a44da0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/fa67db5c1a6e20836650aa14e15f7a6507a44da0/tools/metrics/histograms/histograms.xml

Project Member

Comment 130 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65122ec28ea39dddda92ae6e7fbc3451f465a5bd

commit 65122ec28ea39dddda92ae6e7fbc3451f465a5bd
Author: Xi Cheng <chengx@chromium.org>
Date: Thu May 24 22:35:24 2018

Remove the inclusion of windows.h in notification_launch_id*

... as this is unnecessary.

Bug:  734095 
Change-Id: I1fc028c91ecf5c282f72b749cdd6283ed8e19e86
Reviewed-on: https://chromium-review.googlesource.com/1070624
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561660}
[modify] https://crrev.com/65122ec28ea39dddda92ae6e7fbc3451f465a5bd/chrome/browser/notifications/notification_launch_id.cc
[modify] https://crrev.com/65122ec28ea39dddda92ae6e7fbc3451f465a5bd/chrome/browser/notifications/notification_launch_id_unittest.cc

Project Member

Comment 131 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0313cc6af1f12bc8d6842c9345976bfeb46beb

commit cd0313cc6af1f12bc8d6842c9345976bfeb46beb
Author: Xi Cheng <chengx@chromium.org>
Date: Fri May 25 17:11:49 2018

Move Windows specific files in notifications/ to its sub-folder "win"

The notification_platform_bridge_win* files are not moved for now for
consistency reasons. There are no functionality changes at all.

This makes the files in notifications/ more organized and eliminates
the need of various per-file rules in the OWNERS file.

Bug:  734095 
Change-Id: I6d792a92d343841da4585edd1938295183b344be
Reviewed-on: https://chromium-review.googlesource.com/1072698
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561922}
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/BUILD.gn
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/OWNERS
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/notification_platform_bridge_win_unittest.cc
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/notification_platform_bridge_win_util.cc
[add] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/OWNERS
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/mock_itoastnotification.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/mock_itoastnotification.h
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/mock_itoastnotifier.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/mock_itoastnotifier.h
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/mock_notification_image_retainer.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/mock_notification_image_retainer.h
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_helper_launches_chrome_unittest.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_image_retainer.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_image_retainer.h
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_image_retainer_unittest.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_launch_id.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_launch_id.h
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_launch_id_unittest.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_template_builder.cc
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_template_builder.h
[rename] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/browser/notifications/win/notification_template_builder_unittest.cc
[modify] https://crrev.com/cd0313cc6af1f12bc8d6842c9345976bfeb46beb/chrome/test/BUILD.gn

Project Member

Comment 132 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed840452bc75430c5f6c14b6b481b19b2b1bd15

commit 1ed840452bc75430c5f6c14b6b481b19b2b1bd15
Author: Xi Cheng <chengx@chromium.org>
Date: Tue May 29 17:31:29 2018

Move 4 more files in notifications/ to its sub-folder "win"

... to make the files in notifications/ more organized. File names are
adjusted accordingly.

Bug:  734095 
Change-Id: Ie06882f027e6d647da534fb11823bdcc3268c4a7
Reviewed-on: https://chromium-review.googlesource.com/1073624
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562488}
[modify] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/BUILD.gn
[modify] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/notifications/win/mock_itoastnotifier.cc
[rename] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/notifications/win/notification_metrics.cc
[rename] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/notifications/win/notification_metrics.h
[rename] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/notifications/win/notification_util.cc
[rename] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/browser/notifications/win/notification_util.h

Project Member

Comment 133 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d326a008e79cb49bdc3871e08bf3fb8ef902b871

commit d326a008e79cb49bdc3871e08bf3fb8ef902b871
Author: Xi Cheng <chengx@chromium.org>
Date: Wed May 30 03:53:55 2018

Log execute status of NotificationActivator::Activate

The metric is used to help investigate the issue of empty launch id
string and verify the fix to the issue of window's not becoming
foreground.

Bug:  839942 ,  837796 ,  734095 
Change-Id: Ia52d685d0b2c866aa1d048a984bf7932e5fa52f8
Reviewed-on: https://chromium-review.googlesource.com/1077369
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562725}
[modify] https://crrev.com/d326a008e79cb49bdc3871e08bf3fb8ef902b871/chrome/notification_helper/notification_activator.cc
[modify] https://crrev.com/d326a008e79cb49bdc3871e08bf3fb8ef902b871/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/d326a008e79cb49bdc3871e08bf3fb8ef902b871/tools/metrics/histograms/histograms.xml

Project Member

Comment 134 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d326a008e79cb49bdc3871e08bf3fb8ef902b871

commit d326a008e79cb49bdc3871e08bf3fb8ef902b871
Author: Xi Cheng <chengx@chromium.org>
Date: Wed May 30 03:53:55 2018

Log execute status of NotificationActivator::Activate

The metric is used to help investigate the issue of empty launch id
string and verify the fix to the issue of window's not becoming
foreground.

Bug:  839942 ,  837796 ,  734095 
Change-Id: Ia52d685d0b2c866aa1d048a984bf7932e5fa52f8
Reviewed-on: https://chromium-review.googlesource.com/1077369
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562725}
[modify] https://crrev.com/d326a008e79cb49bdc3871e08bf3fb8ef902b871/chrome/notification_helper/notification_activator.cc
[modify] https://crrev.com/d326a008e79cb49bdc3871e08bf3fb8ef902b871/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/d326a008e79cb49bdc3871e08bf3fb8ef902b871/tools/metrics/histograms/histograms.xml

Project Member

Comment 135 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95e07d895eac53fe7fe750e67580f5644e5414a

commit b95e07d895eac53fe7fe750e67580f5644e5414a
Author: Xi Cheng <chengx@chromium.org>
Date: Wed May 30 09:29:17 2018

Update DEPS file after moving notification_helper_launches_chrome_unittest.cc

Bug:  734095 
Change-Id: I31d9a924609b9d1e8999e5e8a21376c1bbe9e9f5
Reviewed-on: https://chromium-review.googlesource.com/1076978
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562772}
[modify] https://crrev.com/b95e07d895eac53fe7fe750e67580f5644e5414a/chrome/browser/notifications/DEPS
[add] https://crrev.com/b95e07d895eac53fe7fe750e67580f5644e5414a/chrome/browser/notifications/win/DEPS

Project Member

Comment 136 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb0f4f7c07a849d26ab3e09d7106d68ef61470b3

commit bb0f4f7c07a849d26ab3e09d7106d68ef61470b3
Author: Xi Cheng <chengx@chromium.org>
Date: Thu May 31 17:37:27 2018

Update file comments after file movement

Bug:  734095 
Change-Id: I0431a43f218010bc139f5778f8d4ae2981b61408
Reviewed-on: https://chromium-review.googlesource.com/1079802
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563300}
[modify] https://crrev.com/bb0f4f7c07a849d26ab3e09d7106d68ef61470b3/chrome/browser/notifications/win/notification_helper_launches_chrome_unittest.cc
[modify] https://crrev.com/bb0f4f7c07a849d26ab3e09d7106d68ef61470b3/chrome/notification_helper/notification_helper_process_unittest.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f29c2881c785cf1193c65dd5a050d9f980d3b64

commit 3f29c2881c785cf1193c65dd5a050d9f980d3b64
Author: Xi Cheng <chengx@chromium.org>
Date: Fri Jun 01 16:13:18 2018

Fix skewed metric Notifications.Windows.SetReadyCallbackStatus

This metric is skewed as we consider all its scenarios mutual exclusive.
This CL fixes it.

Bug:  847989 ,  734095 
Change-Id: I95b852d92335f2e7aa9f6ef09bc5104487f4ad32
Reviewed-on: https://chromium-review.googlesource.com/1079887
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563663}
[modify] https://crrev.com/3f29c2881c785cf1193c65dd5a050d9f980d3b64/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/3f29c2881c785cf1193c65dd5a050d9f980d3b64/chrome/browser/notifications/win/notification_metrics.cc
[modify] https://crrev.com/3f29c2881c785cf1193c65dd5a050d9f980d3b64/chrome/browser/notifications/win/notification_metrics.h
[modify] https://crrev.com/3f29c2881c785cf1193c65dd5a050d9f980d3b64/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3f29c2881c785cf1193c65dd5a050d9f980d3b64/tools/metrics/histograms/histograms.xml

Project Member

Comment 138 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f5260501ac2660f29fb98ab5cb351a956c1dab

commit 95f5260501ac2660f29fb98ab5cb351a956c1dab
Author: Xi Cheng <chengx@chromium.org>
Date: Sat Jun 02 04:40:15 2018

Fixed skewed metric Notifications.NotificationHelper.NotificationActivatorStatus

Bug:  734095 
Change-Id: If0ba4df198402fd67decd52ee63af7be310ccd19
Reviewed-on: https://chromium-review.googlesource.com/1081239
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563929}
[modify] https://crrev.com/95f5260501ac2660f29fb98ab5cb351a956c1dab/chrome/notification_helper/notification_activator.cc
[modify] https://crrev.com/95f5260501ac2660f29fb98ab5cb351a956c1dab/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/95f5260501ac2660f29fb98ab5cb351a956c1dab/tools/metrics/histograms/histograms.xml

Project Member

Comment 139 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21f8d6fbe3d514e0092c069dcdaddd24f9e8b2cb

commit 21f8d6fbe3d514e0092c069dcdaddd24f9e8b2cb
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Jun 04 13:36:09 2018

Win Native Notifications: Add test for inline replies.

Bug:  734095 
Change-Id: I073b7a30b8a61ec02d91472c1cbb078ad526041d
Reviewed-on: https://chromium-review.googlesource.com/1084931
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564077}
[modify] https://crrev.com/21f8d6fbe3d514e0092c069dcdaddd24f9e8b2cb/chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc

Project Member

Comment 140 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa3ca59c6e0031d2c33b405da568478f5e76fc25

commit aa3ca59c6e0031d2c33b405da568478f5e76fc25
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Jun 04 17:04:50 2018

Win Native Notifications: Up the priority on reporting error from AC.

Bug:  823977 ,  734095 
Change-Id: Id9adcf5c40c987656407432d15d0477920094e23
Reviewed-on: https://chromium-review.googlesource.com/1085457
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564123}
[modify] https://crrev.com/aa3ca59c6e0031d2c33b405da568478f5e76fc25/chrome/browser/notifications/notification_platform_bridge_win.cc

Project Member

Comment 141 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ba979168c8b938da7ce898b8cd389da90f798b

commit 45ba979168c8b938da7ce898b8cd389da90f798b
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Jun 05 19:37:55 2018

Log Notifications.Windows.StartMenuShortStatus

This metric gives more details about case SHORTCUT_MISCONFIGURATION of
Notifications.Windows.SetReadyCallbackStatus.

Bug:  847989 ,  734095 
Change-Id: I5be3de19807a18b4b5eb4520cabaf464ac4668d1
Reviewed-on: https://chromium-review.googlesource.com/1086187
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564616}
[modify] https://crrev.com/45ba979168c8b938da7ce898b8cd389da90f798b/chrome/installer/util/install_util.cc
[modify] https://crrev.com/45ba979168c8b938da7ce898b8cd389da90f798b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/45ba979168c8b938da7ce898b8cd389da90f798b/tools/metrics/histograms/histograms.xml

Project Member

Comment 142 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd137b16a85e1235456e7a250c52771b6f8a0b5e

commit bd137b16a85e1235456e7a250c52771b6f8a0b5e
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Aug 22 21:17:29 2018

Win Native Notifications: Log HRESULTs on failed showing of notification.

Bug:  860654 ,  734095 
Change-Id: I4a705377166d9579f27206f92371c02445f2d6bf
Reviewed-on: https://chromium-review.googlesource.com/1185081
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585251}
[modify] https://crrev.com/bd137b16a85e1235456e7a250c52771b6f8a0b5e/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/bd137b16a85e1235456e7a250c52771b6f8a0b5e/tools/metrics/histograms/histograms.xml

Project Member

Comment 143 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6413e364fdb4faa7bf194c8e9ce789bbf873d19

commit d6413e364fdb4faa7bf194c8e9ce789bbf873d19
Author: Peter Beverloo <peter@chromium.org>
Date: Wed Aug 22 21:41:47 2018

Enable native notifications for Windows by default

Bug: 819675,  734095 
Change-Id: I9c9ff697d45118c220992b87ccbffe40ffa0bef5
Reviewed-on: https://chromium-review.googlesource.com/1185187
Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585257}
[modify] https://crrev.com/d6413e364fdb4faa7bf194c8e9ce789bbf873d19/chrome/browser/notifications/notification_display_service_impl.cc
[modify] https://crrev.com/d6413e364fdb4faa7bf194c8e9ce789bbf873d19/chrome/common/chrome_features.cc

Project Member

Comment 144 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3c45c46562ec1d99737516cc83aa7c7b916851f

commit a3c45c46562ec1d99737516cc83aa7c7b916851f
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Aug 29 00:45:09 2018

Simulate generic down/up key events to make AllowSetForegroundWindow call succeed

Despite the fact that the Windows notification center grants the helper
permission to set the foreground window, the helper fails to pass the baton
to Chrome at an alarming rate; see  https://crbug.com/837796 .

Sending generic down/up key events seems to fix it.

Bug:  837796 ,  734095 
Change-Id: I9b590d5149df35cfcb8219b0a386c5a9cfdb8eb0
Reviewed-on: https://chromium-review.googlesource.com/1192416
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586968}
[modify] https://crrev.com/a3c45c46562ec1d99737516cc83aa7c7b916851f/chrome/notification_helper/notification_activator.cc

Comment 145 by finnur@chromium.org, Aug 29

Status: Fixed (was: Started)

This has now launched.

Project Member

Comment 146 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/259dcfaa696e554b632a1ec01986c51357b7c69e

commit 259dcfaa696e554b632a1ec01986c51357b7c69e
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Sep 06 12:58:19 2018

Win Native Notifications: Fix crash when GetNamedItem returns null.

Bug: 881109,  734095 
Change-Id: Ic530a30c653c202c279bf4074022a122cfcba2ac
Reviewed-on: https://chromium-review.googlesource.com/1209485
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589144}
[modify] https://crrev.com/259dcfaa696e554b632a1ec01986c51357b7c69e/chrome/browser/notifications/win/notification_metrics.h
[modify] https://crrev.com/259dcfaa696e554b632a1ec01986c51357b7c69e/chrome/browser/notifications/win/notification_util.cc
[modify] https://crrev.com/259dcfaa696e554b632a1ec01986c51357b7c69e/tools/metrics/histograms/enums.xml

Project Member

Comment 147 by bugdroid1@chromium.org, Sep 12

Labels: merge-merged-3538

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b510da754410514058d442e5f026c899e307fd47

commit b510da754410514058d442e5f026c899e307fd47
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Sep 12 13:10:54 2018

Win Native Notifications: Fix crash when GetNamedItem returns null.

Bug: 881109,  734095 
Change-Id: Ic530a30c653c202c279bf4074022a122cfcba2ac
Reviewed-on: https://chromium-review.googlesource.com/1209485
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589144}(cherry picked from commit 259dcfaa696e554b632a1ec01986c51357b7c69e)
Reviewed-on: https://chromium-review.googlesource.com/1221317
Cr-Commit-Position: refs/branch-heads/3538@{#325}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b510da754410514058d442e5f026c899e307fd47/chrome/browser/notifications/win/notification_metrics.h
[modify] https://crrev.com/b510da754410514058d442e5f026c899e307fd47/chrome/browser/notifications/win/notification_util.cc
[modify] https://crrev.com/b510da754410514058d442e5f026c899e307fd47/tools/metrics/histograms/enums.xml

Showing comments 48 - 147 of 147 Older ›

►

Issue 734095 link

Issue metadata

Use the Windows Action Center for displaying Chrome's notifications

Issue description

Comment 48 by bugdroid1@chromium.org, Feb 23 2018

Comment 48 Deleted

Comment 49 by bugdroid1@chromium.org, Feb 23 2018

Comment 49 Deleted

Comment 50 by bugdroid1@chromium.org, Feb 23 2018

Comment 50 Deleted

Comment 51 by bugdroid1@chromium.org, Feb 23 2018

Comment 51 Deleted

Comment 52 by bugdroid1@chromium.org, Feb 24 2018

Comment 52 Deleted

Comment 53 by bugdroid1@chromium.org, Feb 24 2018

Comment 53 Deleted

Comment 54 by bugdroid1@chromium.org, Feb 26 2018

Comment 54 Deleted

Comment 55 by bugdroid1@chromium.org, Feb 26 2018

Comment 55 Deleted

Comment 56 by bugdroid1@chromium.org, Feb 27 2018

Comment 56 Deleted

Comment 57 by bugdroid1@chromium.org, Feb 27 2018

Comment 57 Deleted

Comment 58 by chengx@chromium.org, Feb 27 2018

Comment 58 Deleted

Comment 59 by chengx@chromium.org, Feb 27 2018

Comment 59 Deleted

Comment 60 by chengx@chromium.org, Feb 27 2018

Comment 60 Deleted

Comment 61 by chengx@chromium.org, Mar 1 2018

Comment 61 Deleted

Comment 62 by bugdroid1@chromium.org, Mar 2 2018

Comment 62 Deleted

Comment 63 by bugdroid1@chromium.org, Mar 7 2018

Comment 63 Deleted

Comment 64 by peter@chromium.org, Mar 7 2018

Comment 64 Deleted

Comment 65 by bugdroid1@chromium.org, Mar 8 2018

Comment 65 Deleted

Comment 66 by bugdroid1@chromium.org, Mar 8 2018

Comment 66 Deleted

Comment 67 by bugdroid1@chromium.org, Mar 8 2018

Comment 67 Deleted

Comment 68 by bugdroid1@chromium.org, Mar 9 2018

Comment 68 Deleted

Comment 69 by bugdroid1@chromium.org, Mar 12 2018

Comment 69 Deleted

Comment 70 by bugdroid1@chromium.org, Mar 13 2018

Comment 70 Deleted

Comment 71 by bugdroid1@chromium.org, Mar 15 2018

Comment 71 Deleted

Comment 72 by bugdroid1@chromium.org, Mar 19 2018

Comment 72 Deleted

Comment 73 by bugdroid1@chromium.org, Mar 20 2018

Comment 73 Deleted

Comment 74 by bugdroid1@chromium.org, Mar 20 2018

Comment 74 Deleted

Comment 75 by bugdroid1@chromium.org, Mar 26 2018

Comment 75 Deleted

Comment 76 by bugdroid1@chromium.org, Mar 26 2018

Comment 76 Deleted

Comment 77 by bugdroid1@chromium.org, Mar 27 2018

Comment 77 Deleted

Comment 78 by bugdroid1@chromium.org, Mar 27 2018

Comment 78 Deleted

Comment 79 by bugdroid1@chromium.org, Mar 27 2018

Comment 79 Deleted

Comment 80 by bugdroid1@chromium.org, Mar 27 2018

Comment 80 Deleted

Comment 81 by bugdroid1@chromium.org, Mar 30 2018

Comment 81 Deleted

Comment 82 by bugdroid1@chromium.org, Mar 30 2018

Comment 82 Deleted

Comment 83 by bugdroid1@chromium.org, Mar 30 2018

Comment 83 Deleted

Comment 84 by bugdroid1@chromium.org, Apr 3 2018

Comment 84 Deleted

Comment 85 by bugdroid1@chromium.org, Apr 3 2018

Comment 85 Deleted