nominated flag not set on candidate-pair
Reported by
fi...@appear.in,
Jun 16 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/58.0.3029.110 Chrome/58.0.3029.110 Safari/537.36 Steps to reproduce the problem: 1. go to https://webrtc.github.io/samples/src/content/peerconnection/pc1/ 2. make a call 3. execute this JS in the console: pc1.getStats() .then(result => result.forEach(report => { if (report.type === "candidate-pair") console.log(report.type, report.nominated, report); }) ) What is the expected behavior? there is at least one nominated candidate pair (and if the transport object has a selectedCandidatePairId then this pair is nominated?) What went wrong? nominated is false for all (just one) candidate pairs Did this work before? N/A Does this work in other browsers? N/A Chrome version: 61.0.3128.3 Channel: n/a OS Version: Flash Version: Shockwave Flash 16.0 r0
,
Jun 20 2017
,
Jun 23 2017
Able to reproduce the issue on Windows 7,Mac 10.12.5 & Ubuntu 14.04 using chrome stable#59.0.3071.109, Canary#61.0.3139.0 & reported version#61.0.3128.3 as per the steps mentioned in comment#0. Observed candidate pairs- False for all candidate pairs in Console after executing the above JS code. This is non regression issue observed from M58 builds,hence marking it as 'Untriaged' to get more inputs from dev. Note: 'No candidate pair' data observed in the earlier builds of M58.
,
Jun 28 2017
If this is a non-regression issue, why was it changed to Bug-Regression?
,
Jun 28 2017
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/86c40a14b48c8eff0dd7af048f30747af2c61016 commit 86c40a14b48c8eff0dd7af048f30747af2c61016 Author: deadbeef <deadbeef@webrtc.org> Date: Wed Jun 28 16:37:23 2017 Fixing RTCIceCandidatePairStats.nominated for ICE controlling agent. Was only working when the nonstandard "renomination" extension to ICE is enabled, which chromium doesn't use. BUG= chromium:734094 Review-Url: https://codereview.webrtc.org/2957303002 Cr-Commit-Position: refs/heads/master@{#18814} [modify] https://crrev.com/86c40a14b48c8eff0dd7af048f30747af2c61016/webrtc/p2p/base/port.cc [modify] https://crrev.com/86c40a14b48c8eff0dd7af048f30747af2c61016/webrtc/pc/rtcstats_integrationtest.cc
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/86c40a14b48c8eff0dd7af048f30747af2c61016 commit 86c40a14b48c8eff0dd7af048f30747af2c61016 Author: deadbeef <deadbeef@webrtc.org> Date: Wed Jun 28 16:37:23 2017 Fixing RTCIceCandidatePairStats.nominated for ICE controlling agent. Was only working when the nonstandard "renomination" extension to ICE is enabled, which chromium doesn't use. BUG= chromium:734094 Review-Url: https://codereview.webrtc.org/2957303002 Cr-Commit-Position: refs/heads/master@{#18814} [modify] https://crrev.com/86c40a14b48c8eff0dd7af048f30747af2c61016/webrtc/p2p/base/port.cc [modify] https://crrev.com/86c40a14b48c8eff0dd7af048f30747af2c61016/webrtc/pc/rtcstats_integrationtest.cc
,
Jun 29 2017
Why did you comment twice, bugdroid? Anyway, confirmed that this is fixed in Chrome Canary. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Jun 19 2017