New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734081 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Don't show error on unknown-result payment transactions

Project Member Reported by rouslan@chromium.org, Jun 16 2017

Issue description

Only PaymentResponse.complete("fail") should show an error dialog.

Calling PaymentResponse.complete("success"), PaymentResponse.complete("unknown"), and PaymentResponse.complete() should not show an error dialog.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3473192cbea2379e3275c24237e6344cd930519

commit e3473192cbea2379e3275c24237e6344cd930519
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jun 16 17:17:55 2017

Don't show error on unknown-result payment transactions.

Before this patch, calling PaymentResponse.complete("unknown") and
PaymentResponse.complete() would show an error dialog on desktop
implementations of PaymentRequest. This is contrary to the spec and does
not match Android and iOS implementations.

This patch changes the error dialog showing condition from
"status != success" to "status == fail".

After this patch, only calling PaymentResponse.complete("fail") will
show an error dialog.

Bug:  734081 
Change-Id: I579d6a012f9caae4172066deddcb9e86bf17ef06
Reviewed-on: https://chromium-review.googlesource.com/538256
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480086}
[modify] https://crrev.com/e3473192cbea2379e3275c24237e6344cd930519/components/payments/content/payment_request.cc

Cc: ma...@chromium.org zkoch@chromium.org anthonyvd@chromium.org
Labels: Merge-Request-60
Hello, I would like to merge this into M-60 to enable shipping PaymentRequest on desktop with correct implementation of the spec.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 17 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: krajshree@chromium.org
Labels: Needs-Feedback
rouslan@ - Could you please provide a sample test file or sample URL to test the issue.

Thanks...!!
Koiredla, the test URL https://rsolomakhin.github.io/pr/type/credit/. Type in the correct CVC number for your credit card: it should show the credit card number on the page in green text after my patch.

Beware that the card number is not masked on that webpage, so beware shoulder surfers. That is a demo website and no payment is made.

Before my patch, the page always showed "Transaction failed" error message in the payment dialog, even if you typed in the correct CVC number.

Comment 6 by ma...@chromium.org, Jun 20 2017

Status: Fixed (was: Started)

Comment 7 by ma...@chromium.org, Jun 21 2017

Labels: -Hotlist-Merge-Review -Needs-Feedback -M-60 -Merge-Review-60 M-61
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment