New issue
Advanced search Search tips

Issue 734078 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 543997



Sign in to add a comment

Implement MediaStreamTrack.getSettings for supported constraints

Project Member Reported by guidou@chromium.org, Jun 16 2017

Issue description

The following constraints are supported by Chrome, but are not supported by MediaStreamTrack.getSettings():

* aspectRatio
* echoCancellation;
* deviceId;

 

Comment 1 by guidou@chromium.org, Jun 16 2017

Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature

Comment 2 by guidou@chromium.org, Jun 16 2017

Cc: guidou@chromium.org
 Issue 682245  has been merged into this issue.

Comment 3 by guidou@chromium.org, Jun 16 2017

Blocking: 543997

Comment 4 by guidou@chromium.org, Jun 28 2017

suport for facingMode should be added too.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6eca8a125174a843cd9271ca83b60dd4390cd19

commit f6eca8a125174a843cd9271ca83b60dd4390cd19
Author: guidou <guidou@chromium.org>
Date: Thu Jul 06 09:21:27 2017

Add support for facingMode in MediaStreamTrack.getSettings() on Android.

BUG= 734078 

Review-Url: https://codereview.chromium.org/2970453003
Cr-Commit-Position: refs/heads/master@{#484510}

[modify] https://crrev.com/f6eca8a125174a843cd9271ca83b60dd4390cd19/content/renderer/media/media_stream_video_track.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43855d4106b745fa975172372ece8b0492be5fda

commit 43855d4106b745fa975172372ece8b0492be5fda
Author: guidou <guidou@chromium.org>
Date: Thu Jul 06 15:17:55 2017

Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings

This CL adds support for the echoCancellation and deviceId properties to
MediaStreamTrack.getSettings() for audio tracks created with getUserMedia().

The deviceId support for audio tracks was broken due to a placeholder implementation of MediaStreamAudioTrack::GetSettings, which masked the existing correct implementation in WebMediaStreamSource.

deviceId was already supported for video tracks.

BUG= 734078 

Review-Url: https://codereview.chromium.org/2956063003
Cr-Commit-Position: refs/heads/master@{#484600}

[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/renderer/media/media_stream_audio_track.cc
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/renderer/media/media_stream_audio_track.h
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/content/test/data/media/getusermedia.html
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/public/platform/WebMediaStreamSource.h
[modify] https://crrev.com/43855d4106b745fa975172372ece8b0492be5fda/third_party/WebKit/public/platform/WebMediaStreamTrack.h

Status: Fixed (was: Assigned)

Comment 8 by guidou@chromium.org, Jul 21 2017

Cc: jmukthavaram@chromium.org
 Issue 746973  has been merged into this issue.

Sign in to add a comment