New issue
Advanced search Search tips

Issue 734075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ImplementedAs= on dictionary members still uses the word for a local variable name

Project Member Reported by jbroman@chromium.org, Jun 16 2017

Issue description

This causes issues if the member is a C++ keyword.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4644f6fdf12854ac8f5927460d39645318c40e6a

commit 4644f6fdf12854ac8f5927460d39645318c40e6a
Author: Jeremy Roman <jbroman@chromium.org>
Date: Fri Jun 16 16:53:55 2017

Bindings: Prevent dictionary value local variable from colliding with C++ keywords.

Using |cpp_value| was considered, but since it's possible for this to be the
same between two members (using ImplementedAs=), this seemed slightly confusing
when reading the generated source.

Instead, following the V8 representation of the value, {{member.name}}Value,
the C++ value has been named {{member.name}}CppValue.

Bug:  734075 
Change-Id: I89977f652f815732080341889cc8cb5901223182
Reviewed-on: https://chromium-review.googlesource.com/538594
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480074}
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp
[modify] https://crrev.com/4644f6fdf12854ac8f5927460d39645318c40e6a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Status: Fixed (was: Started)

Sign in to add a comment